[13:36:56] <mdholloway>	 dbrant: o/ hey, were you going to look at that onReferenceClicked WebView <-> Java cruft, or should i look into it and update my patch?  it sounded the other day like you were going to look at it, but i'm happy to if you're busy on something else
[13:38:39] <dbrant>	 mdholloway: ah yes, I have actually looked into it a bit, and it's more complex and edge-casey than I imagined.  I think that what you've got in that patch may be the right way to go for now.
[13:39:04] <mdholloway>	 dbrant: ah, sounds good!
[14:12:56] <dbrant>	 mdholloway: can you help a bit with running tests on the content service (locally)?
[14:13:04] <dbrant>	 It's saying it cannot find module 'eslint-config-wikimedia'
[14:13:43] <dbrant>	 i've run npm install, and it also gives a warning about eslint-config-wikimedia not being found
[14:13:52] <mdholloway>	 dbrant: yeah, i ran into that the other day too
[14:14:11] <mdholloway>	 i just tried 'npm install'-ing that specific package and it worked
[14:14:37] <mdholloway>	 not sure what's going on there
[14:15:43] <dbrant>	 mdholloway: thanks, that worked.  Now, for the real question:
[14:17:53] <dbrant>	 mdholloway: some of the tests are diffed against hard-coded responses that are stored in the "results" directory.  If I make a patch that changes the expected output, is there a way to overwrite those expected output files?
[14:20:06] <mdholloway>	 dbrant: i don't know of any efficient way, unfortunately.  probably worth asking bearND|afk if he has any tricks
[14:20:40] <mdholloway>	 dbrant: actually, those cause breakage quite regularly without any code changes on our part, due to, say, parsoid changes.  it wouldn't surprise me if they're failing on master.
[14:21:10] <mdholloway>	 i shouldn't say they cause breakage.  the service isn't broken.  the tests just fail (probably) spuriously.
[14:23:31] <mdholloway>	 there is a way to *completely* regenerate the stored HTML fixture files, but that leads to an enormous diff and i don't think it's recommended.
[14:24:19] <mdholloway>	 in any case, probably best to check with bearND|afk.  i haven't been doing enough MCS work lately to really know the way to go there
[14:28:03] <bearND|afk>	  /nick bearND
[14:30:41] <bearND>	 mdholloway: dbrant: I'm going to regenerate the diff results in a bit, on master first. There's a flag in test-spec.js to do that.
[14:31:12] <dbrant>	 bearND: mdholloway: thanks!
[15:15:53] <thedj>	 who is the current designer for mobile web ?
[15:16:10] <thedj>	 still nirzar ?
[15:16:35] <dbrant>	 I believe so
[15:20:16] <thedj>	 thx
[17:29:53] <bearND>	 dbrant mdholloway niedzielski: Note that audio files get the video tag by Parsoid, too. See my comment in https://gerrit.wikimedia.org/r/#/c/351865. 
[17:33:26] <niedzielski>	 bearND: i think our media transform code does something like "remove the 'play media' link and make the image clickable". does this already affect clients today or is it an upcoming change?
[17:34:03] <bearND>	 niedzielski: it's already live
[17:42:11] <niedzielski>	 bearND: hm, i think our video links might be broken :[ i believe the economic policy video in the obama article worked yesterday but not today? the mediawiki version appears to work correctly. the page rendering is also a bit off on the parsoid version
[18:00:48] <bearND>	 hmm, not good
[18:03:59] <niedzielski>	 bearND: interestingly, audio links appear to work fine though
[18:06:06] <bearND>	 niedzielski: in the app none work on my test page (neither through MCS or MW API)
[18:07:12] <niedzielski>	 bearND: i think there's a bug on the webview implementation on some devices. try the emulator or another device
[18:07:55] <bearND>	 niedzielski: I've tried a Nexus 5 and 9
[18:08:19] <niedzielski>	 bearND: hm, i'm not sure. i don't have either of those :[ what's the logcat show?
[18:09:48] <niedzielski>	 oh wait! i forgot that i do have a nexus 5. just a second
[18:12:34] <bearND>	 niedzielski: 
[18:12:40] <bearND>	 05-04 12:11:41.480 27316-28010/? E/chromium: [ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"FFmpegDemuxer: open context failed"}
[18:12:40] <bearND>	 05-04 12:11:41.482 27316-27866/? E/chromium: [ERROR:render_media_log.cc(30)] MediaEvent: PIPELINE_ERROR demuxer: could not open
[18:13:24] <niedzielski>	 bearND: hm, i saw that issue on a pixel but it actually works fine on a nexus 5 (i'm using the beatles article)
[18:18:50] <niedzielski>	 bearND: i don't think we can do much about the audio codec issue but i'll open a bug to track it if we don't have one and i'll look into the video issue
[18:54:58] <dbrant>	 niedzielski: If I want to test out some local changes to applib, how would I go about importing them into the local app code?
[18:56:25] <niedzielski>	 dbrant: monte uses npm link / unlink. i modify the gruntfile directly. we're working on documentation for this. i can either jump on a hangout with you right now or write something up and send it to you
[18:56:46] <dbrant>	 niedzielski: hangout?
[18:57:16] <mhurd>	 dbrant: the npm link approach i super easy, but require a couple steps. i can hang later today but in meeting atm
[18:57:17] <niedzielski>	 sure omw
[18:57:31] <mhurd>	 *is super easy
[19:02:53] <nzr>	 raynor|afk: im kicked out of rw again :(
[19:14:35] <mdholloway>	 niedzielski: whenever you get back, i'm curious, what diff tool do you have set up to use with git-diff-img?
[19:15:04] <mdholloway>	 i'm going to make a push to get these screenshots updated
[19:18:55] <niedzielski>	 mdholloway: o/
[19:19:02] <mdholloway>	 niedzielski: hey there
[19:19:11] <niedzielski>	 mdholloway: i use imagemagick which i believe is available on homebrew
[19:19:17] <mdholloway>	 hmm, i should have that
[19:19:27] <mdholloway>	 i must be doing something wrong
[19:20:33] <niedzielski>	 mdholloway: if you type "display" in a terminal, what happens?
[19:20:54] <mdholloway>	 display: delegate library support not built-in '' (X11) @ error/display.c/DisplayImageCommand/1891.
[19:21:32] <niedzielski>	 mdholloway: yeesh
[19:21:55] <niedzielski>	 mdholloway: maybe you need to reinstall with `brew install imagemagick --with-x11`
[19:21:57] <niedzielski>	 http://paulmestemaker.com/imagemagick-display-mac-os-x/
[19:22:11] <mdholloway>	 i'll give that a try
[19:22:24] <mdholloway>	 if that doesn't improve things, i could always just go grab the ubuntu laptop :)
[19:22:34] <mdholloway>	 brew install imagemagick --with-x11
[19:22:38] <mdholloway>	 er
[19:22:42] <mdholloway>	 better change to the terminal
[19:24:13] <niedzielski>	 mdholloway: i think another you could do is just replace the display command with some mac image viewer
[19:24:42] <niedzielski>	 mdholloway: display was nice because it can read from stdin but you could write out the diff to a temporary file and maybe try opening it with `open`
[19:28:22] <raynor>	 nzr: are you identified with services ?
[19:28:34] <raynor>	 can you join #wikimedia-staff ?
[19:28:39] <nzr>	 raynor: still dont know what that means. everytime i restart irccloud it logs me out
[19:28:45] <nzr>	 Cannot join channel (+r) - you need to be identified with services
[19:29:21] <raynor>	 nzr: https://www.mediawiki.org/wiki/Reading/Web/Team/IRC
[19:29:25] <raynor>	 I created a document for you :)
[19:30:12] <raynor>	 you need to be identified with services, when you get this error you have to msg NickServ
[19:30:20] <nzr>	 > nzr is not a registered nickname.
[19:30:23] <nzr>	 thats what i get
[19:31:00] <raynor>	 so you need to register
[19:31:10] <mdholloway>	 niedzielski: ok, took a while to build but this is more like it: 'display' launches an x11 window.
[19:31:14] <mdholloway>	 lemme try again now
[19:31:18] <nzr>	 register says "no such nickserve"
[19:38:31] <niedzielski>	 mdholloway: that's promising
[21:13:22] <dbrant>	 niedzielski: thanks for merging!  So am I correct that we can now update the app to reference the newest version of 'wikimedia-page-library' and re-run grunt?
[21:14:13] <niedzielski>	 dbrant: yes!
[21:14:22] <dbrant>	 cool, i'll do a patch