[06:43:34] Hi all. Anybody from the Android dev team present? [14:17:54] Hi Everyone, [14:18:03] This is yashasvi, from India. [14:18:28] I am an Android developer and am interested in contributing to wikipedia android client [14:19:04] I've set up the codebase on my local machine by following the instructions here : https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Android/App_hacking [14:19:47] As mentioned in the guide, I was thinking of starting my contribution with this `easy` marked task : https://phabricator.wikimedia.org/T159722 [14:20:25] but I have a doubt before proceeding further [14:20:40] I've also commented it on the task : https://phabricator.wikimedia.org/T159722#3313509 [14:20:55] can someone please help me with this? :) [14:26:30] niedzielski: mdholloway : can you please help me with this? :) [14:27:43] yashasvi, sorry I'm out moving today [14:28:09] yashasvi: o/ looking into it now [14:28:31] niedzielski: sure [14:28:35] mdholloway: thanks [14:28:45] yashasvi: you're welcome! [14:28:55] yashasvi: i would suggest grabbing the current alpha from https://android-builds.wmflabs.org/ now [14:29:31] after the next patch is merged, the alpha there will be updated, and you will have an old one! [14:29:47] unfortunately for our purposes here, we don't archive alpha builds [14:29:54] (they happen too frequently) [14:30:32] yashasvi: after you've grabbed the current alpha, i'll ping you when it's been superseded and is ready for testing [14:31:36] mdholloway: sure. that'd help a a lot. [14:31:46] I've downloaded the current alpha [14:32:21] yashasvi: great. i'll either get in touch here, or on the ticket (if you're offline) when it's ready for testing [14:32:46] mdholloway: sure, thanks a lot for the quick turnaround ! [14:33:25] yashasvi: you're welcome! [14:46:40] oops, I responded on the ticket [14:59:59] bearND: thanks. Got the idea. I no longer need the old build. Modifying the code so that it shows notification in each case [15:00:06] as I've to just check the notification icon [15:00:34] and as a matter of fact, I've reproduced it. In the process of fixing it now. [15:00:38] mdholloway: ^ [15:01:21] yashasvi: ah, great. [15:06:10] yashasvi: 👍 [15:06:43] mdholloway: niedzielski: are we pencils-down on the release? :D [15:06:51] yashasvi: just remember to revert those code changes before you commit [15:07:24] bearND: yeah sure [15:07:34] dbrant: niedzielski: i believe so! [15:08:11] dbrant mholloway yeep [18:25:31] coreyfloyd: ran out of battery, did I miss anything important? [18:26:43] tgr: nope. I was just about to ask you if you need anything from me beyond filing the electron tasks and coordinating with olga? [18:28:49] coreyfloyd: don't think so, thanks. One task sort of exists already (T167117 is about comparing wkhtmltopdf with electron). I can file the other one if you prefer [18:28:49] T167117: [Spike 6hrs] Investigate ability ot wkhtmltopdf to render single articles - https://phabricator.wikimedia.org/T167117 [18:29:21] tgr: sure thanks! [18:30:26] tgr: is evaluating the possibility of creating a toc enough to keep you busy then? [18:31:32] not for a week [18:32:03] there are stil the non-PHP parts of TemplateStyles to work on if I run out of things to do, though [18:48:50] tgr: 👍 [18:49:34] Tgr if anything else comes up for ocg I can let you know