[09:19:01] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Can_this_huge_canned_edit_summary_issue_with_Wikipedia_be_fixed.3F [13:27:19] mdholloway: niedzielski: how about we squeeze this one in, then proceed with release? https://gerrit.wikimedia.org/r/357596 [13:38:54] dbrant: sounds good to me. [15:35:51] raynor: ok if i reschedule our 1:1? talking ocg [15:37:08] dr0ptp4kt: sure, np [15:37:19] raynor: thanks! [16:19:51] Hello all, I recently saw a few error and warnings in logcat while running the latest alpha. I wanted to know if they were interest to someone, in which case I would share them. [16:43:07] kaartic: o/ thanks for reporting. it's hard to say whether a warning or error is serious or not in the abstract; for instance, in some less critical cases, we may just let network request fail and log the error, but do nothing. did you see any warnings or errors associated with buggy behavior in the app? [16:45:44] Not sure. I saw an exception with the message "java.io.IOException: Error retrieving history entry for suggestions" [16:45:56] Another with "java.io.IOException: Error fetching last-read page" [16:46:38] I also saw two error with the following messages, [16:46:38] Error while loading asset assets/natives_blob_64.bin: java.io.FileNotFoundException: assets/natives_blob_64.bin [16:46:45] Error while loading asset assets/natives_blob_64.bin: java.io.FileNotFoundException: assets/natives_blob_64.bin [16:47:09] Sorry, that was only one error! [16:48:49] Those exceptions were what caught my eye. I thought they were to be reported. [16:55:07] kaartic: ah, thanks. I think the first two are to be expected if the user is on a fresh install with no browsing history [16:55:56] the app looks for a history entry to use for the cards, finds none, and an exception is thrown and caught; in other words, behaving as expected. [16:56:57] yes. But I found it suspicious as the whole stack trace of the exception was logged. nothing else. [16:57:12] not sure about the natives_blog_64.bin problem but that doesn't look like anything that we touch directly. [16:58:05] i can see how that could be a bit misleading if unexpected [17:04:55] Another question I have is, Are the article in reading list updated automatically? [17:10:26] they are not. [17:10:54] if you visit an article in your reading list while online, it will save the latest version. [17:17:36] ok. I would like to ask one last question for now. [17:19:30] I came to know a few months ago that the app loads MapBox in the background when a user switches to the History tab. Is there any strong reason for doing this? [17:22:03] I ask this for a variety of reasons. One being that, the users I see in my area are not even aware that a "Nearby" feature exists in the app. Even though they know it exists, they use it in very very rare ocassions. So, has it been thought that loading Mapbox in the background is worth enough ? [17:31:17] yes, we've considered it. unfortunately this is a byproduct of how the ViewPager component works in Android (it wants to always cache the screen to the left and right of the current screen). [17:31:55] i agree that it might be better if we could find a way for the Nearby fragment to not load at all until it's explicitly switched to. [17:32:18] tgr: I added some of the items you mentioned yesterday to https://etherpad.wikimedia.org/p/Scrum-of-Scrums. Feel free to edit if needed [17:36:11] I . Thanks for the info. I just wanted to know it because I could see a lag everytime I try to switch to the "History" tab after some time. [17:37:37] Just out of curiosity, isn't there any way to customise the viewpager to avoid such behaviour in the app? [17:38:36] nothing short of writing your own ViewPager. [17:44:26] ok, I don't think that's as easy a task that could be done (at least by me) but I do think of an alternative which could be done. [17:44:57] I'm not sure if it's the right thing to do. [17:47:47] The alternative would be to show a card in the explore feed for that would take the user to the "Nearby" section when he taps on it. [17:49:30] The "Nearby" section could be removed from the bottom navbar and thus having just three tabs in the bottom navbar. I guess this avoids the overhead of loading Mapbox each time the User goes to the History section. [17:52:16] If there is a possibility to dynamically add a view to the ViewPager, then when a user taps on the "Nearby" card the view corresponding to "Nearby" could be shown and it could be hidden when he navigates away from it. [17:58:32] kaartic: dbrant: if anything, i could see possibly removing the viewpager and handling the transitions between fragments in some other way [17:59:22] or remove Nearby :P [18:00:21] mdholloway: niedzielski: release notes in the usual place... [18:01:05] I'm not sure if i'm looking at the right place but I see a `setOffscreenPageLimit` method in the ViewePager class. Isn't there a way to pass a value of 0 to it. [18:01:36] Or would that affect performance of the loading "History" and "My Lists" screen [18:02:04] it has a minimum value of 1. [18:04:00] dbrant: thanks [18:04:53] I see but it seems odd. There's no note about that minimum limit in the documentation [18:08:49] Seems there's a question in SO that mentions a similar issue. The answer found at https://stackoverflow.com/a/25676323/5614968 seems interesting (atleast to me). Is it feasible by any means ? [18:10:04] dbrant: 👍 i just added a couple suggestions but looks good to me otherwise [18:10:18] niedzielski: cool, thx! [18:10:29] dbrant: np! thank you! [18:12:50] kaartic: if you submit a patch that does it that way, we'll certainly consider it! [18:14:39] dbrant: niedzielski-afk: release notes lgtm [18:19:07] I guess I'm not that familiar with the android, yet. I could try but it's upto the reviewer to ensure I didn't do anything wrong :) [18:24:31] Which method of the NearbyFragment invokes the loading of MapBox ? [19:20:18] PagePreviews: Is it possible for 3rd party users to configure which namespaces PP will work with? Question at https://www.mediawiki.org/wiki/Topic:Trvyga8ol7lnlymp -- I looked around and see stuff about wgContentNamespaces in https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/processLinks.js but I'm not sure if (or how) they can tweak that easily? [22:48:43] jdlrobson: greg-g noted https://phabricator.wikimedia.org/T167358. i'll follow up with an email, but wanted to give a shout on irc [22:51:15] it may not be hovercards / page previews, unsure. will note that, too.