[00:18:35] b/msg kaldari https://en.wikipedia.org/wiki/Module_talk:Infobox_military_conflict#Why_are_campaignbox_infoboxes_wrapped.3F [12:16:44] nick reets [14:17:09] dbrant: any further confirmation needed for https://gerrit.wikimedia.org/r/#/c/361862/ or can it be merged at once? [14:18:09] mdholloway: it's ready to go. [16:06:37] hello all [16:06:54] jdlrobson: is reading web still blocked by T168743 or is that resolved now? [16:06:54] T168743: Translate tag doesn't get parsed on action=parse - https://phabricator.wikimedia.org/T168743 [16:07:17] tgr: i need to check it today, but hopefully the solution we've come up with works :) [16:08:13] I recently came to know that the android app saves a newer version of a saved page whenever a user visits the page when he's online [16:09:07] jdlrobson: just wondering whether it needs to be called out in SoS, which is an hour from now [16:09:32] tgr: other eyes wouldn't hurt [16:09:38] as right now just nikerabbit and myself :) [16:09:47] ack [16:10:00] but it's looking like we've got a solution [16:10:52] In that case wouldn't it be nice to inform that feature in some way to the users. They would possibly be interested/excited in knowing a way of updating the pages they have saved. [16:20:52] kaartic: I think it's even nicer if the user automatically gets the updated page, and doesn't have to worry about it. [16:37:01] dbrant: Yes, that's a valid point. My point is "why isn't the existence of the feature (automatically updating saved page) exposed to the user in any way?" [16:38:03] I'm asking this because there would certainly be a few users who would be worrying about updating the pages they have saved for offline reading. [16:38:25] why would it be a worry? [16:44:36] I've been trying to push to gerrit for the last half hour [16:44:43] I keep getting: [16:44:44] To ssh://gerrit.wikimedia.org:29418/apps/android [16:44:45] ! [remote rejected] HEAD -> refs/for/master (branch master not found) [16:44:50] no matter what method I try [16:44:54] any advice? [16:47:54] dbrant: It's a worry for users who are mostly offline and save pages to read when they're offline. In that case they would update the pages they have saved only when they get internet access, occasionally. In which case they would be searching the app for a way to update the *pages* they have save previously and not yet read, when they get internet access. [16:48:29] If the app doesn't inform them that it's updating the pages when they visit it, they wouldn't know about it. [16:50:05] As a result, they could possibly take the "hard way" of updating the pages (which makes the great work done by the app to update the pages to be a meaningless one) [16:50:58] correction: meaningless -> absurd [16:55:29] amrox: should be ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia [16:57:35] mdholloway: hah thanks, not sure how I managed truncating the remote URL [17:20:35] mdholloway: rebasing... [17:34:04] dbrant: did I answer your question ? [17:34:45] yep! [17:39:48] I also wanted to know ask something else. [17:42:00] While trying to pull-to-refresh icon from in the explore tab the app seems to show the circular spinner from the title bar. [17:43:10] I recently came across the material design spec which states that, [17:43:31] "Swipe to refresh is a swipe gesture *available at the beginning of* lists, grid lists, and card collections that are sorted by recent content." [17:44:03] also, [17:44:16] "The swipe to refresh gesture is available at the *top or bottom* of content collections." [17:45:13] IIRC, it seems to suggest that the spinner be positioned near the top (bottom) of the content being refreshed. [17:47:04] In that case wouldn't it be more appropriate to originate the "circular spinner" from somewhere below the search bar, as the search bar isn't updated while refreshing. [17:47:14] ? [17:48:52] Feel free to submit a patch! [17:58:31] I'll try! [17:59:05] BTW, speaking of patches. Any reason why the following patch isn't being reviewed? [17:59:08] https://gerrit.wikimedia.org/r/#/c/357020/ [18:05:56] hey coreyfloyd dbrant what is the current status of the new MCS endpoint https://github.com/wikimedia/mediawiki-services-mobileapps/blob/master/routes/mobile-sections.js#L383 [18:06:00] i cant find a task about it [18:06:08] and it's come up again.. we might want to use it for page previews [18:06:47] jdlrobson: ops asked for someone to double-check the timeline for https://gerrit.wikimedia.org/r/#/c/359417/ [18:08:57] tgr: it can be merged now [18:09:13] ill reply [18:09:18] thx [18:22:45] jdlrobson: let me find you the other tickets [18:23:37] jdlrobson: you can check out the work bearND is doing here: https://phabricator.wikimedia.org/project/view/2727/ [18:24:14] jdlrobson: basically all the tickets for separating out logic and breaking up the end point are on the board [19:33:50] jdlrobson: what's going on right now is getting an HTML endpoint, then followed by one or more json endpoints for metadata [20:13:53] dbrant: i think there's a problem with https://gerrit.wikimedia.org/r/#/c/361737/, namely that it can put the app in an unresponsive state [20:14:10] to repro (on master): log in as a user, log out, then log in as a different user [20:14:44] the app will become unresponsive, then be unresponsive on future startups until it is relaunched with that change reverted [20:15:02] https://www.irccloud.com/pastebin/OiHzKHXM/ [20:15:03] looking [20:15:12] (from traces.txt) [20:15:45] hmm, I never cared for that wait/notify logic... [20:36:56] mdholloway: will push a patch in a bit. [21:15:42] mdholloway: ready - https://gerrit.wikimedia.org/r/362033 [21:16:01] mdholloway: I removed all the mucking with wait/notify, and ioexceptions, etc. [21:16:16] dbrant: cool! will look shortly [23:14:21] bearND|afk: coreyfloyd sorry for late reply.. im a little confused about how/when Android are migrating to the new endpoint. Hopefully we can talk about that tomorrow during the sync.