[14:55:53] <thedj>	 i added maps to mobile :)
[14:56:39] <thedj>	 Go to https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets
[14:56:56] <thedj>	 check "Add map popups to coordinates in the mobile website"
[14:57:14] <thedj>	 visit https://en.m.wikipedia.org/wiki/San_Francisco
[14:57:20] <thedj>	 click a coordinate
[15:11:31] <thedj>	 jdlrobson: ^^
[15:13:17] <thedj>	 jdlrobson: i had to duplicate the /maplink/ route, as i couldn't seem to plugin to that module
[15:13:37] <thedj>	 jgirault: ping for you too
[16:25:41] <jdlrobson>	 thedj: nice :) ping nzr ^
[16:26:07] <jdlrobson>	 bearND: any chance of some reviews/merges on my mobileapps patches today?
[16:26:25] <jdlrobson>	 https://gerrit.wikimedia.org/r/365192, https://gerrit.wikimedia.org/r/365191, https://gerrit.wikimedia.org/r/365277
[16:34:21] <bearND>	 jdlrobson: sure. will do in a bit
[16:48:38] <jdlrobson>	 bearND: thanks! there's also https://gerrit.wikimedia.org/r/366587 now
[16:48:54] <jdlrobson>	 all this will help provide the scaffolding for the new page previews endpoint (and improve apps api in the process :))
[17:30:42] <bearND>	 jdlrobson: left a comment on the disambig patch. If you want me to regenerate the diff results let me know.
[17:30:52] <bearND>	 diff test results
[17:33:17] <bearND>	 Nvm, looks like with your updates it works now. :)
[17:42:47] <jdlrobson>	 bearND: :)
[17:42:51] <jdlrobson>	 bearND: does that work for you?
[17:42:59] <jdlrobson>	 i think that's better anyway.. since most pages are not disambiguation
[17:43:05] <jdlrobson>	 so why bother with additional field
[17:47:59] <jdlrobson>	 bearND: any reason for just a +1 ?
[17:48:33] <bearND>	 jdlrobson: still waiting on the disambig patch to get ready for merging.
[17:48:37] <bearND>	 see my comments
[17:48:57] <bearND>	 looks like the other patches depend on it
[17:49:04] <bearND>	 at least in Gerrit
[17:49:33] <bearND>	 Yes, I love it that for most pages we don't put in a disambiguation: false
[17:49:37] <jdlrobson>	 bearND: oh interesting.. they dont need to
[17:49:42] <jdlrobson>	 but yeh we can wait
[17:49:49] <jdlrobson>	 just wondered if there was someone else i should be bugging :)
[17:49:55] <jdlrobson>	 i figured you were Mr MCS
[17:50:05] <jdlrobson>	 im really excited to use MCS for page previews
[17:50:07] <bearND>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/365191
[17:50:10] <jdlrobson>	 i think i already found a bug in the MCS
[17:50:26] <jdlrobson>	 the lead paragraph is not working for Spain for instance
[17:50:31] <bearND>	 shows that the disambig is in the chain of commits
[17:50:52] <jdlrobson>	 bearND: so is https://gerrit.wikimedia.org/r/#/c/366587/ still a -1?
[17:50:58] <bearND>	 uh, interesting. For any pages or just certain pages?
[17:54:32] <bearND>	 jdlrobson: yes, but just minor stuff. Should be easy to fix: I think  we could link this patch to T151241, the other issue is that the test description is a bit confusing. For right now that this is fresh it's ok but I'm concerned that in the future when it is not fresh in our minds that it would be a but confusing
[17:54:33] <stashbot>	 T151241: Surface disambiguation page flag in response - https://phabricator.wikimedia.org/T151241
[18:01:00] <jdlrobson>	 bearND: certain pages
[18:01:06] <jdlrobson>	 bearND: what are the fixes
[18:01:09] <jdlrobson>	 happy to do them now
[18:03:19] <bearND>	 jdlrobson: awesome. Once you get the fixes in, please file a bug report (tag with Mobile-Content-Service) for the Spanish lead paragraph issues. Would be great if you would share a list of example pages with the issue there.
[18:03:47] <jdlrobson>	 ohh saw minor nitpics
[18:03:58] <jdlrobson>	 bearND: yeh it's on my todo list - haven't investigated it further yet
[18:04:11] <jdlrobson>	 wanted to get refactors out way
[18:04:22] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/366587 < bearND should be updated now
[18:05:33] <bearND>	 :)
[18:32:17] <bearND>	 jdlrobson: the current batch of patches is merged, the other two outstanding patches have eslint issues. IT probably would be good to rebase them as well.
[21:24:13] <thedj>	 mobile maps now with markers :)