[08:46:19] maxbinder: spoileers [08:46:23] i'm watching tonight [11:54:01] hello all. [11:54:49] In case you were on this irc yesterday you might have seen the following statement I made, [11:55:08] "I recently tried to use the offline compilation feature of the android app (I know, it's not ready yet)" [11:55:33] I guess I have to take back the "it's not ready yet" part of it back. [11:56:59] https://phabricator.wikimedia.org/F8984585 [11:58:01] correction:- back the "it's not ready yet" part of it. ~~back~~ [12:43:22] mdholloway: ^^^ [12:43:28] Is this done intentionally? [14:49:30] mdholloway: any other changes before we re-deploy? [14:49:48] crashes are looking mighty fine. [14:51:28] dbrant: i think that should be it. yeah, crashes are looking good! i was going to take a quick peek at Matrix.setTranslate crash -- any ideas off the top of your head on that? nothing to hold up redeploying at any rate [14:52:04] (just as long as everything's feature-flagged that should be...) [14:53:32] no idea on that crash... looks like just 1 user, though. [14:54:01] redeploying... [14:54:25] 👍 [19:49:54] mdholloway:https://gerrit.wikimedia.org/r/#/c/370513/ (mcs tests are failing) [20:02:20] jdlrobson: :[ [20:02:22] looking... [20:24:00] dbrant: off the top of your head, do you know a quick way to find the wikidata entry for the enwiki main page? [20:25:25] dbrant: nm, found it [20:40:31] jdlrobson: updated https://gerrit.wikimedia.org/r/#/c/370513/ [20:40:54] jdlrobson: the action API isn't returning a description for Main Pages anymore; have you heard anything about a change? [21:38:19] mdholloway: the action API [21:38:20] ? [21:39:18] mdholloway: looks like wikidata description changed [21:39:22] that test is a bit dumb.. [21:39:23] https://www.wikidata.org/wiki/Q11439 [21:40:31] actually scrap that, lookng at wrong wikidata entry [21:41:31] jdlrobson: yes. the lead section info that was causing the additional tests to fail was coming from https://github.com/wikimedia/mediawiki-services-mobileapps/blob/master/lib/mwapi.js#L157-L245 for title Main_Page [21:42:14] jdlrobson: i think the wikidata entry here is https://www.wikidata.org/wiki/Q5296 [21:42:21] mdholloway: seems to only fail on gate-and-submit [21:43:23] it still has a description, but the action API isn't returning it for some reason: https://en.wikipedia.org/w/api.php?action=query&format=json&formatversion=2&prop=pageterms&wbptterms=description&titles=Main_Page [21:43:35] mdholloway: that's intentional [21:43:55] oh wait ignore [21:43:58] this is about redirects [21:44:34] i know how to fix.. not sure how that crept in [21:46:41] mdholloway: okay not redirects.. let me raise a bug against wikidata and see what they say. This is strange behaviour [21:49:52] mdholloway: it's not necessarily a regression in wikidata though - we changed how we sourced Wikidata descriptionss [21:50:01] i've raised https://phabricator.wikimedia.org/T172829 to see what's going on [21:50:32] jdlrobson: i was wondering about that. couldn't recall the change though [21:50:55] Aren't Wikidata having label problems atm? [21:51:21] was that one of the bits previously from mobileview that was moved? [21:51:37] Reedy: hmm, hadn't heard about that, but sounds like a likely culprit if so [21:52:13] mdholloway: yep previously all metadata came from mobileview API it's now coming from elsewhere [21:52:21] but Reedy if they're having problems - yes that could be related [21:52:33] Just trying to find the task [21:52:41] https://phabricator.wikimedia.org/T172829 [21:52:47] Oh, that's yours [21:52:48] ffs [21:52:53] lol [21:52:59] Still works for main page though - https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=Main+page&prop=text%7Csections%7Cnormalizedtitle%7Cdescription [21:53:36] https://phabricator.wikimedia.org/T172776 [21:53:52] "Property labels missing on some items [21:53:52] " [21:56:07] shows up here though - https://www.wikidata.org/wiki/Q5296 [21:56:13] hmm.. we'll see what they say