[17:59:07] CoolteyFeng: sharvani: hey, one thing i forgot to mention about gerrit [17:59:26] ok [17:59:29] it's possible to edit patch sets in the Gerrit UI, but i don't know anyone who actually does that [17:59:37] it's not intuitive [17:59:55] instead we just pull patch sets with git and push them with git-review [17:59:58] that's all! [18:00:11] cool! [18:00:37] got it, will try to understand that :D [18:01:02] it's a bit of a learning curve but not so bad after you get used to it ;) [18:57:34] mholloway, hi [18:58:31] mdholloway, hi [18:58:52] lbertolotti: hello [18:59:02] https://phabricator.wikimedia.org/T153980 [18:59:15] have you generated this https://en.wikipedia.org/w/api.php?action=mobileview&format=json&formatversion=2&prop=text%7Csections%7Clanguagecount%7Cthumb%7Cimage%7Cid%7Cnamespace%7Crevision%7Cdescription%7Clastmodified%7Cnormalizedtitle%7Cdisplaytitle%7Cprotection%7Ceditable&onlyrequestedsections=1§ions=0§ionprop=toclevel%7Cline%7Canchor&noheadings=true&page=Category:Engineering_disciplines&thumbsize=640 [18:59:18] lbertolotti: just to warn you, i have a meeting starting in one minute [18:59:20] using javascript? [19:01:28] lbertolotti: the short answer is that this is something that should be happening on the server side, in or around parsoid, to achieve parity with mediawiki output. i'm not sure what the status of that is just now. [19:01:32] will look more after my meeting... [19:04:07] testing [19:04:33] mdholloway, i'm here [19:47:01] hello [19:47:17] hello [19:48:00] hello [19:57:09] lbertolotti: I'm not sure I understand the question. But what I can say is that MCS doesn't yet fully support File and Category pages. This is something we're going to work on as part of the Page Content Service project. [21:18:02] dr0ptp4kt: who is the budget owner for Tilman and Chris at the Web offsite? You or JK? [21:23:09] thedj: around? [21:32:01] maxbinder: jk for tilman. toby for chris [21:36:23] I'm back [21:37:20] mdholloway, so that json output is generated by mobileview and not parsoid [21:37:38] but what is it? javascript, html? [21:38:35] lbertolotti: yes, the JSON response you linked is from the MediaWiki API [21:39:10] i'm actually looking at MobileFrontend right now to see what's going on [21:39:31] so it's just a json object [21:39:53] but mobileview transforms that into something so we can view it, right? [21:42:03] lbertolotti: yes, the app pieces together and displays the HTML from the sections in mobileview.sections (in this case only one) [21:43:11] ok, so you thing the problem is the app level? [21:43:19] *at app level [21:43:29] the problem is definitely at the API level [21:43:41] not at the app level; the app simply displays the content it's provided [21:44:15] ok, you mean the problem is here https://www.mediawiki.org/wiki/API:Main_page [21:44:23] and not here https://www.mediawiki.org/wiki/Extension:MobileFrontend#action.3Dmobileview [21:45:10] lbertolotti: i think https://www.mediawiki.org/wiki/Extension:MobileFrontend#action.3Dmobileview is more correct [21:45:16] that's the specific API module in question [21:46:05] ok so the bug is in parsing wikitext into html or generating the json object? [21:46:07] i am looking at the code and it looks like file pages get some special-casing and that's why they look correct in the app [21:46:35] other pages outside mainspace don't get that special-casing, and don't display all of the content one would expect [21:47:26] lbertolotti: i think the problem is in getting the full HTML, not with generating the JSON object [21:50:38] mdholloway, hum but what about this one https://en.wikipedia.org/w/api.php?action=mobileview&format=json&prop=text%7Csections&onlyrequestedsections=1§ions=1-§ionprop=toclevel%7Cline%7Canchor&noheadings=true&page=Category:Engineering_disciplines [21:50:40] ? [21:54:05] wasn't there supposed to be a non-empty json object there? [21:54:11] lbertolotti: i believe that's expected given the underlying HTML that is being parsed in ApiMobileView. it looks like the issue is that the API module isn't getting all of the HTML it needs to completely render the page. [21:54:51] lbertolotti: i can update the task and ping somebody more knowledgable in that area :) [21:55:18] have you looked here https://www.mediawiki.org/wiki/Special:ApiSandbox#action=mobileview&page=Extension:MobileFrontend/Example§ions=0&prop=text%7C [21:55:18] ? [22:05:12] i'm familiar with the Api sandbox [22:05:17] i updated the task [22:06:16] i have to run now. hopefully that gives us a possible path forward