[13:37:26] mhurd: o/ in the interest of keeping each other unblocked, i just wanted to verify that you are still 1) pushing changes to your sports uniform theming PR 2) reviewing both my footer PRs 3) and not blocked on me for anything else. i've tried to split the footer PRs so they're hopefully easily digestable and quick merges. it'd be really helpful if you're able to tend to these by the weekend so i'll have time to [13:37:28] continue the footer work without lots of tricky conflict resolution. [15:38:43] cormacparle: able to meet for 20 mins? i realized i didn't add you to the intended sync meeting on my calendar today :P [15:44:37] dr0ptp4kt: just finished a meeting with marktraceur [15:44:42] ok to talk now sure [15:45:13] cool, i'll ghangoutcall you in a few seconds cormacparle [16:55:18] thedj: https://phabricator.wikimedia.org/T172501 can you verify? I can resolve if looks good to you [17:19:54] niedzielski: yes jumping back on pagelib first thing today. had to wrap some endpoint bits yesterday :) [17:33:21] \o/ thanks mhurd! [17:42:53] hello all. hope you're having a great day! [17:44:28] I thought I could share a few things about the offline compilations feature of the android app [17:46:37] Firstly, let me tell about the redundant download issue. I was able to download a compilation *twice*. This happens when I tap the "Download" button on a compilation description page twice in succession. [17:47:14] I was able to do that because it took some time for the download to start and I thought I didn't tap the button at all. [17:48:14] I guess this is an issue to be considered. [17:51:44] That's because the user in general wouldn't expect that to happen. [17:55:22] kaartic: reets ^ [18:08:05] niedzielski: i reviewed and merged one of your page lib PRs. when you have a minute, I had one comment on the other one https://github.com/wikimedia/wikimedia-page-library/pull/85#issuecomment-323819958 [18:08:50] mhurd: thanks!! i'll try to follow-up after work [18:09:28] niedzielski: sweet thx! i'm gonna jump back on my theming pr based on your feedback from the other day [18:09:49] niedzielski: so hopeful that will be ready by then as well [18:09:59] mhurd: great! i'll follow up on that too! [18:10:08] niedzielski: woohoo! [18:12:24] nzr: the last activity doesn't seem promising. So, pinging dbrant mdholloway [18:17:01] kaartic: will crosspost your feedback to reets and discuss [18:20:16] nzr: thanks. While dicussing could you see if you could discuss about the another issue that I state below? [18:21:06] Currently the app seems to show a toast each time a page is loaded from an offline compilation. This seems to be disturbing. [18:22:14] kaartic: Definitely, will add it to the list [18:22:17] I guess a better alterantive would be use different themes to identify the pages loaded from compilations and those loaded from other sources (online, reading list, cache etc.) [18:22:18] Thanks for the feedback [18:22:49] The different themes would possibly distinguish them better. [18:22:57] bearND: ping. Is the mobile-sections used in the app for enything except the *.wikipedia.org? For commons maybe? [18:22:58] nzr: You're welcome [18:34:18] hi kaartic: thanks for taking a look. re your first piece of feedback whereby you're able to download a compilation twice - that would be a bug, though I'm unable to replicate in the latest version of teh Alpha [18:36:07] reets: I guess you can't reproduce it on a highly *responsive* device. It need a little network delay, I think. [18:43:49] kaartic: secondly regarding the toast appearing each time an offline article is loaded, it is *expected* behavior so that users are aware they are pulling from the offline pack, similar to when we pull an article saved from a reading list when not connected to internet, so that readers are reminded that the version of the article may not be up to date. This is only the first prototype, so we may consider [18:43:49] other ways to indicate to users when they are reading from an offline pack (esp. pending feedback from user research) but currently is intended that reading an article from an offline compilation should be as close as possible to the reading experience whilst online. [18:47:15] reets: It's ok to keep them aware but if that user is a person who reads offline pages more than online ones he might find the notification redundant and might find it to be disturbing their reading experience. [18:48:50] I guess it would be better to visually ditinguish this using different themings for contents shown from a compilation and for contents shown from wikipedia [18:50:41] More information about the page from the compilation could be hidden behind an option of some kind shown in the overflow menu. [18:51:21] He could be made aware of it by an on boarding pop shown when he loads a first page from a compilation [18:53:20] Pchelolo: no, the app uses the mobile-sections endpoints only for WP at this time. (It uses the definitions endpoint for Wiktionary data). Why are you asking? [18:53:52] bearND: we wanna stop rerendering for all the other projects and remove the endpoints [18:55:55] Pchelolo: OK for the current stuff. I thought we already did that. The next generation endpoints will be more generic since we want the web to also use them. But we'll cross that bridge when we get there. [18:57:01] yup, as we get there we can reenable it, right now we're just tryinng to cut off everything extra because we need to decrease cluster load for cassandra upgrade [18:58:23] have a great day everyone. see you later! [19:00:21] kaartic: at this point in time we don't want to change the visual theme for articles from compilations, but let's see feedback from some more users. In the meantime we can try to shorten the toast duration and have it dismiss as soon as the user scrolls or navigates away so that it is less disturbing for power offline readers [20:37:44] bearND: FYI we're gonna truncate all the stored mobile-sections. That will slightly increase the latency for a little while for the app [20:57:34] thanks for letting me know. When is this going to happen? //cc: dbrant mdholloway [20:57:47] Pchelolo: ^ [20:58:17] define "slightly" ;) [20:58:40] bearND: now-ish [20:59:09] dbrant: the popular articles will still be served from Varnish, so mostly likely it will be unnoticeable [20:59:29] ok cool [21:00:14] but for less popular article the first view might be slower [21:00:40] s/might/will