[18:50:54] mdholloway: jdlrobson: Would one of you review (and hopefully merge) the series of patches except the one I -1'd in https://gerrit.wikimedia.org/r/#/q/topic:html-route4+(status:open)? [18:54:31] bearND: sure, will look in a bit [18:56:33] mdholloway: awesome. TY! [19:32:15] HaeB: ping. A/b test is running [19:32:26] are you seeing data coming in? I still dont have access to the db [19:33:37] \o/ it seems so https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?var-schema=Popups&refresh=5m&orgId=1 [19:36:09] HaeB: and the buckets? e.g. is popupEnabled disabled for 50% of pageLoaded events? [19:44:01] why is the event rate so low? looks it's not climbing any longer, and is still below 100/min [19:44:27] what was sam's last estimate for the expected rate? [19:50:12] bucketing: too early to tell, but so far not totally out of whack: [19:50:41] https://www.irccloud.com/pastebin/bojH3jQb/ [20:12:28] mdholloway: are we all good for user testing, then? [20:13:06] dbrant: i believe so! [20:13:14] and any objection to beta? [20:13:18] none! [20:38:13] bearND: can you review https://gerrit.wikimedia.org/r/#/c/366585 ? Forgot to mention that last time, but it's a trivial patch [21:03:15] tgr: ok [21:03:28] mdholloway: https://gerrit.wikimedia.org/r/#/c/374413/ [21:05:54] ty [21:07:46] yw! [21:19:46] mdholloway dbrant when I tested the audio on articles, I found that my phone does not play audios. [21:20:07] CoolteyFeng: what specific article are you looking at? [21:20:28] i check the US article. United State [21:20:52] trying to play the March [21:23:46] hmm, you're quite right; that file is not playing correctly... [21:23:53] +1 same here [21:24:14] it looks like that audio element is getting transformed into a "video" element [21:24:20] I feel like we've seen this issue before [21:25:19] dbrant: it's the same with mw api mobileview html, btw [21:25:31] same effect anyway, i haven't actually looked at the html yet [21:26:18] I see. [21:27:15] CoolteyFeng: dbrant: i guess the first order of business here is to find a working audio file for you to test with. the page title pronunciation files seem to work but those are far too short for what you're doing [21:27:27] try [[Radiohead]] [21:28:48] ok! got it. Radiohead works [21:29:45] Thanks dbrant mdholloway. [22:46:51] sharvani: cooltey: there's a really high-priority issue that I think I might have fixed: https://gerrit.wikimedia.org/r/374433 [22:47:12] would you mind testing whether this fixes the issue (based on the task description), and merge the patch if it does? [22:48:05] Sure. I dont think we still have +2 rights .. [22:51:56] oh, do you not? then just let me know if the fix works, and i'll self merge [22:52:23] (it works for me, but i'd like a sample greater than one) [22:54:26] sure.... testing now... [22:56:11] sure, will do it! (and I dont have +2 either) [23:07:45] mdholloway dbrant git review -d 374433 isnt that the way to pull changes? it is giving me an error... [23:08:50] sharvani: the Gerrit web interface gives you a convenient "download" link at the top right, to checkout the patch. [23:10:13] ok ... will do that ... [23:16:28] dbrant I test it, it looks great now. [23:17:50] I taped quickly and it loads the page correctly. [23:18:14] dbrant: I tested it and it looks good, but i couldnt reproduce the bug without the patch. cooltey: could you? [23:19:15] thanks, both! [23:19:27] I can reproduce the bug without the patch. You can try to tap the article and back immediately and tap again. [23:19:59] try couple times and it will happen. [23:20:49] ok cool ...