[00:59:22] hi [01:00:02] jdlrobson, are you busy? [01:12:08] gwicke, are you busy now? [13:20:24] jdlrobson, are you busy now? [13:24:04] gwicke, are you busy now? [13:54:46] hi [14:11:30] lbertolotti: jdlrobson has intermittent availability today and might not be checking irc [14:11:32] :) [14:11:42] ok [14:11:48] https://phabricator.wikimedia.org/T153980 [14:12:18] so, he set-up this https://trending.wmflabs.org/wiki/Special:Categories [14:14:16] the task is to make this https://en.m.wikipedia.org/w/index.php?title=Category:Engineering_disciplines&mobileaction=toggle_view_mobile [14:14:30] display in the wikipedia app [14:20:16] lbertolotti: ok, i see that there's been investigation into T153980 [14:20:16] T153980: Subcategories are not shown on Category pages in the Android app - https://phabricator.wikimedia.org/T153980 [14:20:34] and there's ongoing discussion about how to get the content for the page [14:23:42] the point is: the wikipedia app uses mediawiki-extensions-MobileFrontend? [14:26:18] lbertolotti: It doesn't, really. It technically uses Parsoid to get the page content, and it's Parsoid that doesn't yet render Category pages correctly. [14:26:30] ok [14:26:48] so can Parsoid use https://trending.wmflabs.org/wiki/Special:Categories ? [14:27:20] I don't believe so [14:28:18] sharvani: up for a minute of pair programming? [14:28:34] help [14:29:54] dbrant: will ping you in fifteen? [14:30:04] sharvani: sure [14:30:14] thanks..brb [14:30:19] lbertolotti: category pages are not yet supported in the apps. [14:31:24] yeah ok, but what about parsoid? [14:31:37] right, that's the reason they're not supported. [14:31:48] it needs to be fixed at the Parsoid level. [14:33:58] dbrant, ok so I will take this issue to the parsoid channel [14:36:07] for discussion, see https://phabricator.wikimedia.org/T151223 [14:54:22] dbrant: ready.. [14:54:30] hangout? [14:54:41] sharvani: yep, i'll call [14:56:12] ok [15:46:09] lbertolotti: i would suggest you use the MediaWiki API - https://en.m.wikipedia.org/wiki/SPecial:ApiSandbox to render categories. [15:47:01] lbertolotti: a read through https://github.com/jdlrobson/weekipedia/blob/master/libs/server/endpoints/categories.js will give you an idea of which apis to use. [17:00:36] dbrant: you were right. XML way not working on 24 and 25 [17:01:24] sharvani: cool; then dynamically seems like the best option [17:01:40] yes... agree [17:30:33] dbrant: dynamic changes worked and I have tested against 18,22,24 and 25. Do you think I should test on more devices? [17:30:52] sharvani: that's probably a good enough sample [17:32:40] cool... and thanks for teaching the 'Updating patch ' stuff... worked well with Atlassin as well [17:37:15] dbrant a question about this task: https://phabricator.wikimedia.org/T154034, how do I use the testwiki? [17:39:24] cooltey: go to the Search bar in the app, and tap the language picker button. At the bottom of the list is a language called "Test". If you select this, the app will use testwiki. [17:40:16] oh, wasn't noticed that! Thank you! [18:12:57] dbrant: on audio files in video tags: T167183 [18:12:58] T167183: Audio elements are unplayable. - https://phabricator.wikimedia.org/T167183 [18:14:51] also, T164520 [18:14:51] T164520: Audio files fail to play on some devices - https://phabricator.wikimedia.org/T164520 [18:15:55] i should note that it's not hopeless to identify audio files; they're wrapped in a span with typeof="mw:Audio" [18:16:33] (though this typeof element is apparently stripped in the content service :{) [18:17:33] if there are specific examples of issues specifically related to markup (as opposed to, say, incorrect client-side handling or a file format android doesn't handle), it would be good to start a new ticket to capture them [18:18:04] ^ s/element/attribute [18:19:39] there's also this outstanding for pagelib: T165071 [18:19:41] T165071: Add support for clicking videos - https://phabricator.wikimedia.org/T165071 [19:24:46] bearND, hi [19:24:58] lbertolotti: hi [19:25:16] https://phabricator.wikimedia.org/T153980 [19:25:37] you suggested using mobileview in the android app [19:25:42] is this feasible? [19:28:37] bearND, I mean this https://en.m.wikipedia.org/w/index.php?title=Category:Engineering_disciplines&mobileaction=toggle_view_mobile [19:28:45] is working [19:31:14] brb [19:35:41] lbertolotti: Hmm, I was thinking that this would be a similar case a File: pages. When I just tried the page you mentioned it doesn't seem to fill in the subcategories: [19:35:41] https://en.wikipedia.org/w/api.php?action=mobileview&format=json&formatversion=2&prop=text%7Csections%7Clanguagecount%7Cthumb%7Cimage%7Cid%7Cnamespace%7Crevision%7Cdescription%7Clastmodified%7Cnormalizedtitle%7Cdisplaytitle%7Cprotection%7Ceditable&onlyrequestedsections=1§ions=all§ionprop=toclevel%7Cline%7Canchor&noheadings=true&page=Category:Engineering_disciplines&thumbsize=640. [19:38:13] ok, first of all [19:38:20] bearND, what is MCS? [19:39:15] lbertolotti: MCS = Mobile Content Service, it's a Node services which provide page content to the Android app and data for the Explore feed for both apps [19:39:48] It uses Parsoid HTML with some DOM transformations to reduce payload sizes [19:39:55] ah, ok [19:40:08] what about mediawiki api? [19:40:10] plus other changes that the app clients would have to do on the client side otherwise [19:40:44] MW API is the regular PHP action API [19:41:00] yes, but does the android app use it to render pages? [19:41:15] e.g. action=query or action=mobileview [19:42:17] The Android app uses MCS by default for most pages, except for File: and Special: pages. That's where my idea came from to add a case for Category: pages to use action=mobileview, too. [19:42:27] ok [19:42:33] now something about parsoid [19:42:46] https://www.mediawiki.org/wiki/Parsoid/Setup#Windows [19:43:55] C:\>npm Usage: npm where is one of: access, adduser, bin, bugs, c, cache, completion, config, ddp, dedupe, deprecate, dist-tag, docs, doctor, edit, explore, get, help, help-search, i, init, install, install-test, it, link, list, ln, login, logout, ls, outdated, owner, pack, ping, prefix, prune, publish, rb, rebuild, repo, restart, root, run, run-script, s, se, search, [19:44:07] npm@5.3.0 C:\Users\lucao\AppData\Roaming\npm\node_modules\npm [19:44:26] now this command [19:44:27] npm -g install npm@latest [19:45:19] first of all windows build tools [19:45:29] *wants windows build tools [19:45:55] 2015 maybe [19:47:40] I mean does it really matter what version I am using of build tools? [19:49:02] Hmm, I don't use Windows. I don't really know. Have you tried skipping that? Usually if you have a recent installation of Node.js then it comes with a recent version of NPM. Again, not sure about windows build tools [19:49:29] yeah, the point is I have no C:\Users\USERNAME\AppData\Roaming\npm\node_modules\parsoid [19:49:57] As a developer I would use the https://www.mediawiki.org/wiki/Parsoid/Developer_Setup [19:50:35] clone the repo, update config files, npm install, npm start [19:51:19] join #wikimedia-parsoid [19:52:39] join #mediawiki-parsoid [19:52:48] lbertolotti: I'm already there [20:39:40] tgr: https://gerrit.wikimedia.org/r/#/c/362442, https://gerrit.wikimedia.org/r/#/c/369428, and https://gerrit.wikimedia.org/r/#/c/370295 should be ready [22:02:18] bearND: uh, sorry, got distracted yesterday. Will merge today for reals.