[00:50:02] <lbertolotti>	 hi
[00:50:08] <lbertolotti>	 https://www.mediawiki.org/wiki/Parsoid/Setup#Windows
[00:50:21] <lbertolotti>	 I have 3 server.js files
[00:50:29] <lbertolotti>	 but none are C:\Users\USERNAME\AppData\Roaming\npm\node_modules\parsoid\bin
[00:50:46] <lbertolotti>	 *in
[00:54:14] <lbertolotti>	 anyone?
[00:56:36] <Reedy>	 You did replace USERNAME?
[01:02:12] <lbertolotti>	 Reedy, yes
[01:02:56] <lbertolotti>	 if I try to run server.js 
[01:02:58] <lbertolotti>	 I get
[01:03:00] <lbertolotti>	 Error while reading config file: Error: ENOENT: no such file or directory, open 'C:\Users\lucao\node_modules\parsoid\bin\config.yaml'
[01:04:30] <lbertolotti>	 that is a bit weird, in the setup it says
[01:04:31] <lbertolotti>	 For Windows OS you need to use the localsettings.js instead of the .yaml file!
[01:05:18] <lbertolotti>	 which is another problem
[01:05:29] <lbertolotti>	 since there's no localsettings.js file at all
[01:06:41] <Reedy>	 "Then, when everything is done well, copy the localsettings.js.example file to localsettings.js and the config.example.yaml file to config.yaml. Edit following line in those files:"
[01:06:50] <Reedy>	 https://www.mediawiki.org/wiki/Parsoid/Developer_Setup#Windows_Server_2008_R2
[01:07:02] <Reedy>	 I think that's vaguely what I followed in Vienna to try and help someone run it on windows
[01:08:20] <lbertolotti>	 yeah, well I'm running win10 not windows server 2008
[01:08:42] <lbertolotti>	 npm install parsoid npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue npm WARN deprecated node-uuid@1.4.7: Use uuid module instead npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead. 
[01:08:55] <lbertolotti>	 is this standard install?
[01:09:11] <Reedy>	 It doesn't really matter
[01:09:17] <Reedy>	 (2008 vs 10)
[01:10:16] <lbertolotti>	 well, so you think I should use git then
[01:10:31] <lbertolotti>	 ?
[01:10:35] <Reedy>	 I'm not sure what that's got to do with anything
[01:10:41] <Reedy>	 How else are you getting the parsoid files?
[01:11:03] <lbertolotti>	 npm install parsoid
[01:11:22] <Reedy>	 sounds scary
[01:11:58] <Reedy>	 I hate that, as usual, we've got multiple distinct setup guides
[01:12:32] <Reedy>	 also, npm is scary
[01:13:27] <lbertolotti>	 well let's use git then
[01:15:47] <lbertolotti>	 what ..\npm install is supposed to mean?
[01:16:54] <Reedy>	 that sounds like it's trying to use an npm binary from the parent directory of wherever you've git cloned parsoid to
[01:17:04] <Reedy>	 "If ..\npm install fails due to npm being an unknown command, try to add the nodesjs\ folder to the PATH, as explained earlier in the Install prerequisite software section, and run npm install (without ..\) directly from the parsoid folder created byt the git clone command."
[01:17:10] <Reedy>	 That... Is horrible instructions
[01:17:13] <Reedy>	 *Those are
[01:17:32] <lbertolotti>	 lol
[01:17:49] <lbertolotti>	 maybe It's about time to correct it then?
[01:19:18] <Reedy>	 https://www.mediawiki.org/w/index.php?title=Parsoid%2FDeveloper_Setup&type=revision&diff=2546428&oldid=2511568
[01:20:44] <Reedy>	 https://static-bugzilla.wikimedia.org/1
[01:20:44] <Reedy>	 ;)
[01:22:39] <lbertolotti>	 Reedy, what does  copy the localsettings.js.example file to localsettings.js and the config.example.yaml file to config.yaml even mean?
[01:23:03] <lbertolotti>	 does it mean I need to create a new localsettings.js in the same folder?
[01:23:33] <Reedy>	 It means create a copy of both of those files
[01:24:43] <lbertolotti>	 yeah create where? in the folder they are stored?
[01:27:01] <Reedy>	 yeah, in the same folders
[01:35:33] <lbertolotti>	 reedy, I'm waiting node bin\server.js to complete the level:40 step
[01:35:38] <lbertolotti>	 is this standard?
[01:36:29] <lbertolotti>	 it says startup finished but nothing happnes
[01:41:10] <Reedy>	 I think that is normal
[01:41:54] <lbertolotti>	 reedy, I'm still waiting
[01:42:07] <Reedy>	 I don't think it's going to print anything else to the console
[01:42:30] <lbertolotti>	 yeah well I'm getting a flashing _
[01:43:34] <Reedy>	 I would suggest testing it, and seeing if parsoid respond on the correct ports in your web browser
[01:46:38] <lbertolotti>	 "C:\Program Files (x86)\nodejs\node.exe" C:\parsoid_install_dir\bin\server.js
[01:46:45] <lbertolotti>	 The system cannot find the path specified.
[01:47:12] <lbertolotti>	 I'm going to run that with node
[01:48:23] <lbertolotti>	 well, there's no parsoid_install_dir
[01:49:06] <lbertolotti>	 so... there's something wrong
[01:49:26] <lbertolotti>	 node bin\server.js is going all again to the same procedure
[01:53:48] <lbertolotti>	 reedy, so how I solve this?
[01:59:53] <lbertolotti>	 Reedy, is this a problem with the javascript?
[02:00:12] <lbertolotti>	 #!/usr/bin/env node  "use strict";  var ServiceRunner = require('service-runner'); new ServiceRunner().start();
[02:21:28] <lbertolotti>	 Reedy, I check if this is related node.js, but it isn't
[15:21:59] <mdholloway>	 dbrant: when i cd to www and run grunt, there's a pretty extensive body of changes made
[15:22:04] <mdholloway>	 that... shouldn't be the case
[15:22:06] <mdholloway>	 :(
[15:23:26] <dbrant>	 mdholloway: not sure i'm seeing that...
[15:23:33] <dbrant>	 is your page-library up to date?
[15:23:41] <mdholloway>	 was just about to npm install and double-check
[15:24:26] <mdholloway>	 nope!
[15:24:34] <mdholloway>	 <facepalm>
[15:24:42] <dbrant>	 :]
[15:40:39] <mdholloway>	 dbrant: speaking of pagelib, i'm not sure whether we're ideally supposed to keep it at the cutting edge or treat it like any other library and be a little conservative about it
[15:40:47] <mdholloway>	 it's now at 4.5.10 and we have 4.5.0
[16:17:46] <niedzielski>	 mdholloway: there have been a ton of fixes, especially to theming (i added you to a couple patches). we keep a nice and up-to-date summary of changes in each version for clients here: https://github.com/wikimedia/wikimedia-page-library/blob/master/changelog.md#v4510
[16:19:54] <mdholloway>	 niedzielski: thanks.  are you still involved with pagelib development?  we had some discussion in retro the other day about who owns and should be involved with pagelib going forward but didn't come up with many answers
[16:20:02] <mdholloway>	 when i think pagelib, i think of you and mhurd :)
[16:21:13] <niedzielski>	 mdholloway: only in volunteer time which right now just means reviewing mhurd patches and inching along on footer stuff
[16:21:44] <mhurd>	 mdholloway: i'm still on it :)
[16:21:59] <niedzielski>	 cc mhurd: i pushed a couple changes to the footer pr and polyfill patch over the weekend. please review when you can!
[16:22:27] <mhurd>	 niedzielski: i was just typing that i would try to review that today :)
[16:22:53] <niedzielski>	 mhurd: thanks!
[16:24:11] <mhurd>	 niedzielski: np! if i have time tomorrow i may try to resuscitate the naming pr too
[16:25:56] <niedzielski>	 mhurd: that would be pretty cool. the bobbing back-And_forth between CSS class naming conventions has been irking me :]
[16:27:25] <mhurd>	 niedzielski: haha same!
[16:29:08] <dbrant>	 mdholloway: thanks for the PR to zimdroid!  I just realized, though, that it might be even better if the getZimDate() function returns an actual (NonNull) Date instead of String. And this would let us guarantee a NonNull Compilation.date() as well.
[16:29:22] <dbrant>	 (I can make that change...)
[16:29:35] <mdholloway>	 👍
[16:29:44] <mdholloway>	 (sorry for tersness, in a meeting)
[16:29:48] <mdholloway>	 *terseness
[16:29:50] <dbrant>	 np!
[16:52:58] <cooltey>	 mdholloway dbrant  when I check this task: https://phabricator.wikimedia.org/T154034, I found something weird :S
[16:54:15] <cooltey>	 when using "test" to search foo in API 16, the text doesn't display on the screen. But it actually displays text in other language like this: అక్షర దోషం స్థిరం
[16:55:58] <cooltey>	 when I used my device which is Android 7.1, the "test" did display these summary tags in English. But, when I switch to other wikipedia language, (e.g. Chinese) , summary tags still display in English
[16:58:02] <cooltey>	 In API 16, different wikipedia language displays different summary tags, but in Android 7.1 only display English. Is that normal? 
[17:13:45] <dbrant>	 cooltey: how about a quick hangout on this subject?
[17:15:44] <cooltey>	 sure!
[17:16:31] <cooltey>	 dbrant should I call you?
[17:16:40] <dbrant>	 yep, go ahead
[17:18:27] <cooltey>	 one second, my chrome really slow at this time.
[17:18:50] <dbrant>	 mine, too
[17:21:26] <dbrant>	 cooltey: looks like hangouts is down... we'll try later
[17:21:39] <cooltey>	 other website is fine, only google 
[17:21:46] <cooltey>	 yes
[18:16:56] <dbrant>	 mhurd: is the "footer" functionality from page-library already integrated on iOS?
[18:17:09] <mhurd>	 dbrant: ya
[18:17:42] <dbrant>	 mhurd: mind walking me through what's necessary to do it? (hangout, perhaps?)
[18:18:24] <mhurd>	 dbrant: for sure! i'm taking the afternoon off today but feel free to throw a calendar invite my way for tomorrow or monday
[18:18:51] <dbrant>	 mhurd: gotcha, will do!
[18:23:38] <niedzielski>	 dbrant: /cc mhurd if you're planning on owning the android integration, please let me know so i don't continue to work on it
[18:28:58] <mhurd>	 niedzielski: oh heads-up i left a quick note on your save button pr
[18:30:00] <niedzielski>	 mhurd: thanks! i'll try to check it tonight or this weekend (unless i hear back that android will be working on the footer stuff :])
[18:32:25] <dbrant>	 niedzielski: if you're working on it, that's great! Do you have a time frame for completing it?
[18:35:08] <dbrant>	 also, I was just thinking: should we have a long-term goal of completely unifying the whole "www" directory between the two platforms?
[18:40:47] <niedzielski>	 dbrant: i don't really have a timeframe in mind other than "soon." maybe some time in the latter half of september. i just work on it afterhours. it was pretty close but there was some last minute churn and attempt to unify more stuff in the page library rather than outside of it. you can now actually do most iteration within the page library itself which helps a ton and i'm trying to finish the new read more
[18:40:48] <niedzielski>	 and footer design before reviving the integration itself
[18:41:05] <niedzielski>	 the page library is more or less the goal of unifying www/ directories between projects and there should be a task for each feature on the workboard
[19:53:37] <thedj>	 anyone around who knows a bit about the MCS feeds ?
[19:54:00] <thedj>	 for tfa etc ?
[19:55:27] <thedj>	 there is some activity recently on converting the layout of some of that stuff to take out the html tables etc. wanna make sure i can identify changes that might break those feeds.
[20:08:36] <mdholloway>	 thedj: hi there.  bearND and i would be the people to talk to about that.  (though it's been a little while since i've touched that code, so i might need to look back at the source...)
[20:08:55] <mdholloway>	 what's the proposed change?
[20:09:26] <bearND>	 thedj: are you talking about tfa on enwiki or nlwiki?
[20:11:42] <thedj>	 enwiki
[20:11:59] <thedj>	 so some people are now cleaning up Portal:Current events
[20:12:16] <thedj>	 and we recently did a few changes to the main page (which seems like it wasn't a problem at least).
[20:13:10] <thedj>	 with that momentum finally there, i expect some more changes, so it would be good to know what the scraper is looking for
[20:13:40] <thedj>	 i couldn't find the code however
[20:16:56] <mdholloway>	 thedj: the primary logic for the various endpoints lives in mediawiki-services-mobileapps/lib/feed
[20:17:03] <mdholloway>	 https://github.com/wikimedia/mediawiki-services-mobileapps/tree/master/lib/feed
[20:17:52] <mdholloway>	 probably the most relevant here are featured.js (for 'today's featured article'), news.js (for 'in the news'), and on-this-day.languages.js (for 'on this day')
[20:18:09] <mdholloway>	 i don't believe we have any logic that relies specifically on the current events portal
[20:18:22] <mdholloway>	 (bearND/mhurd is this correct?)
[20:19:54] <mdholloway>	 featured-image.js deals with commons, most-read.js with the Analytics Query Service, and random.js with the MediaWiki API, so i'm not at all worried about those
[20:23:39] <bearND>	 mdholloway: thedj : yes, that's the right file. Mainly this is using the FeaturedFeed extension under the covers.
[20:23:57] <mhurd>	 mdholloway: thedj: in regards to the onthisday endpoint, it only looks at day pages i.e. "July_1" and anniversary pages
[20:24:03] <bearND>	 I mean featured.js
[20:24:32] <bearND>	 for tfa
[20:24:34] <thedj>	 ah FeaturedFeed seems to be the real magic indeed
[20:24:53] <bearND>	 Yep ;)
[20:26:06] <bearND>	 thedj: We used to have specific parsing code in this file, but that was only for enwiki. Now with the extension we can support more languages (as long as the FeaturedFeed extension works)
[20:27:23] <bearND>	 which really means the wiki admins create the right pages in the MediaWiki namespace with the correct template invocations.
[20:27:59] <thedj>	 ah
[20:28:00] <thedj>	 const found = scope.querySelector('b > a, a > b');
[20:28:58] <bearND>	 More info also at T150806 
[20:28:58] <stashbot>	 T150806: Featured articles should support more languages - https://phabricator.wikimedia.org/T150806
[20:29:07] <thedj>	 right, so for title, we rely on the first link being bold :)
[20:29:30] <bearND>	 thedj: Yes, it's looking for the first bold anchor for the title of the TFA.
[20:30:12] <bearND>	 It uses the trick of useskin=apioutput to avoid dealing with the chrome of the page
[20:30:23] <bearND>	 = just get the content
[20:31:22] <thedj>	 ah, and then it uses the pages summary/TextExtract to retrieve the content (in this case)
[20:31:47] <thedj>	 which basically makes sure u strip it of most html tags.
[20:32:40] <thedj>	 k, good to know. i'll keep an eye out for things that might break.
[20:38:42] <thedj>	 btw. today there was some vandalism in main page related articles, that caused penis pics to show up in the app.
[20:38:48] <thedj>	 see WP:VP/T
[20:39:28] <thedj>	 i suspect that with all these layers, we have a bit of a caching hell :)
[20:41:10] <bearND>	 thedj: Thanks for looking out for that. I don't see the vandalism in the app anymore. This stuff should be only cached for 5 minutes.
[20:44:10] <thedj>	 bearND: yeah, but we have original -> textextract and pageimage selection -> tfa subpage -> MediaWiki transaclusion -> api output -> MCS -> restbase -> app caching -> article + pageimage retrieval -> display. If those all are actively expunged i would be super impressed :)
[20:44:14] * mdholloway shakes head
[20:45:03] <mdholloway>	 (at the return of the vandals)
[20:49:00] <dbrant>	 mdholloway: what is it now?
[20:49:54] <mdholloway>	 dbrant: penis pics again.  i didn't see it myself, just heard from thedj 
[20:50:20] <mdholloway>	 https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Wikipedia_app_vandalism
[20:50:29] <dbrant>	 oh right, from this morning. we had some OTRS reports, too
[20:59:04] <mdholloway>	 dbrant: maybe a use case for image recognition...
[20:59:31] <dbrant>	 quite :P