[17:04:04] dbrant: reets: i'm about to pick up T172881 but i'm not totally sure where things stand. based on the latest comment, did we decide to forget about maintaining a "download when back online" queue and just disable the download button when the device is offline? [17:04:05] T172881: [BUG] User should be shown a message when trying to download an article pack when they have no connectivity - https://phabricator.wikimedia.org/T172881 [17:05:38] iirc, we agreed on the latter (disable the button when offline) [17:06:10] dbrant: ok! any message needed, in that case? [17:08:10] I suppose that could be up to reets: either a) disable the button and don't show any message, or b) keep the button enabled and show an error snackbar when it's clicked... [17:14:16] dbrant: are we able to do all of the "expected" including having the download button replaced with download in progress once it is pressed? [17:15:32] reets: that will happen only if the user is online. [17:16:31] hmmm [17:17:51] dbrant: In that case (b) - just to confirm though, we would not be queuing the download when back online [17:18:22] that's right; they'll have to click it again once they're back online [17:20:23] reets: dbrant: ok, then! thanks! [17:21:19] reets: dbrant: actually, one more thing [17:21:34] the 'expected' scenario is to show a dialog [17:21:41] natalia's first comment mentions a toast [17:21:43] dbrant: cool that sounds good. The error message would be something to the effect of "No internet connection. Make sure you're back online before trying again." [17:21:54] a snackbar strikes me as most natural [17:22:29] which should it be? [17:22:34] +1 for snackbar [17:22:41] mdholloway: dbrant: sure snackbar wfm [17:22:48] sweet. thanks again! [17:26:05] mdholloway: dbrant: no worries, just updated the 'Expected' in the task description as well