[18:14:53] mdholloway: actually, standby on the crash fix patch... I have a better fix for it [18:15:14] dbrant: ok! [18:19:23] mdholloway: so, technically, the attribute crash will be automatically fixed by the Theme refactor. The reason it's crashing is that we don't actually yet override textColorSecondary yet. (Even though textColorSecondary exists somewhere deep in appcompat, it looks like we can't reference it in our layouts unless we override it ourselves.) [18:19:50] I'll update the crash fix patch to fix just the javascript issue, and just wait for the theme refactor to be merged. [18:19:52] ah [18:19:59] sounds good [19:55:54] screenshot tests didn't like that theme refactoring too much [19:57:45] actually they're not failing on the screenshots themselves, it looks like, but some other assertions [20:53:19] cooltey