[12:41:23] bmansurov or phuedx|afk: could you remind me how sampling/bucketing works for the Print schema on reading-web-staging - was it set to always send events? [12:51:56] HaeB, hi [12:51:59] it's set to 90% [12:54:50] thanks bmansurov - and how does one check again one is in the sample? [12:57:44] HaeB, you can run this snippet in your browser's console: [12:57:46] mw.experiments.getBucket( { [12:57:46] name: 'WMEPrint', [12:57:46] enabled: true, [12:57:46] buckets: { [12:57:46] control: 0.1, [12:57:47] A: 0.9 [12:57:49] } [12:57:50] }, mw.user.sessionId() ) === 'A'; [12:58:01] if it returns true, then you're bucketed [13:05:58] thanks [13:07:02] FWIW, i was asking because it did not send events in firefox with private browsing (even when bucketed and with DNT disabled)... [13:07:20] ...turns out it was the new(ish) additional tracking protection https://support.mozilla.org/en-US/kb/tracking-protection-pbm [13:08:19] good to know [14:35:51] mdholloway: see https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/services/mobileapps+branch:master+topic:hyg/diff [14:37:56] bearND: thanks, will merge as soon as the recheck is complete [19:08:07] tgr: there's another one ready to be merged: https://gerrit.wikimedia.org/r/#/c/379274/ [19:15:21] where does MobileFrontend currently set the device width boundaries aka media query values? [19:15:43] 'deviceWidthTablet' comes still from DefaultSettings.php, correct? [19:32:08] bmansurov: ^ [19:32:34] Volker_E, can you copy & paste, I lost internet connection briefly [19:52:11] bmansurov: .oo-ui-menuLayout-content [19:52:27] fuck, IRCCloud is sometimes not taking my copy cmd [19:53:04] https://www.irccloud.com/pastebin/hkcGajJ3/ [19:53:11] bmansurov: ^ [19:54:32] Volker_E, yes, it's coming from DefaultSettings.php [19:57:03] MobileFrontend just has one active media query boundary? [19:59:07] I think we have varaibles for small screens, tablets, and desktops [20:01:26] bmansurov: that comes back to my original question [20:01:35] bmansurov: ok, found an instance of `@wgMFDeviceWidthMobileSmall` [20:01:50] what does `wg` stand for? [20:02:03] it's a convention, i forget the history [20:03:28] bmansurov: I can't find the value set for @wgMFDeviceWidthMobileSmall, neither in core, nor in MobileFrontend nor MinervaNeue…? [20:03:38] wikipedia global [20:03:52] of wiki global or something like that [20:04:31] here you go [20:04:38] Let me see if I can find it [20:05:15] Volker_E, MobileFrontend extension.json [20:05:24] look for it without the wg prefix [20:05:34] ah, the fuck [20:07:24] thanks also tgr, another Gordian knot in my head cut :) [20:09:09] for context, we are trying to move from global $wgXXX syntax to $config->get('XXX') (where $config might one day be an actual config store but right now it just checks $wgXXX) [20:09:23] so you must grep for XXX if you want to find all uses [20:10:36] it's one of those refactorings which are a nice idea in theory but did not get enough buy-in so in practice are stuck halfway and make life more complicated than going fully one way or another [21:06:41] -> home