[14:26:11] Hi, Is there someone here from the mobile dev team? [14:28:13] hi Helmoony - i’m on the iOS team. do you have a question about iOS or Android? [14:28:34] joewalsh: both! [14:29:10] hopefully I can help - what’s up? [14:29:31] We are trying to implement a QRcode in a mesuem in my region. I found that the Wikipedia app doesn t have a QRpedia reader. Did you talk about that [14:30:11] because now I need to promote apps from outside wikimedia mouvement to help visitors access wikipedia articles [14:30:50] https://en.wikipedia.org/wiki/QRpedia [14:31:33] I just want to tell visitors, download Wikipedia App and from there you are going to detect QRcodes and read your article about that object [14:32:37] We haven’t talked about adding a QR reader to the iOS app, though I'd be happy to put that in as a feature request. On iOS, if you have the app installed and use Apple's Camera app to read the code, it’ll open the URL in the app - though I agree this isn’t as easy as having it within the app would be. [14:34:36] joewalsh: We tested QRcodes on iOS, for new iphones it's detectable for others it's not. And yes the main problem is with Android. Doesn't take too much space a QRcode reader on the app? [14:35:51] Is it the right place to start a discussion ? https://www.mediawiki.org/wiki/Talk:Wikimedia_mobile_engineering [14:37:55] Helmoony: yeah - QR code reading was added to the camera in iOS 11 so devices that aren’t or can’t be updated to that version won’t work. [14:38:46] I’ve filed a feature request ticket https://phabricator.wikimedia.org/T179587 - that would probably the best place to start a discussion [14:39:17] Helmoony: hi there, I'm from the Android team. Ah, I see Joe beat me to creating a ticket! [14:43:03] dbrant: you are all doing a great job. Just 1 min I want to show you a link saying that with QRcodes we can get stats. It's really important for us wikimedians because it's with that kind of information we can convince other meseums. [14:45:20] I lost the lin, but it'S somewhere here https://outreach.wikimedia.org/wiki/GLAM/QRpedia . [14:46:38] May I add some review in the ticket or it's just technical stuff [14:51:38] Helmoony: yes please add to the ticket - it’s not just for technical stuff [14:52:24] it’s an overall ticket to describe the feature as you see it [14:55:57] Thank you. Hopefully it's gonna be fixed before starting our project with the meseum! [15:01:00] By the way, there is an other issue related to mobile reading. When I log in with my ID and I click on an edit in my follow list, I see the possibility to say Thank you. The space is big, is there a possibility to add an other feature which is rollback. For reviewers, it's really usefull. When I need to rollback an edit in while navigating with the mobile version, I need to revert to the desktop version and then click on [15:01:30] .. for the flagged revision enabled wikis https://en.wikipedia.org/wiki/Wikipedia:Flagged_revisions [15:11:04] +0 [15:28:40] I'm back [15:32:28] did someone reply on rollback comment? [19:52:37] mdholloway|afk: dbrant: hey do you recall any examples from the collapse table transform which needed the 'getTableHeader' function to recurse? trying to tighten up it's performance and that's the slowest part, but wanted to make sure any fix still covered whatever case the recursion was put in place to handle... [19:52:52] @niedzielski ^ [19:53:33] it's been too long :( [19:53:50] yeah, i don't have any examples handy but i'm sure they exist :| [19:54:06] it'd probably be easier to just make a scratch page [19:54:43] dbrant: hehe ya :) [19:55:30] niedzielski: maybe i'll break if the result array has more than one element and browse around till it trips... [19:56:36] mhurd i think you could just put an infobox in a section or a section in a section, right? [19:56:54] niedzielski: ah right! [19:56:57] niedzielski: thx! [19:58:26] mhurd: since it's pure dom, you might also check the CollapseTable unit tests. i think it'd be pretty easy to add a recursive case if it doesn't exist [19:59:22] niedzielski: good idea! [19:59:38] it should be pretty easy to construct an arbitrary fixture in a few lines: https://github.com/wikimedia/wikimedia-page-library/blob/master/test/transform/CollapseTable.test.js#L495-L508 [20:02:33] niedzielski: wow... on obama article it's recursing 21 deep [20:02:46] lolwut [20:02:55] dbrant: right? :) [20:03:04] obama! [20:03:10] THANKS OBAMA! [20:05:36] dbrant: niedzielski: super odd given we only ever grab the 1st or 2nd item from the array... [20:05:59] (in the 'newCaption' method) [20:14:42] ok i think i see what it's doing now... should fairly easy to de-recursify... [20:14:50] *should be