[16:34:14] mdholloway: So, the mobile-section endpoints use ns and ns_text but summary uses namespace_id and namespace_name for the same thing. [16:35:36] bearND: hmm, yeah, probably best to be consistent where we can [16:35:45] now is the time to make sure the new summary fields are well-named [16:36:54] Yeah, I prefer to use the same name for the same things if possible. [16:38:41] speaking of which, i remember talking with coreyfloyd one time about moving the ns number/text out of the "titles" object and into the top level but i don't remember exactly what we decided. but it seems like they should come out and into the top level [16:40:16] i'll write a patch [16:40:19] mdholloway: bearND yeah the new mobile sections replacement will be a breaking change, so this is the time where we should be making name changes [16:41:23] bearND: mdholloway my thinking is since these properties were not in the summary before we should take the time to name them clearly… [16:42:05] A lot of this means spelling out parameter names to make them self documenting… [16:43:24] coreyfloyd: Yes, we're talking about new properties that have not been deployed yet. So, we still have the opportunity to change them, ... until later today when I'm going deploy the changes. [16:43:54] bearND: wait the new summary is being deployed today? [16:44:33] coreyfloyd: No, sorry. Only the mobile-sections changes would be deployed. The MCS version of the summary is not exposed through RB yet. [16:44:34] no, the changes won't be exposed to the public to day, the MCS summary endpoint isn't active yet [16:44:44] s/to day/today [16:45:10] s/deployed/exposed/ [16:45:19] fwiw i think "ns" for numeric namespace id is a mediawiki convention [16:45:45] not sure about ns_text so much [16:45:53] bearND: ok sorry… so you are adding properties to mobile sections end point today? [16:46:11] Sorry I am confused [16:46:29] coreyfloyd: no, sorry about the lack of context. this is about the new summary stuff [16:46:30] If it is easier we can all just hop on a hangout real quick [16:47:01] i think bearND was suggesting changing the fields in the new summary to be ns/ns_text to match with the existing lead section output [16:47:17] rather than namespace_id/namespace_text [16:47:22] happy to jump on a hangout if you guys want [16:47:44] Yeah lets… thats what I thought too, until Bearnd mentioned that changes are getting deployed to Mobile sections today [16:47:48] coreyfloyd: The new properties for mobile-sections are ns, ns_text, talk_ns, talk_ns_text, and a canonical title. [16:47:54] bearND: you ok for a hangout [16:47:55] ? [16:47:59] Bat cave? [16:48:04] coreyfloyd: sure [16:48:36] be there in a sec [17:19:45] niedzielski: hey are you around? [17:19:57] sorry in meeting [17:20:06] Kk… no worries [18:03:31] coreyfloyd: the meeting is over. let me know if you need anything [20:51:24] mdholloway|afk: Deployed in beta cluster. Should we also get rid of thumbnail and originalimage? (Example: https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/mobile-sections-lead/Dog) [20:51:53] in mobile-sections endpoints, I mean. [21:03:22] bearND: ahh, right [21:03:28] sorry i missed those [21:03:34] will do a quick follow-up [21:04:43] mdholloway|afk: same for dir and lang [21:05:03] right... i'm actually trying to find the commit where thumbnail and originalimage were added just to be sure [21:07:09] bearND: does your Frankenstein page somehow not have a PageImage? [21:07:35] mdholloway: It doesn't because it's in User space [21:07:47] that would explain why there's no thumbnail or originalimage properties in the test fixtures despite the changes in c42b594 [21:07:49] ah, ok [21:07:54] update incoming [21:08:05] k, ty [22:07:38] deploy is looking good so far. Still keeping an eye on it since we had a lot of changes.