[00:04:44] mhurd: if you look at the differences between the two demos, they are only a few lines off. what happens if you comment out the initial call to transformer.loadPlaceholders() in LazyLoadTransformer.html (for Safari only!!) [00:05:39] niedzielski: checking... [00:10:36] niedzielski: confirmed cache cleared, go back online and refresh, initially all i see is gray boxes. go offline, then scroll and all images appear, including the ones at the top which had been gray [00:14:08] mhurd: i'll check it out [00:20:20] niedzielski: thx! i added a note to the ticket (reporting on the trial integration spike). let me know if there's anything i can do to help! [00:22:00] mhurd: there's a bug in both demos. `const image = data.newImage(document)` should reference `lazyDocument` instead of `document`. that was my mistake and i'm sorry that caused you so much trouble! [00:22:38] mhurd: i'll push the fix regardless but if you would try the change locally to see if it unblocks your safari issue, that would be great [00:22:58] niedzielski: ah testing... [00:26:46] niedzielski: hmm same issue. oh, and the trial ios integration wasn't using that part of the demo code [00:29:20] mhurd: fix is here https://github.com/wikimedia/wikimedia-page-library/pull/108 [00:30:01] niedzielski: that's what i tried - no change :( [00:30:21] mhurd: going back to the LazyLoadTransform.html, do you see network requests for the images being issued in safari's version of dev tools? [00:30:52] niedzielski: checking [00:34:04] niedzielski: no network requests appear until i tap on a gray box [00:34:40] niedzielski: when i tap they appear (all seemingly for 100px variants) [00:35:00] mhurd: ok, that means the LazyLoadTransform code is probably working fine๐Ÿ‘ [00:35:39] mhurd: so switching to LazyLoadTranformer.html, if you comment out all the js after the for loop, do you see any network requests? [00:36:04] er, image network requests [00:36:55] niedzielski: oops i may have misspoke - refreshed while the network inspector was up and i see 17 100px image fetches [00:37:31] mhurd: this is with LazyLoadTranform.isLazyLoadable() hardcoded to true? [00:38:06] niedzielski: oh sorry it says it's cached... lemme retry after clearing cache... [00:38:34] > this is with LazyLoadTranform.isLazyLoadable() hardcoded to true? [00:38:46] no i switched back after testing that a while ago [00:39:04] after clearing cache it is transferring all 17 image when i refresh [00:40:24] mhurd: images will show if isLazyLoadable() isn't hardcoded. there's some small images in the test set [00:42:10] niedzielski: ah those may be the 17 i'm seeing? [00:43:01] niedzielski: anyhow, the trial re-integration today was just to get a feel for what work remained. can we maybe pair on this later tomorrow or next week? getting the feeling that hangout may vastly shorted our debugging in this case... [00:43:17] *shorten [00:44:27] i think there's food nearby - i can smell it hehe... getting distracted ;) [00:45:20] mhurd: tomorrow is fine. my calendar is up to date if you want to schedule something [00:45:36] niedzielski: ah sweet thx i'll send invite [00:45:41] mhurd: yeah, it's about dinner time here too. catch you later [00:45:53] niedzielski: thx again for the help! [00:45:55] ๐Ÿ‘ [00:46:06] thanks for spotting the bug and apologies if there is another forthcoming [00:49:40] oh yw and no worries at all! :) [15:55:49] hey FlorianSW! I pushed the change to T103952 :) [15:55:50] T103952: Long press on find in page up / down arrows should advance to first / last match - https://phabricator.wikimedia.org/T103952 [15:55:52] afk [19:32:38] niedzielski: oh looks like my 1:1 got moved to 1pm hehe. i'll keep tweaking the proxy bits in the mean time :) [19:33:40] okey dokey [19:42:25] niedzielski: got it - had to go to keychain, find the cert, and "trust" it [19:42:43] yayy [19:42:53] hehe seems pretty obvious now :P