[01:41:32] jdlrobson, is it some kind of a rule that test methods are in snake_case instead of camelCase? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/ce62bc351da0e46f2b4ce7609872ef0d6ca1cb26/tests/phpunit/devices/UADeviceDetectorTest.php#L153 [16:08:37] bearND: what do you think about removing the sepia cache mode default and leaving it to the user to set it in an env variable if desired? [16:39:50] mdholloway: Do you mean where we check for IN_DOCKER? [16:41:07] bearND: right, i'm thinking of taking this out: https://github.com/wikimedia/mediawiki-services-mobileapps/blob/master/test/utils/server.js#L4-L10 [16:43:10] mdholloway: yeah, was thinking about that, too, and was going to check with you, too. ;) I don't mind taking this out at this time. In the future we might want to have a flag that will force it to use live data for everything if the flag is set. [16:44:01] bearND: sounds good! [16:44:33] mdholloway: BTW. I'm trying to move from sepia to replayer (a fork of it) but have been running into issues when doing RB requests via preq. I'll probably write a task for that since it doesn't seem trivial. [16:45:30] getting: Error: incorrect header check at Gunzip.zlibOnError (zlib.js:153:15) [16:59:06] bearND: i just swapped in replayer 2.1.3 and the test suite still passed. do you have repro steps for the error? [16:59:39] mdholloway: have you removed the old fixtures? [16:59:58] bearND: yes, they're gone [17:00:12] mdholloway: hmm, that's strange [17:00:30] mdholloway: I'll push what I have for now and then you can compare. [17:04:45] mdholloway: all the test fail in the WIP patch. Did you do anything differently? [17:05:17] bearND: duh, i wasn't actually recording the responses ;) [17:05:22] yes, very broken! [17:14:06] mdholloway: I've tried replayer: 2.0.1, 2.1.1, and 2.1.3. Same thing. Only sepia 2.0.2 seems to work. I would like to move to replayer because it has some new functionality I like to use, most notably the ability to avoid recording certain headers. I'd like to avoid recording the GeoIP cookie and other headers. [17:14:32] Then we could commit the fixtures to Git. [17:16:26] bearND: yeah, moving to replayer seems like a good idea [17:27:22] jdlrobson hey! [17:27:37] morning :) [17:28:08] I don't know if you responded for my question tonight, so let me paste it [17:28:16] [02:41:30] jdlrobson, is it some kind of a rule that test methods are in snake_case instead of camelCase? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/ce62bc351da0e46f2b4ce7609872ef0d6ca1cb26/tests/phpunit/devices/UADeviceDetectorTest.php#L153 [17:39:36] Albert221: yeh exactly. The sniff means they need to be camelCase [17:39:44] (only functions, not keys) [17:40:11] so ["test_foo"=>5] would be fine but function test_foo() { } should be testFoo [18:14:06] jdlrobson, I added you as a reviewer for the patch [18:15:06] Albert221: yuppp saw them. I've got a few foreign work colleagues that i need to catch up with before they end for the day so im busy doing that now. Will take a look in a couple of hours if that's okay [18:16:17] okay, ping me then :) [19:50:31] Albert221: looking at it now :) [19:50:45] okay! [19:51:09] Albert221: so far looks like you got the hang of it! [19:56:24] jdlrobson, tell me if there would be anny issues! [19:56:55] Albert221: the issues im seeing can probably be fixed in a follow up [19:57:11] so i'll probably merge it (provided i get through it without seeing any issues) but with a few recommendations :) [20:09:09] Albert221: looks good. left some comments! [20:09:21] yeah, I'm reading them! [20:11:19] jdlrobson, I'll try to address some of these issues if I'll find a free time! [20:16:35] Albert221: thanks a bunch :)