[11:39:10] <jay__>	 hello
[15:05:55] <mdholloway>	 bearND: i happened to be looking at email and saw the phab task and your patch.  looking now... /cc dbrant
[15:14:06] <mdholloway>	 ok, i'm out for the year. happy holidays, all!
[15:19:43] <bearND>	 thanks! There will be a follow-up patch shortly as well. dbrant feel free to look at the 'ru' portion of the changes anyways, even though it's merged. I'll deploy in a couple of hours.
[17:21:56] <Albert221>	 Hello! dbrant, by "restarting the search from scratch" you meant simply calling findAllAsync again in https://gerrit.wikimedia.org/r/#/c/394365/8/app/src/main/java/org/wikipedia/page/FindInPageActionProvider.java ?
[17:22:25] <dbrant>	 Albert221: yep, that sounds like the simplest thing to do.
[18:10:42] <bearND>	 Actually, no follow-up patch needed AFAICS. ;)
[22:31:23] <Albert221>	 dbrant, are you online? :)
[22:31:58] <dbrant>	 Albert221: for a little while
[22:32:07] <Albert221>	 I'll update the patch in a minute
[22:32:15] <Albert221>	 just let me quickly test it :)
[22:37:45] <Albert221>	 ok, it'll take some 15 minutes more
[22:38:08] <Albert221>	 because I have encountered an error dbrant
[23:01:22] <Albert221>	 dbrant, do you have a while to take a look at my problem?
[23:02:11] <dbrant>	 Albert221: a few minutes
[23:03:27] <Albert221>	 look here: https://gerrit.wikimedia.org/r/#/c/394365/
[23:03:41] <Albert221>	 next and previous button works as it were before
[23:03:47] <Albert221>	 first button works too
[23:04:04] <Albert221>	 but last button doesn't work, it produces weird behaviour
[23:06:04] <Albert221>	 org.wikipedia.page.FindInPageActionProvider <- it is the file I am working at dbrant 
[23:08:55] <dbrant>	 looking...
[23:11:32] <dbrant>	 Albert221: in your method to find the last match, before you call findAllAsync(), you forgot to call clearAllMatches().
[23:12:55] <dbrant>	 also, in your next update, please remove the change to build.gradle
[23:13:37] <Albert221>	 dbrant, oh, how could I miss that, I checked this file for clearMatch two times :O yes, I'll destage this file
[23:13:41] <Albert221>	 thank you!
[23:14:10] <dbrant>	 anytime!
[23:20:16] <Albert221>	 dbrant, patch pushed! :) https://gerrit.wikimedia.org/r/#/c/394365/
[23:20:34] <dbrant>	 great; will check out more fully tomorrow