[14:07:53] phuedx: good afternoon :) [14:08:10] well hello there hashar! [14:08:24] eventually last week I ended up blocked for chromium-render while trying to use Chromium 63 from Debian :( [14:08:52] the test suite seems to work more or less but stall at the end bah [14:09:35] phuedx: that looks like https://phabricator.wikimedia.org/T179552#3841696 [14:09:35] so weird [14:09:40] but not sure who is taking care of those tests [14:09:49] seems there is something idling / waiting without any timeout [14:09:53] but really I can not figure what [14:11:11] the only good news is that I reproduce it on my machine hehe [14:11:38] oh man [14:11:40] forget me [14:11:46] phuedx: https://gerrit.wikimedia.org/r/#/c/394623/ by bmansurov fix the issue hehe [14:11:50] \o/ [14:12:10] nice! [14:12:18] so there was a hanging process somewhere [14:12:30] hashar: thanks for investigating this <3 [14:12:37] 4352 pts/0 Sl+ 0:03 | \_ /usr/bin/nodejs /home/hashar/projects/mediawiki/services/chromium-render/node_modules/mocha/bin/_mocha --recursive --no-timeouts [14:13:53] oh man [14:26:19] phuedx: so bmansurov apparently fixed the timeout issue :] Will try to catch up tonight and hopefully we will have the CI job enabled before the holidays [14:26:39] awesome! [14:26:51] so a promise wasn't resolving? [14:27:05] hashar: that's great feedback for bmansurov and raynor [14:27:46] well hmm [14:27:55] I dont even know how Promise works in nodejs :] [14:27:59] much less how to debug them hehe [14:28:17] but yeah, it seems there is something something that keeps the process idling [14:28:48] there are a few tests failling. They are probably legit failures worth investigating [14:28:56] let me read the above [14:29:03] such as html2pdf "should return a letter-sized PDF" and the eslint check [14:30:28] raynor: hello! the short version is that I have been tasked in adding a CI job for chromium-render . The job just "npm install && npm test" more or less [14:30:30] hashar - there is an bug raised with chromium, that sometimes it doesn't close gracefully [14:30:47] and I found out that the build is idling at the end of the mocha run ;] [14:30:49] we tell chromium to stop, it says "ok", but it keeps doing stuff o_O [14:30:55] hoooo [14:31:30] they marked it as a bug, might be related to that case, might not, with bmansurov we will check whats going on, thanks for the info [14:31:51] great! [14:32:11] and ultimately one will be able to stop puppeter from using the bundled Chromium version and use the Debian package one instead :] [14:32:20] (I got patches pending for that) [14:32:26] also, last time we did some proper testing was when we were using puppeteer v.0.11.0 [14:32:30] which might help to push the service to prod [14:32:32] now it's v.0.13.0 -> [14:32:37] this also might be a reason [14:33:11] well I guess as long as you are aware of the issues and are committing to fix them, we are all set :] [14:33:20] hashar -> btw, this service is using internet connection to test [14:33:26] (twist: I dont even know what that chromium-render service is supposed to do hehe ) [14:33:28] it tries to download articles from english wikipedia [14:34:05] chromium-render is using chrome API, which asks chromium instance to render a webpage as PDF [14:34:30] ah that sounds like a replacement for OCG isn't it ? [14:34:35] it's almost the same as you open the chromium, navigate to page X, hit print, and select "PDF" as the printer [14:34:40] we do the same, only in CLI [14:34:48] yes, exactly [14:34:52] \O/ [14:34:54] thanks god [14:35:34] then we just have to tweak the print.css and we are set. Sounds good :] [14:35:45] ok, I'm runing tests locally, one test fails [14:36:10] but I have no stalled jobs, `npm test` exists immediately, doesn't hang on sth [14:36:40] we will fix the failing tests today [14:37:53] who know why it is stalling :/ [14:38:09] we do some strange tests [14:38:21] like trying to simulate long waiting time [14:39:02] I remember those tests worked, so or we broke something, or we have to do sth different for puppeteer v0.13.0 [14:39:17] (they rewritten the navigation api) [14:41:40] no worries [14:41:57] I will keep lurking the changes, and whenever that is working reliably will flip CI on :] [14:42:10] thx