[16:01:22] omw... [16:37:39] bearND: is https://gerrit.wikimedia.org/r/#/c/403977/ ready to merge or did you want to make an update? [16:39:12] mdholloway: I would love to get some feedback from jdlrobson about that one. Then I'll make a follow-up patch to add the style attribute copy as well. [16:39:33] bearND: ok, thanks, i'll leave that one alone for now, then [17:24:33] nzr: can you check the infobox styles on http://reading-web-staging.wmflabs.org/wiki/Jarmila_Kratochv%C3%ADlov%C3%A1 again when you get chanc? [18:12:50] Hello all. I was recently wondering about how the "Continue reading" cards are shown in the Wikipedia android app. [18:13:29] Are they shown for every single open tab in the app? [18:14:12] When the device is offline, are the "Continue reading" cards shown even for articles that aren't available offline? [19:52:12] mdholloway: not sure that loop-in worked [21:25:06] tgr: oh? [21:25:46] mdholloway: I mean you didn't add anyone new to the thread [21:30:06] tgr: ah, i guess it was redundant anyway [21:43:24] bearND: :) [21:43:27] so would you like me to merge? [21:44:12] jdlrobson: yes. Thanks for taking a look. Mainly wanted to make sure you don't have any concerns about really flattening some of the a elements [21:44:30] bearND: we'll find out :) [21:44:36] would be good to generate the summaries again [21:44:48] (for the top 500 most read) [21:44:58] but i guess we'll do that before finalising all the other changes? [21:49:33] jdlrobson: I hope this is mainly it for summary code changes for this round. I'll kick off a run of the top en pages, so we can compare the output. [22:36:23] jdlrobson: coreyfloyd [22:36:41] i found some more issues with the summary results [22:37:16] I guess we'll have to postpone the switch-over until after next week [22:37:50] mdholloway: ^ [22:38:07] going to file some more tickets [22:59:39] bearND: which ones? [22:59:48] bearND: can you upload the results somewhere? [23:00:13] (also how can i remove myself from default subscribers of mobileapps? Im getting lots of noise and would prefer to just be added to ones you specifically need my help on) [23:05:49] jdlrobson: Hmm, not sure. I don't see you as a member or watcher on https://phabricator.wikimedia.org/project/members/1323/. Maybe it's from a profile setting in your Phab account? [23:18:04] jdlrobson: Here are the new results: https://phabricator.wikimedia.org/T185050 [23:18:19] bearND: thx! [23:19:03] bearND: http://jdlrobson.com/summaries/en.2b.html [23:19:18] Transformers: The Last Kni < bearND owch! [23:19:34] any idea what added that one? [23:21:12] bearND: not sure what happened with the geo though [23:21:16] i specifically remember ripping that out [23:22:04] jdlrobson: Yeah, I think the geo thing is victim of some optimizations which happened later. Unfortunately we didn't have a test that caught it. [23:22:32] making some edits to the task with some new bugs [23:24:10] bearND: HTML one is most concerning :/ [23:24:25] yep [23:25:16] but most issues should be fixed on the plain text side as jdlrobson well once the html ones are fixed [23:29:42] bearND: doesnt look like the summary endpoint uses pageJsonPromise any more... I6a1a31aa5a1e5e608a37b0e8722c1c26b6ea4411 [23:29:49] https://gerrit.wikimedia.org/r/#/c/404246/ [23:30:00] bearND: that's why [23:30:08] it needs it to get the source text [23:30:21] buildSummary was not designed to run on the entire HTML of the page.. [23:34:11] jdlrobson: That's correct. I replaced the call to pageJsonPromise because it does all those transformations on the whole page but we only need to run them on the lead paragraph. buildSummary now calls a new function buildExtracts, which in turn calls extractLeadIntroduction. [23:34:19] I think running transforms.stripUnneededMarkup should be enough though [23:34:33] bearND: i can write a patch [23:35:02] bearND: Thanks for the update. After all hands sounds fine [23:35:12] jdlrobson: Most of those in stripUnneededMarkup are not needed anymore since I'm removing all attributes except class and style. (unless the element is an img) [23:39:03] bearND: maybe not but i think to play it safe we should run it [23:39:14] https://gerrit.wikimedia.org/r/404603 Summaries should not contain coordinates < bearND [23:41:31] jdlrobson: I think just doing _runAllSectionsTransforms should be fine [23:42:23] bearND: looks like IPA should also be removed.. [23:43:16] bearND: it doesn't work with parenthetical.. [23:43:29] jdlrobson: which article? [23:43:36] Ariana Grand [23:43:57] I'm seeing () [23:46:19] jdlrobson: I only see `Cat Valentine`. No other span in http://0.0.0.0:6929/en.wikipedia.org/v1/page/summary/Ariana_Grande [23:46:31] bearND: it's a side effect of https://gerrit.wikimedia.org/r/404603 [23:47:12] (i think..?) [23:47:40] oh no.. it's a problem on master too [23:47:41] hmm [23:48:14] bearND: weird.. http://0.0.0.0:6927/en.wikipedia.org/v1/page/summary/Ariana%20Grande [23:48:19] is giving different result [23:49:44] jdlrobson: Yeah, with https://gerrit.wikimedia.org/r/404603 I can see the empty span inside parentheses. [23:51:13] bearND: it's an issue on master too [23:51:17] separate issue to log.. [23:52:44] bearND: is the undefined an issue with your script or the summary? [23:52:46] i think the former? [23:52:56] seen in Donald Trump and Obama [23:53:00] (on v) [23:53:01] http://jdlrobson.com/summaries/en.2b.html [23:53:48] jdlrobson: can't see empty span inside parentheses on master. I do see the undefined string now, too. That's another issue to log [23:56:03] bearND: weird. the undefined string is not related to the summary endpoint.. [23:59:10] bearND: [23:59:17] delete summary.code; is the offending line..