[00:00:00] <jdlrobson>	 im guessing there's some kind of side effect from calling it...
[00:01:31] <jdlrobson>	 bearND: and i cant replicate it locally any more o_O
[00:07:22] <bearND>	 jdlrobson: I don't remember why we put in the `delete summary.code` line but it doesn't remove the undefined issue. Maybe I misunderstood you.
[00:08:16] <jdlrobson>	 bearND: HAH! Now i remember the caveat with removing spans :)
[00:08:44] <bearND>	 jdlrobson: oh oh
[00:09:35] <bearND>	 jdlrobson: what is it?
[00:12:04] <bearND>	 bbl
[00:15:49] <jdlrobson>	 bearND: there's an issue with the flatten code
[00:26:13] <jdlrobson>	 that's what's causing the HTML issues. Sorry I didn't get that via code review.. > https://gerrit.wikimedia.org/r/404603
[00:47:33] <jdlrobson>	 bearND: as http://jdlrobson.com/summaries/en.2b.jon.html demonstrates those 2 patches i've posted eradicate most of the issues..
[01:06:42] <bearND>	 jdlrobson: very nice. BTW, I'm really tempted to remove the beta cluster test. Not sure what it buys us.
[01:17:01] <bearND>	 Ugh, `PHP fatal error: <br/>\n  Stack overflow` on http://localhost:6927/en.wikipedia.beta.wmflabs.org/v1/page/mobile-sections/Foobar
[01:34:34] <bearND>	 looks like tgr noticed it first: T185055
[01:34:34] <stashbot>	 T185055: Stack overflow when Redis is down - https://phabricator.wikimedia.org/T185055
[17:38:03] <jdlrobson>	 bearND: i dont think it adds much tbh
[17:38:19] <jdlrobson>	 also  npm run test:unit seems to require internet again
[17:38:22] <jdlrobson>	 can we fix that?
[17:38:34] <jdlrobson>	 (it also makes the tests run slower)
[17:50:08] <bearND>	 jdlrobson: which unit test uses the internet or why do you think so?
[17:50:45] <jdlrobson>	 bearND: there's a PREQ_CONNECT_TIMEOUT=15 
[17:51:45] <bearND>	 jdlrobson: that is not needed, was just copied from the other one
[17:52:17] <bearND>	 I'll remove it
[17:54:10] <jdlrobson>	 great :)
[17:54:19] <jdlrobson>	 Do you get  lib:dateUtil Unhandled rejection AssertionError [ERR_ASSERTION]: undefined deepEqual 0 when you run?
[17:55:13] <bearND>	 jdlrobson: yeah, that's a really weird one. mdholloway also noticed that a few weeks ago. It looks like it only happens when we run the whole test suite
[17:56:17] <mdholloway>	 jdlrobson: bearND: https://phabricator.wikimedia.org/T182738
[17:56:21] <bearND>	 or all the tests in that file but not if running the last test by itself
[18:01:18] <bearND>	 jdlrobson: ok, fixed that, too: https://gerrit.wikimedia.org/r/404744
[19:23:09] <bearND>	 lol, you beat me to it. ;)
[19:23:23] <bearND>	 mdholloway: ^
[19:24:05] <mdholloway>	 bearND: hmm, the large test passed without it, though...
[19:24:17] <mdholloway>	 looks like we'll have inconsistent results again for a bit :(
[19:24:27] <bearND>	 uh, no
[19:24:34] <bearND>	 ;(
[19:35:15] <mdholloway>	 bearND: oh, nm, i accidentally left a 'describe.only' in the first PS, so the diff tests didn't run...
[19:35:35] <mhurd>	 dbrant: mdholloway: if you have some CR cycles to spare the consolidated 1st paragraph PR is up https://github.com/wikimedia/wikimedia-page-library/pull/122
[19:36:04] <mdholloway>	 mhurd: will try to have a look this pm!
[19:36:13] <mhurd>	 cool thx!
[19:36:35] <bearND>	 mdholloway: makes sense. Gives us some hope. ;)