[17:20:12] Hello all. I was recently generating my own ZIM file and tried to open it up using the Wikipedia Alpha android app. [17:20:31] Surprisingly, only the lead section of the pages present in the ZIM file were shown. [17:21:01] Is this an issue with the way th ZIM waas generated or is this is a limitation of the app? [17:22:20] When I tried to open the artilce in the same ZIM file using Kiwix in my laptop; it worked fine i.e. all sections were shown. [17:31:26] kaartic: if you specified the 'nodet' format option, then only the lead section will be shown for an article [17:32:18] (actually, only the lead section will be scraped from WP; the generated file will be returning everything it has) [17:35:19] mdholloway: I actually didn't explicitly specify anything except for mwUrl, adminEmail, verbose, minifyHtml, creator and articleList to mwoffliner. [17:36:28] kaartic: hmm. i wouldn't think nodet would be a default (but I've been wrong before...) [17:36:54] did you self-install mwoffliner, or are you using the VM provided by Kiwix? [17:37:09] (maybe there's a docker distribution now too, haven't checked lately) [17:37:44] kaartic: also, are other ZIM files still showing full page content in the app? [17:38:14] I'm using the npm module. https://www.npmjs.com/package/mwoffliner [17:38:46] Not sure about the other ones as I've not checked them recently. I suppose, they do. [17:40:02] mdholloway: BTW, I still find this confusing because the Kiwix applicatoin in my laptop shows the whole article! [17:40:37] kaartic: aha! sounds like an app bug, then [17:41:34] i have a hunch... [17:41:36] * mdholloway takes a quick peek at zimdroid section parsing [17:45:58] BTW, what's that 'nodet' supposed to mean actually? Also, do you know of a good documentation for 'mwoffliner'? [17:47:25] They seem to have very less in terms of documentation. I had to read the code to find that you have to use 'articleList' to download a list of article list. [17:47:50] (1) i gather it means "no details" and (2) no :) [17:48:23] i think they run a pretty lean operation and move quickly, and documentation doesn't always get much priority [17:48:35] when i was looking at this stuff it was a lot of trial and error [17:48:53] but you can find them on #kiwix and ask questions [17:49:30] Thanks, I'll see to it. [17:50:02] dbrant: could it be possible that the JS bridge code for loading from ZIM files needs to be updated for "native" Parsoid sections? [17:52:06] mdholloway: it could. [17:52:20] mdholloway: Just to ensure that 'nodet' is really kicking in here, how do you actually specify it? Is it by setting the 'nodet' property to 'true' in parameters? [17:52:37] that's my best guess as to what could be going on with kaartic's zim file. [17:53:30] options can be specified either with command line flags or in a config file; nodet can be enabled with --format=nodet [17:53:55] or --format=...,...,nodet if combined with other options (like nopic) [17:54:35] mdholloway: I think I'm going to prep the deploy soon. did you want to get https://gerrit.wikimedia.org/r/#/c/404534/ in as well? [17:55:03] bearND: yep, i'm mid-rebase, will push in a min! thanks for the heads-up [17:56:18] k, ty [18:09:07] kaartic: just to be clear, i think nodet is *not* in effect in your case, if the same file is showing articles in full in the Kiwix reader [18:10:41] mdholloway: I get that. I just wanted to ensure that the Kiwix reader isn't buggy (!) by generating a package with 'nodet' and seeing how it renders it. [18:10:45] :) [18:11:17] OR maybe I'm misunderstading the whole thing. [18:11:19] ah, i see [18:12:27] You were trying to say that, if 'nodet' was in effect then nothing except for the lead section would be dumped. [18:12:45] As the Kiwix reader rendered it correctly, you think there's some issue with how the app handles ZIM files. [18:13:41] right [18:15:09] mdholloway: In that case, does it mean I have to file a new task for this? [18:16:44] kaartic: if you find that there's a problem with article display that only turns up in the android app, then yes, please do file a task [18:17:04] Sure. [18:17:23] BTW, I was recently wondering about how the "Continue reading" cards are shown in the Wikipedia android app. [18:17:44] How are they actuall shown? Are they shown for every single open tab in the app? [18:17:51] When the device is offline, are the "Continue reading" cards shown even for articles that aren't available offline? [18:19:21] kaartic: i've been working on a different project for the past few months so this may have changed, but IIRC "continue reading" cards were based on the browsing history stored in the DB [18:19:52] i do not think any special check was made with respect to offline availability, but that may have changed as offline work has continued to be a focus [18:21:36] kaartic: anyway, i must run out for a bit. thanks for letting us know about the potential zim display problem! [18:22:39] You're welcome. I'll see if any body else currently in the android team could solve the mystery of "Continue readnig" cards for me. [18:24:04] I guess the "browsing history" is different from the one the user sees in the 'History' view. [18:25:16] I actually started wondering about it this because I once saw multiple 'Continue reading' cards being shown for the 'Main Page' [18:26:16] Then I saw that I had multiple tabs with 'Main page' open. So, I suspected the open tabs [18:30:30] dbrant: could you possibly help me with this 'Continue reading' mystery? [18:32:16] Yes, the Continue Reading card pulls items from your currently-active tabs. [18:32:50] It doesn not care whether you're online or offline. [18:50:12] The former doesn't seem to be a big deal but the latter is. [18:52:26] The cards should be shown only for tabs whose content can be accessed when the device is offline. (If it's possible to identify tabs that could be accessed offline, of course) [18:52:32] I would consider it very, very low priority. [18:59:04] It's enough if you "consider" it :-) [19:17:32] dbrant: heya! is the min target version for android still 4.1? re: https://github.com/wikimedia/wikimedia-page-library/pull/123/files#diff-17193d149b929ed159c2a4a1b14edcf9L4 [19:27:08] mhurd: the min target version for Android is 4.4 [19:27:36] mhurd: ^^ sorry, in mtg! [19:28:08] ah sry thx!!! :)