[07:15:44] Yes I recently created one [13:50:28] olliv: o/ i think SWATting that patch is an excellent idea. you guys have it covered? there's a SWAT window coming up in 10 mins and i'd be happy to shepherd it through if it'd be helpful. i'm familiar with the process. [13:59:17] @mdholloway - ah, just saw this, I think swatting it would be great - if you have time, let's do it. I'll also check if there's anyone available from our side [13:59:25] olliv: ok! [14:00:38] olliv: ack, can't cherry pick from the gerrit ui... i'll do this manually and see if there's still time [14:06:16] ping @niedzielski [14:06:24] o/ o/ [14:07:01] hey mdholloway ! i'm going to cherry pick manually because of the build products in the repo [14:07:31] niedzielski: awesome [14:08:55] mdholloway, niedzielski - thank you both! [14:09:20] niedzielski: i was having no success on the spot figuring out how to identify wmf.22 in gerrit so as to pull it down manually (or act on it remotely) [14:09:46] git fetch --all unhelpful [14:10:37] anyway, i won't distract you further now but let's recap after it's swatted! [14:11:33] mdholloway: https://gerrit.wikimedia.org/r/#/c/415564/ [14:11:45] mdholloway: just check your .git/config and make sure you can fetch all remotes [14:11:51] like `fetch = +refs/heads/*:refs/remotes/origin/*` [14:11:59] ah, lemme take a look [14:12:10] and then `git fetch --all` should get those other branches like wmf/1.31.0-wmf.22 [14:12:33] to push against the special gerrit branch, i just do `git push origin HEAD:refs/for/wmf/1.31.0-wmf.22` [14:13:07] the popups repo versions the build products so cherry picking must be done manually unfortunately [14:13:28] niedzielski: yeah, mine was just configured for master. [14:14:06] i guess that's what 'git review -s' sets up [14:15:03] in any case i rarely have occasion to touch it -- but now i know :) thanks. [14:15:13] mdholloway: i had a bad experience with git review early on so i just stick with git [14:15:23] niedzielski: i'll +2 this as soon as it comes back from CI [14:15:45] thanks mdholloway [14:16:56] niedzielski: ah, i can't +2, i guess it has to be the SWATter that does it [14:17:07] for a non-master branch [14:17:11] which makes sense [14:18:13] hm, maybe piotr can help us [18:33:20] Hi, wanted to ask what would be the simplest way to implement collapsible content on Skin:Minerva? [19:28:49] @Mobile team https://www.mediawiki.org/wiki/Skin:Minerva_Neue mixes “Minerva” and “Minerva Neue“? That's a bit confusing. Also I thought there's no hard dependency any more (first paragraph)… [20:12:18] niedzielski: if you're up for some trivia: it turns out it wasn't git-review that gave me a .git/config only configured for master, it was MW-Vagrant. it looks like MWV actually does 'git clone --single-branch' which results in that config. [20:12:54] anyway, i think it's still totally reasonable to avoid git-review! [20:14:11] 👍