[21:25:11] jdlrobson: o/ Any idea why the test I added for https://gerrit.wikimedia.org/r/c/430246/ passes locally but fails in CI? [21:25:29] "Undefined index: description" [21:26:32] when I say locally I mean in my local Vagrant [21:29:35] bearND: looking [21:30:45] bearND: im guessing some config needs setting somewhere on a dependency is not available in CI [21:32:03] bearND: i can replicate locally so let me see if i can work out what's happening [21:32:43] jdlrobson: ok, thanks [21:33:37] bearND: I don't have wikibase installed, so looks like "{{SHORTDESC:my local description}}" is expecting the parser to do its thing (which it will not) [21:33:57] jdlrobson: ah, that's probably it. tgr told me that this require wikibase to be installed [21:33:58] bearND: are these tests actually hitting the API? [21:34:01] requires [21:35:10] jdlrobson: going to set some breakpoints later, gotta run to a meeting [21:38:42] bearND: so my suggestion would be to pull this logic out into a separate function addDescriptionToResult( $resultObj, $data ) [21:38:48] and just make the test cover that [21:38:53] execute is horribly long anyhow [21:39:10] (we're not going to add more extensions to CI - they're slow enough as they are) [22:05:43] jdlrobson: ok, thanks. Will try that.