[16:06:46] Hey addshore, I'm working on this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/472427 [16:07:01] Test runs locally but Jenkins is complaining of the File mocking [16:07:06] Any hints please? [16:07:14] File mocking? [16:07:17] paste? :) [16:07:28] Here is the pending patch [16:07:30] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/472427 [16:07:36] Mocking the File class [16:07:48] Suprisingly, other test doing the same thing works fine [16:07:54] And Jenkins doesn't complain :( [16:07:58] :/ [16:08:16] Maybe I'm doing something wrong somewhere? [16:08:33] what errors are you getting locally? [16:09:20] No errors locally [16:09:24] Tests are running fine locally [16:09:39] oh! [16:09:41] It's only Jenkins complaining [16:09:43] hmmm [16:10:42] Locally, everything is really fine :) [16:10:44] Using PHP 7.2.11 [16:10:46] PHPUnit 6.5.13 by Sebastian Bergmann and contributors. [16:10:48] .............. 14 / 14 (100%) [16:10:50] Time: 11.41 seconds, Memory: 42.25MB [16:10:52] OK (14 tests, 14 assertions) [16:11:18] I do not know what I'm doing wrong [16:11:31] addshore: Rechecking that patch again to see [16:13:00] d3r1ck: i also get the failures locally [16:13:10] is sounds like your local environment is dirty! [16:13:30] Hmmmm..... [16:13:48] How can I fix that? [16:19:45] addshore: "local environment is dirty", how? [16:20:10] d3r1ck: i left 3 comments [16:20:18] looks like the last one is the most important [16:20:31] Okay! I've replied and fixing those now! [16:20:32] it looks like PageImages is not installed in CI while running MobileFrontEnd tests (at a guess) [16:20:35] and your tests require it [16:21:07] Not all test requires it but yes you have a point there [16:21:19] Jon told me about this [16:21:26] if you add PageImages to https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L262-L263 it woudl be pulled in in CI too [16:21:29] * addshore has to run now! [16:21:32] hope that helps :) [16:21:58] Okay, thanks a lot! [16:22:10] and thats why they fail for me, as I dont have PageImages :P [16:22:18] Okay!