[16:09:11] Technical Advice IRC meeting starting in 0 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @nuria - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [17:39:47] Working with Minerva Neue on 1.31 with MobileFrontEnd and trying to change / fix a few things. First: the __NOTOC__ fix suggested here for Neue doesn't seem to work on 1.31: https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend [17:44:31] (Let me know if this is wrong venue) Next: I notice "nomobile" tagged items still show on MinervaNeue's "Contents" section on mobile. I'm working on a solution via MinervaNeue.php but want to make sure I'm not duplicating effort if it's already fixed somewhere. [17:46:12] (I meant via skins/MinervaNeue/resources/skins.minerva.tablet.scripts/toc.js [17:46:12] ) [21:09:13] cooltey: hello! I have noticed your task about the CI job for android app failing due to license :/ [21:09:17] https://phabricator.wikimedia.org/T214497 [21:09:23] I have no clue what is happening [21:24:02] I did a bit of debugging but I don't have any lead as to how to fix it :/ [22:11:51] hashar: Thanks! Unfortunately I don't have an idea either. [22:38:12] Abulafia: hey! [22:38:34] jdlrobson: Hey! [22:38:54] sorry for the late reply! [22:39:05] Happy for any reply :) [22:39:07] lemme check for you [22:39:43] Abulafia: are you configuring $wgMFRemovableClasses ? [22:40:15] you'll need to define $wgMFRemovableClasses = [ 'base' => ['.nomobile'], 'beta' => ['.nomobile'] ] to make sure anything tagged nomobile is removed [22:41:04] the table of contents behaves differently on Minerva to other skins - NOTOC doesn't have any effect I believe. [22:41:14] I'll give that a go - much obliged! [22:41:54] As far as NOTOC goes, I had read that there was a fix that made NOTOC work, but it doesn't seem applied in 1.31 and any versions beyond that break on a 1.31 deployment. [22:42:09] that's possible ... I don't know off the top of my head to be honest [22:42:23] So are you trying to /show/ the table of contents or /hide/ the table of contents? [22:42:37] Details were from here: https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend No worries - it's only impacting one of our pages and I can kludge something, but yeah, we're trying to hide contents on our main page. [22:42:52] but we show it on most (all?) of our other pages [22:43:20] The NOTOC issue is less of a priority, but thought I'd check since it sounded like there was a fix out there somewhere. [22:43:22] Other option is to edit MediaWiki:Mobile.css and add a css rule to hide toc [22:49:02] Do you know if $wgMFRemovableClasses will also exclude it from Collections' output? [22:50:43] (Blech - stupid question ignore it. doesn't apply to Collections. I have to remove a .nodesktop tag from Collections, but that's not your fault! [22:55:02] jdlrobson Thanks for the help! [23:58:50] abian: :) [23:59:04] whoops.. finger slip sorry :)