[12:40:08] is there an alternative class to 'infobox' that can put an infobox below the first paragraph in the mobile version? [12:54:54] not exactly like that [12:55:14] but floatright sort of works i think [12:55:43] but i doubt that that actually moves content. maybe it just applies the 100% wide styling [13:00:52] danilo: ugh.. [13:00:53] https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/914f4a0df9f334c8cbc26ff549a76499579812a1/includes/transforms/MoveLeadParagraphTransform.php#65 [13:01:11] yuck. hardcoded classnames... [13:08:10] ok, thanks [13:10:49] maybe someone want to update this page about that: https://www.mediawiki.org/wiki/Reading/Web/Projects/Lead_Paragraph_Move [13:14:29] I asked that because in ptwiki the majority of infoboxes use the infobox_v2 class and they can not use infobox class because they have incompatible styles [15:04:12] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @halfak & @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:30:54] thedj: I think the line that search the class is https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/914f4a0df9f334c8cbc26ff549a76499579812a1/includes/transforms/MoveLeadParagraphTransform.php#99 [15:31:55] that should match any class that starts with "infobox", but that is not working with the class "infobox_v2" in ptwiki [15:34:13] and I made a test in my sandbox page with a and the infobox is above the first paragraph in mobile version: https://pt.m.wikipedia.org/wiki/Usu%C3%A1rio:Danilo.mac/Testes [15:34:34] *infobox [15:40:28] danilo: weird... [15:40:42] oh, it does that transform in main space only, if i remember correctly [15:43:27] "incompatible styles" [15:43:56] no such thing. There is only 2 different visual results, but everything can be overridden ;) [15:46:34] hmm, you guys still use prettytable ? AWB that thing into oblivion already ;) [15:47:23] 11 years deprecated already [15:52:01] danilo: ok. if you add: [15:52:03] .infobox tr { vertical-align: top [15:52:11] correction... [15:53:47] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @halfak & @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:53:49] .infobox_v2 tr { vertical-align: middle; } [15:54:09] danilo: and then simply change infoboxes to have class="infobox infobox_v2" [15:54:57] then your infobox_v2 should be overriding all the styling of your other infobox and you should see no difference with just carrying class="infobox_v2" [15:55:09] but things will still work in mobile [15:57:18] and that is exactly how you should be using classes [15:58:16] primary class, denoting the functionality, secondary class to modify the appearance. This your second class overrides ALL the properties of the first class, the visual effects of the first class are overwritten. [15:59:21] Add .infobox_v2 tr { vertical-align: middle; } to your MediaWiki:common.css is what i meant. [17:12:18] thedj: yeh, our Common.css is a little messy, I am working to improve that, thank you for the advises :) [18:22:40] hey Volker_E (maybe James_F too?). if it's possible to publish a release of oojs-ui soon that would help unblock some of eric's (multimedia) work. i'm not sure if you have bandwidth for a release but i wanted to let you know [18:25:21] niedzielski: yes [18:25:26] on it [18:26:26] niedzielski: they are normally scheduled for Tuesday, but have been delayed this week with some new nice and important stuff, like Ed's SelectFileWidget improvements, that will help Multimedia team [18:29:21] And shrink the size of the payload, which is nice for all our users. :-) [18:30:39] thank you Volker_E ! and thanks for the background both, Volker_E and James_F ! [18:31:01] Timing. ;-) [23:15:56] niedzielski James_F hey I was just asked who owns mobilediff I originally thought that was audiences. Do you know? [23:16:14] jdlrobson: ^ [23:17:13] coreyfloyd: special:mobilediff? [23:17:17] e.g., https://en.m.wikipedia.org/wiki/Special:MobileDiff/888347724? [23:17:43] That’s what I’m guessing is being meant [23:17:47] niedzielski: ^ [23:18:15] https://phabricator.wikimedia.org/T101796 [23:18:43] I’m guessing this is a ticket for it... I’m just poking around [23:19:26] I was figuring it was readers web [23:20:40] afaik, this is owned by readers web. it lives in mobilefrontend and makes use of the desktop differ with some nasty mobile friendly sprinklings on top [23:21:47] i won't presume to speak for the team, but it's my understanding that we would love to upstream the mobile-specific changes into core but haven't had the bandwidth to do so [23:23:11] niedzielski: ok that’s what it looks like to me too... thanks a lot for looking. And yeah, I think handling more mobile functionality in core is a good idea too :) [23:24:02] +1 to upstreaming the code. [23:36:17] coreyfloyd: it's in MobileFrontend sadly yes. we'd love to hae it in core. [23:36:30] There's a bug let me find it.. [23:38:08] coreyfloyd: https://phabricator.wikimedia.org/T117279