[00:22:14] <wikibugs>	 10Gerrit, 10patch-welcome: Gerrit newcomer bot sometimes stop working - https://phabricator.wikimedia.org/T221331 (10srishakatux)
[00:22:28] <wikibugs>	 10Gerrit, 10patch-welcome: Gerrit newcomer bot sometimes stop working - https://phabricator.wikimedia.org/T221331 (10srishakatux) p:05Triage→03Normal
[00:24:21] <wikibugs>	 10Gerrit, 10patch-welcome: Gerrit newcomer bot sometimes stop working - https://phabricator.wikimedia.org/T221331 (10srishakatux)
[00:52:13] <wikibugs>	 (03PS1) 10Ejegg: Fine-tune test exclusion for core fr/REL1_31 branch [integration/config] - 10https://gerrit.wikimedia.org/r/504824
[00:52:42] <ejegg>	 hi rel-eng. I see hashar's asleep, so I might have to wait for tomorrow on ^^^
[00:53:11] <ejegg>	 Just wondering why those skip-ifs weren't applied even before that patch
[00:53:58] <ejegg>	 i.e., why https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504607/ is failing due to mediawiki-quibble-vendor-mysql-php70-docker and mediawiki-quibble-composertest-php70-docker
[00:54:32] <ejegg>	 which don't work on the fundraising branch
[00:54:45] <ejegg>	 I'm pretty sure because they're checking out the wrong version of vendor
[03:01:26] <wikibugs>	 (03CR) 10Krinkle: [C: 03+1] Add WikibaseCirrusSearch to extension-gate [integration/config] - 10https://gerrit.wikimedia.org/r/504764 (https://phabricator.wikimedia.org/T204153) (owner: 10Hashar)
[05:23:08] <wikibugs>	 10Phabricator, 10Project-Admins, 10Release-Engineering-Team (Next), 10Documentation: Document how to convert projects into subprojects/milestones etc - https://phabricator.wikimedia.org/T221112 (10mmodell) The script is roughly documented upstream at https://secure.phabricator.com/T10350  The version I've...
[06:48:11] <wikibugs>	 10Phabricator, 10Project-Admins, 10Release-Engineering-Team (Next), 10Documentation: Document how to convert projects into subprojects/milestones etc - https://phabricator.wikimedia.org/T221112 (10mmodell) A better documented version of the script is now available: {f8b44b65514e6a94ebef6bd55bef202f76169d60...
[06:57:52] <wikibugs>	 10Phabricator, 10Project-Admins, 10Release-Engineering-Team (Next), 10Documentation: Document how to convert projects into subprojects/milestones etc - https://phabricator.wikimedia.org/T221112 (10mmodell)  ===NAME       move_project - Transform a project into either a subproject or milestone of another pr...
[08:11:06] <wikibugs>	 10Release-Engineering-Team, 10Language-strategy, 10incubator.wikimedia.org, 10Epic, 10I18n: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Zache) >>! In T165585#4773411, @Amire80 wrote: > Soon, when we start the technical architecture work. (I'm not totally sur...
[08:43:22] <wikibugs>	 10Release-Engineering-Team, 10Language-strategy, 10incubator.wikimedia.org, 10Epic, 10I18n: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Amire80) Any improvement that automates the procedure at  https://wikitech.wikimedia.org/wiki/Add_a_wiki is a good step in...
[08:47:35] <wmf-insecte>	 Project beta-scap-eqiad build #245714: 04FAILURE in 9 min 0 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245714/
[08:57:45] <wmf-insecte>	 Project beta-scap-eqiad build #245715: 04STILL FAILING in 8 min 49 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245715/
[09:05:25] <wikibugs>	 10Release-Engineering-Team, 10Language-strategy, 10incubator.wikimedia.org, 10Epic, 10I18n: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Susannaanas) I develop the #wikidocumentaries project, which navigates Wikimedia content using Wikidata as the linking str...
[09:07:38] <wmf-insecte>	 Project beta-scap-eqiad build #245716: 04STILL FAILING in 8 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245716/
[09:09:37] <wikibugs>	 10Phabricator, 10Project-Admins, 10Release-Engineering-Team (Next), 10Documentation: Document how to convert projects into subprojects/milestones etc - https://phabricator.wikimedia.org/T221112 (10Aklapper) >>! In T221112#5121789, @mmodell wrote: > Note we probably need a new `sudoers` rule added to allow...
[09:17:31] <wmf-insecte>	 Project beta-scap-eqiad build #245717: 04STILL FAILING in 8 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245717/
[09:27:54] <wmf-insecte>	 Project beta-scap-eqiad build #245718: 04STILL FAILING in 9 min 4 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245718/
[09:38:18] <wmf-insecte>	 Project beta-scap-eqiad build #245719: 04STILL FAILING in 9 min 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245719/
[09:48:43] <wmf-insecte>	 Project beta-scap-eqiad build #245720: 04STILL FAILING in 9 min 3 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245720/
[09:59:11] <wmf-insecte>	 Project beta-scap-eqiad build #245721: 04STILL FAILING in 9 min 3 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245721/
[10:09:28] <wmf-insecte>	 Project beta-scap-eqiad build #245722: 04STILL FAILING in 8 min 57 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245722/
[10:19:35] <wmf-insecte>	 Project beta-scap-eqiad build #245723: 04STILL FAILING in 8 min 47 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245723/
[10:29:48] <wmf-insecte>	 Project beta-scap-eqiad build #245724: 04STILL FAILING in 8 min 51 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245724/
[10:32:39] <wikibugs>	 10Continuous-Integration-Config, 10Operations, 10Documentation, 10Patch-For-Review, and 2 others: document all puppet classes / defined types!? - https://phabricator.wikimedia.org/T127797 (10hashar)
[10:39:54] <wmf-insecte>	 Project beta-scap-eqiad build #245725: 04STILL FAILING in 8 min 45 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245725/
[10:50:14] <wmf-insecte>	 Project beta-scap-eqiad build #245726: 04STILL FAILING in 9 min 0 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245726/
[11:00:27] <wmf-insecte>	 Project beta-scap-eqiad build #245727: 04STILL FAILING in 8 min 53 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245727/
[11:10:31] <wmf-insecte>	 Project beta-scap-eqiad build #245728: 04STILL FAILING in 8 min 44 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245728/
[11:20:43] <wmf-insecte>	 Project beta-scap-eqiad build #245729: 04STILL FAILING in 8 min 52 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245729/
[11:24:58] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-TranslationNotifications: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. - https://phabricator.wikimedia.org/T221354 (10hashar)
[11:25:49] <wikibugs>	 10Continuous-Integration-Config, 10MediaWiki-extensions-TranslationNotifications, 10phan-taint-check-plugin, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: phan-taint-check-plugin should ignore /extensions/ folder - https://phabricator.wikimedia.org/T201794 (10hashar)
[11:25:51] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-TranslationNotifications: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. - https://phabricator.wikimedia.org/T221354 (10hashar)
[11:27:29] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-TranslationNotifications: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. - https://phabricator.wikimedia.org/T221354 (10hashar)
[11:30:42] <wmf-insecte>	 Project beta-scap-eqiad build #245730: 04STILL FAILING in 8 min 37 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245730/
[11:40:43] <wmf-insecte>	 Project beta-scap-eqiad build #245731: 04STILL FAILING in 8 min 43 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245731/
[11:49:27] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10Daimona)
[11:50:45] <wmf-insecte>	 Project beta-scap-eqiad build #245732: 04STILL FAILING in 8 min 37 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245732/
[12:00:40] <wmf-insecte>	 Project beta-scap-eqiad build #245733: 04STILL FAILING in 8 min 36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245733/
[12:10:42] <wmf-insecte>	 Project beta-scap-eqiad build #245734: 04STILL FAILING in 8 min 43 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245734/
[12:20:50] <wmf-insecte>	 Project beta-scap-eqiad build #245735: 04STILL FAILING in 8 min 48 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245735/
[12:30:59] <wmf-insecte>	 Project beta-scap-eqiad build #245736: 04STILL FAILING in 8 min 48 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245736/
[12:40:58] <wmf-insecte>	 Project beta-scap-eqiad build #245737: 04STILL FAILING in 8 min 39 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245737/
[12:46:56] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-TranslationNotifications: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. - https://phabricator.wikimedia.org/T221354 (10Reedy) >So I guess the load order is wrong somewhere in operato...
[12:50:54] <wmf-insecte>	 Project beta-scap-eqiad build #245738: 04STILL FAILING in 8 min 36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245738/
[12:52:07] <_joe_>	 zeljkof, or anyone else
[12:52:14] <_joe_>	 please, we need a revert of the train
[12:52:27] <_joe_>	 I'll open a ticket ASAP
[12:52:33] <Reedy>	 _joe_: How far?
[12:52:39] <Reedy>	 All off .1?
[12:52:40] <_joe_>	 Reedy: just yesterdays
[12:52:48] <_joe_>	 or well, maybe all of it
[12:52:57] <_joe_>	 19:14 twentyafterfour@deploy1001: Synchronized php: group1 wikis to 1.34.0-wmf.1 refs T220726 (duration: 01m 49s)
[12:52:59] <Reedy>	 Just group 1 back to .25?
[12:53:02] <stashbot>	 T220726: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726
[12:53:09] <_joe_>	 compare with >	https://logstash.wikimedia.org/goto/0be3054549a641debf0c02cf2def61fd
[12:56:10] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10Volans)
[13:01:06] <wmf-insecte>	 Project beta-scap-eqiad build #245739: 04STILL FAILING in 8 min 50 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245739/
[13:01:43] <Reedy>	 Should work next run
[13:11:51] <wikibugs>	 10Continuous-Integration-Config, 10MediaWiki-extensions-TranslationNotifications, 10phan-taint-check-plugin, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: phan-taint-check-plugin should ignore /extensions/ folder - https://phabricator.wikimedia.org/T201794 (10Reedy)
[13:11:54] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-TranslationNotifications: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. - https://phabricator.wikimedia.org/T221354 (10Reedy) 05Open→03Resolved a:03Reedy
[13:12:36] <wmf-insecte>	 Yippee, build fixed!
[13:12:37] <wmf-insecte>	 Project beta-scap-eqiad build #245740: 09FIXED in 10 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/245740/
[13:17:10] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Thanks for the details :)" [integration/config] - 10https://gerrit.wikimedia.org/r/504764 (https://phabricator.wikimedia.org/T204153) (owner: 10Hashar)
[13:18:32] <shinken-wm>	 PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[13:18:38] <wikibugs>	 (03Merged) 10jenkins-bot: Add WikibaseCirrusSearch to extension-gate [integration/config] - 10https://gerrit.wikimedia.org/r/504764 (https://phabricator.wikimedia.org/T204153) (owner: 10Hashar)
[13:19:41] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Danke Schon for the cleanup!" [integration/config] - 10https://gerrit.wikimedia.org/r/504583 (owner: 10Lucas Werkmeister (WMDE))
[13:21:12] <wikibugs>	 (03Merged) 10jenkins-bot: Remove HPI students from CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/504583 (owner: 10Lucas Werkmeister (WMDE))
[13:40:49] <wikibugs>	 10Beta-Cluster-Infrastructure: Migrate away from Debian Jessie to Debian Stretch - https://phabricator.wikimedia.org/T218729 (10Krenair)
[13:40:51] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Patch-For-Review: Udev (?) problems using modified swift puppet classes on deployment-ms-be0[56] - https://phabricator.wikimedia.org/T220895 (10Krenair) 05Open→03Resolved
[13:41:44] <wikibugs>	 10Beta-Cluster-Infrastructure: Migrate away from Debian Jessie to Debian Stretch - https://phabricator.wikimedia.org/T218729 (10Krenair)
[14:17:30] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Mathoid, 10Operations, 10Core Platform Team Backlog (Watching / External), and 2 others: remove mathoid from scb - https://phabricator.wikimedia.org/T200832 (10akosiaris) >>! In T200832#5120806, @Krenair wrote: >>>! In T200832#5061718, @akosiaris wrote: >>>>! In T200832#505...
[14:39:36] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Backlog), 10Wikimedia-Logstash, 10Technical-Debt: Look into shoving gerrit logs into logstash - https://phabricator.wikimedia.org/T141324 (10Gehel) I had a conversation with @hashar about this topic. So here are a few idea:  * treating log messages as text only will lo...
[14:46:47] <ottomata>	 hi all
[14:46:53] <ottomata>	 i seem to have lost some permissions in jenkins
[14:47:06] <ottomata>	 e.g. 
[14:47:07] <ottomata>	 https://integration.wikimedia.org/ci/job/analytics-refinery-release/configure
[14:47:09] <ottomata>	 is giving me
[14:47:13] <ottomata>	 Ottomata is missing the Job/ExtendedRead permission
[14:47:14] <ottomata>	 and
[14:47:21] <ottomata>	 https://integration.wikimedia.org/ci/credentials/
[14:47:25] <ottomata>	 Ottomata is missing the Credentials/View permission
[14:47:42] <ottomata>	 jenkins is not able to deploy analytics/refinery/source right now, trying to figure out wy
[14:47:44] <ottomata>	 why*
[14:48:55] <ejegg>	 hashar: can you help me understand why patches to the fundraising/REL1_31 branch of core are running these failing quibble tests?
[14:49:11] <ejegg>	 for example this patch: https://gerrit.wikimedia.org/r/504607 
[14:49:28] <ejegg>	 There's a rule that seems like it should skip-if we're on that branch
[14:49:38] <ejegg>	 I actually don't want to skip ALL the quibble tests
[14:49:48] <ejegg>	 so this patch should fine-tune it: https://gerrit.wikimedia.org/r/504824 
[14:49:58] <ejegg>	 to just skip the ones that are failing there
[14:55:17] <_joe_>	 ottomata: when did you last try to modify a jenkins job?
[14:55:37] <ottomata>	 can't remember exactly, but probably sometime within the last year
[14:55:38] <_joe_>	 I had those permissions removed a long time ago
[14:56:02] <_joe_>	 we all were, only people in the ldap releng group have those abilities IIRC
[14:56:38] <ottomata>	 hm
[14:56:50] <wikibugs>	 10Release-Engineering-Team: Analytics admins no longer have needed Jenkins credentials - https://phabricator.wikimedia.org/T221379 (10Ottomata)
[15:11:54] <wikibugs>	 10Release-Engineering-Team: Analytics admins no longer have needed Jenkins credentials - https://phabricator.wikimedia.org/T221379 (10elukey) I just added my user and Andrew's to the LDAP group `ciadmin` and I am now able to see the Jenkins page. Let us know if keeping this credentials is ok or not :)
[15:14:54] <hashar>	 ejegg: hello !
[15:15:30] <hashar>	 ejegg: some of those branch / skip-if filters are being refactored.
[15:16:32] <hashar>	 ejegg: the list of jobs looks fine. I am looking at the reason they are failing
[15:17:56] <hashar>	 require(/workspace/src/vendor/composer/../../extensions/DonationInterface/gateway_common/WmfFramework.php): failed to open stream
[15:19:04] <hashar>	 which comes from /workspace/src/vendor/composer/autoload_real.php apparently
[15:19:36] <hashar>	 so I gues  mediawiki/vendor.git has an autloader entry for  the DonationInterface extension
[15:19:41] <ejegg>	 hashar: yeah, it's a bit odd
[15:19:51] <hashar>	 which is hmm. wrong?
[15:20:12] <ejegg>	 Well, the DonationInterface extension IS installed on fundraising/REL1_31
[15:20:31] <ejegg>	 but I think that test isn't pulling in the matching branch of vendor
[15:20:48] <Reedy>	 dejavu
[15:20:56] <ejegg>	 errr
[15:21:09] <ejegg>	 or rather, is it not pulling in the extension submodules?
[15:21:34] <ejegg>	 hashar: or rather, is it not pulling in the extension submodules?
[15:25:35] <hashar>	 ejegg: I replied on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504607/
[15:25:44] <hashar>	 those mediawiki-quibble jobs are to run the mediawiki/core tests
[15:26:04] <hashar>	 the extension tests are run by the quibble-donationinterface-REL1_31... job
[15:31:36] <ejegg>	 hashar: we're using the composer-merge-plugin to populate the fundraising/REL1_31 branch of vendor
[15:31:47] <ejegg>	 so it'll have all of the dependencies from all of the extensions
[15:32:00] <wikibugs>	 10Gerrit, 10Release-Engineering-Team, 10Patch-For-Review: Gerrit thread use GC thrashing - https://phabricator.wikimedia.org/T221026 (10thcipriani) Other thing to note in `gerrit show-caches` output:  `   Name                          |Entries              |  AvgGet |Hit Ratio|...
[15:32:16] <ejegg>	 Shouldn't the core tests pull down all the submodules present in that branch?
[15:32:33] <hashar>	 nop the job only run the mediawiki/core tests not the extensions ones
[15:33:12] <hashar>	 what we do for the wmf branches is that the dependencies from extensions are added to mediawiki/vendor composer.json
[15:33:29] <ejegg>	 wait, there's another composer.json INSIDE vendor?
[15:33:35] <hashar>	 we dont use the composer merge plugin to populate it
[15:33:41] <hashar>	 yeah :/
[15:34:13] <hashar>	 or in short there are two different use cases:
[15:34:33] <hashar>	 1) use composer. In this case at the root of mediawiki/core one creates a composer.local.json file that list the composer.json files from all extensions/skins etc
[15:34:41] <hashar>	 when runnin gcomposer install
[15:34:54] <ejegg>	 hashar: we actually deploy straight from git
[15:35:01] <hashar>	 the composer-merge-plugin kicks in. It reads the composer.json files listed in composer.local.json, then attempt to build a list of all dependencies
[15:35:08] <hashar>	 it then install all of that from packagist.org
[15:35:16] <hashar>	 which is fine for hmm development
[15:35:26] <ejegg>	 so we need to populate the fundriaisng/REL1_31 branch of vendor with the fully composer-installed stuff
[15:35:31] <hashar>	 for production that is widely different
[15:35:37] <ejegg>	 and it's working fine on production
[15:35:40] <hashar>	 yeah
[15:35:43] <hashar>	 so for prod
[15:36:09] <hashar>	 mediawiki/vendor has the list of all dependencies from mediawiki/core as well as the dependencies of all extensions
[15:36:10] <ejegg>	 (in our prod environment we run php7.0, not hhvm)
[15:36:16] <hashar>	 but that is manually maintained
[15:36:21] <ejegg>	 hashar exactly
[15:36:37] <hashar>	 yeah
[15:37:03] <hashar>	 so the way mediawiki/vendor.git fundraising branch got populated is a good idea (committing the result of a the composer merge plugin)
[15:37:04] <ejegg>	 so if a test is going to pull down the fundraising/REL1_31 branches of core and vendor, it should also check out the submodules on fr/REL1_31 branch of core
[15:37:07] <hashar>	 but is not what is expected 
[15:37:19] <ejegg>	 and if the test can't do that, I'd like to skip the test
[15:37:19] <hashar>	 hmm
[15:37:24] <hashar>	 no
[15:37:25] <hashar>	 ;)
[15:37:39] <hashar>	 the ^mediawiki-quibble.* jobs do not clone extensions at all
[15:37:51] <hashar>	 those jobs are solely to run mediawiki/core tests
[15:37:59] <hashar>	 to make sure that mediawiki/core itself is fine
[15:38:16] <ejegg>	 ok, so how do I skip those tests on the fundraising/REL1_31 branch? 
[15:38:43] <ejegg>	 It looks like the skip-if rule should be skipping ALL the quibble tests
[15:38:53] <ejegg>	 and in reality, I DO want it to run the donationinterface tests
[15:38:58] <hashar>	 well if they were to be skipped, that means that mediawiki/core tests would not run anymore
[15:39:15] <hashar>	 the DonationInterface tests are run by quibble-donationinterface-REL1_31-php70-docker
[15:39:28] <ejegg>	 Right, that job seems to run the core tests too
[15:39:29] <ejegg>	 https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_31-php70-docker/54/console
[15:39:37] <hashar>	 which does clone the extensions listed at the top somewhere
[15:39:39] <ejegg>	 12996 of 'em
[15:39:47] <hashar>	 and that job should be run by all those extensions
[15:40:24] <hashar>	 OHH
[15:40:27] <ejegg>	 So I think we can safely skip the other core tests which don't clone the submodules
[15:41:49] <hashar>	 ejegg: sorry ! :D
[15:41:53] <hashar>	 indeed it runs all tests
[15:41:55] <hashar>	 bah
[15:41:55] <ejegg>	 heh, no problem
[15:42:10] <hashar>	 the composer autoloader in vendor.git is still probably wrong though
[15:42:11] <hashar>	 ;D
[15:42:42] <ejegg>	 hmm, it works on prod?
[15:42:51] <ejegg>	 the rule we're changing here: https://gerrit.wikimedia.org/r/504824
[15:43:07] <hashar>	 and quibble-donationinterface-REL1_31-php70-docker uses composer update to provide the dependencies
[15:43:10] <hashar>	 (on top of vendor)
[15:43:11] <hashar>	 bah
[15:43:12] <hashar>	 what a mess
[15:43:19] <ejegg>	 is supposed to skip all the quibble tests on fundraising/REL1_31
[15:43:37] <ejegg>	 but it's not, somehow
[15:47:12] <hashar>	 aeha
[15:47:16] * hashar digs into code
[15:50:24] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Backlog), 10Wikimedia-Logstash, 10Technical-Debt: Look into shoving gerrit logs into logstash - https://phabricator.wikimedia.org/T141324 (10Paladox) I have a patch upstream to add support for log4j2, but since then upstream have a new logging framework that is a front...
[15:52:31] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-WebDAV, 10Patch-For-Review: WebDAV master is broken on PHP7.* CI: Use of undefined constant WEBDAV_AUTH_TOKEN - https://phabricator.wikimedia.org/T220888 (10Osnard) a:03Osnard
[15:52:53] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Backlog), 10Wikimedia-Logstash, 10Technical-Debt: Look into shoving gerrit logs into logstash - https://phabricator.wikimedia.org/T141324 (10herron) >>! In T141324#5122806, @Gehel wrote: > * structured logging from log4j can be exposed in a number of ways. The easier i...
[16:02:58] <wikibugs>	 (03PS1) 10Hashar: DonationInterface job should not use composer update [integration/config] - 10https://gerrit.wikimedia.org/r/504917
[16:03:44] <wikibugs>	 (03CR) 10Hashar: "I tried to drop 'composer update', but the job fails due to:" [integration/config] - 10https://gerrit.wikimedia.org/r/504917 (owner: 10Hashar)
[16:20:59] <wikibugs>	 (03CR) 10Hashar: "The generic rule should be kept, but we can add the skip-if to ta quibble job below." (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/504824 (owner: 10Ejegg)
[17:11:18] <wikibugs>	 (03PS2) 10Ejegg: Fine-tune test exclusion for core fr/REL1_31 branch [integration/config] - 10https://gerrit.wikimedia.org/r/504824
[17:12:52] <wikibugs>	 (03CR) 10Ejegg: Fine-tune test exclusion for core fr/REL1_31 branch (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/504824 (owner: 10Ejegg)
[17:22:14] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10mmodell)
[17:39:56] <ejegg>	 releng, anyone around to help un-block fundraising?
[17:40:09] <ejegg>	 I think this patch should do the trick: https://gerrit.wikimedia.org/r/504824
[17:40:42] <ejegg>	 we're running all the core tests in the quibble-donationinterface-REL1_31-php70-docker test
[17:41:26] <ejegg>	 so we can skip mediawiki-quibble-composertest-php70-docker and mediawiki-quibble-vendor-mysql-php70-docker
[17:41:33] <ejegg>	 which don't work on that branch
[17:46:17] <ejegg>	 we're hoping to deploy some stuff today
[17:46:32] <ejegg>	 and those failing tests are making it impossible
[18:00:11] <wikibugs>	 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Documentation, 10Patch-For-Review, 10Upstream: Doxygen doesn't handle `@inheritDoc` by default, only `@inheritdoc` - https://phabricator.wikimedia.org/T219001 (10Krinkle) At glance, it seems to be like the simplest option would be to standardise on `@...
[18:35:48] <Krinkle>	 ejegg|food: is there a zuul test case in the repo? that could help verify the concern you raised beyond doubt :)
[19:00:37] <ejegg>	 Krinkle: good point, i'll add one
[19:07:42] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10greg) >>! In T220726#5120182, @Stashbot wrote: > {nav icon=file, name=Mentioned in SAL (#wikimedia-operations), href=https://tools.wmflabs...
[19:09:07] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10greg) I see now: >>! In T221368#5122529, @Joe wrote: > @Reedy graciously reverted group 1 for me, as this was the cause for a UBN! ticket.
[19:14:33] <wikibugs>	 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn)
[19:17:13] <ejegg>	 Krinkle: oh hey, there is indeed a test for that
[19:17:17] <ejegg>	 test_donationinterface_docker_job_skips_on_mediawiki_core
[19:17:24] <ejegg>	 and it's passing just fine on that patch
[19:17:41] <ejegg>	 anyone available to CR / deploy it?
[19:17:42] <ejegg>	 https://gerrit.wikimedia.org/r/504824
[19:18:41] <wikibugs>	 (03CR) 10Reedy: [C: 03+2] Fine-tune test exclusion for core fr/REL1_31 branch [integration/config] - 10https://gerrit.wikimedia.org/r/504824 (owner: 10Ejegg)
[19:20:36] <wikibugs>	 (03Merged) 10jenkins-bot: Fine-tune test exclusion for core fr/REL1_31 branch [integration/config] - 10https://gerrit.wikimedia.org/r/504824 (owner: 10Ejegg)
[19:25:01] <Reedy>	 !log reloading zuul to deploy https://gerrit.wikimedia.org/r/504824
[19:25:03] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[19:25:19] <Reedy>	 ejegg: done
[19:26:22] <ejegg>	 thanks Reedy!
[19:27:40] <hashar>	 ejegg: +1 :)
[19:28:16] <hashar>	 ejegg: and probably we will want to rethink the tests for DonationInterface since you are manually updating submodules
[19:28:43] <hashar>	 or we can have Gerrit to automatically update the modules whenever the extension is updated. That is what we do for prod
[19:31:01] <ejegg>	 hashar we like to have some finer control over it
[19:31:48] <ejegg>	 sometimes we cherry-pick things to donationinterface deployment branch
[19:47:00] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Watching / External), 10Analytics: Status of analytics/limn-*-data git repositories? - https://phabricator.wikimedia.org/T221064 (10hashar)
[19:49:37] <hashar>	 ejegg: also the donation interface job runs "composer update"  so it would automatically get dependencies that might not be in vendor.git
[19:50:03] <hashar>	 when probably it should not run composer update  and later on something might explode because of a missing dep in vendor.git
[19:53:06] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] Add Pintoch to CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/504581 (owner: 10Lucas Werkmeister (WMDE))
[19:54:25] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] Skip composer-package-php70-docker [integration/config] - 10https://gerrit.wikimedia.org/r/504412 (https://phabricator.wikimedia.org/T220540) (owner: 10SBassett)
[19:54:33] <wikibugs>	 (03Merged) 10jenkins-bot: Add Pintoch to CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/504581 (owner: 10Lucas Werkmeister (WMDE))
[19:55:54] <wikibugs>	 (03Merged) 10jenkins-bot: Skip composer-package-php70-docker [integration/config] - 10https://gerrit.wikimedia.org/r/504412 (https://phabricator.wikimedia.org/T220540) (owner: 10SBassett)
[19:56:53] <wikibugs>	 (03CR) 10Pintoch: "Thanks a lot Lucas!" [integration/config] - 10https://gerrit.wikimedia.org/r/504581 (owner: 10Lucas Werkmeister (WMDE))
[19:57:04] <James_F>	 Hmm, is phpunit-coverage-docker-publish running on a php70 box? https://integration.wikimedia.org/ci/job/phpunit-coverage-docker-publish/874/console
[19:58:10] <James_F>	 Aha, right, T219319.
[19:58:10] <stashbot>	 T219319: Parsoid/PHP post-merge doc publishing task needs updating to use PHP 7.2 - https://phabricator.wikimedia.org/T219319
[19:58:39] <wikibugs>	 (03PS1) 10Krinkle: zuul: don't retain filter in cookies [integration/docroot] - 10https://gerrit.wikimedia.org/r/504967
[19:59:36] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] zuul: don't retain filter in cookies [integration/docroot] - 10https://gerrit.wikimedia.org/r/504967 (owner: 10Krinkle)
[20:00:07] <wikibugs>	 (03Merged) 10jenkins-bot: zuul: don't retain filter in cookies [integration/docroot] - 10https://gerrit.wikimedia.org/r/504967 (owner: 10Krinkle)
[20:00:13] <wikibugs>	 (03CR) 10jenkins-bot: zuul: don't retain filter in cookies [integration/docroot] - 10https://gerrit.wikimedia.org/r/504967 (owner: 10Krinkle)
[20:07:35] <wikibugs>	 (03PS1) 10Krinkle: shared: Remove unused '.logo' CSS [integration/docroot] - 10https://gerrit.wikimedia.org/r/504971
[20:08:19] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] shared: Remove unused '.logo' CSS [integration/docroot] - 10https://gerrit.wikimedia.org/r/504971 (owner: 10Krinkle)
[20:08:52] <wikibugs>	 (03Merged) 10jenkins-bot: shared: Remove unused '.logo' CSS [integration/docroot] - 10https://gerrit.wikimedia.org/r/504971 (owner: 10Krinkle)
[20:08:54] <wikibugs>	 (03CR) 10jenkins-bot: shared: Remove unused '.logo' CSS [integration/docroot] - 10https://gerrit.wikimedia.org/r/504971 (owner: 10Krinkle)
[20:14:04] <wikibugs>	 (03PS1) 10Krinkle: zuul: Remove excess top margin between nav and first heading [integration/docroot] - 10https://gerrit.wikimedia.org/r/504975
[20:14:34] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] zuul: Remove excess top margin between nav and first heading [integration/docroot] - 10https://gerrit.wikimedia.org/r/504975 (owner: 10Krinkle)
[20:14:58] <wikibugs>	 (03Merged) 10jenkins-bot: zuul: Remove excess top margin between nav and first heading [integration/docroot] - 10https://gerrit.wikimedia.org/r/504975 (owner: 10Krinkle)
[20:15:04] <wikibugs>	 (03CR) 10jenkins-bot: zuul: Remove excess top margin between nav and first heading [integration/docroot] - 10https://gerrit.wikimedia.org/r/504975 (owner: 10Krinkle)
[20:19:19] <wikibugs>	 (03PS1) 10Krinkle: zuul: Fix double underline in pipeline names [integration/docroot] - 10https://gerrit.wikimedia.org/r/504977
[20:19:57] <Krinkle>	 James_F: well, at least Zuul and auto-deploy of its static site are working.
[20:19:59] <Krinkle>	 and quick
[20:20:05] * James_F grins.
[20:20:10] <James_F>	 Nothing else is.
[20:20:11] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] zuul: Fix double underline in pipeline names [integration/docroot] - 10https://gerrit.wikimedia.org/r/504977 (owner: 10Krinkle)
[20:20:33] <wikibugs>	 (03Merged) 10jenkins-bot: zuul: Fix double underline in pipeline names [integration/docroot] - 10https://gerrit.wikimedia.org/r/504977 (owner: 10Krinkle)
[20:20:39] <wikibugs>	 (03CR) 10jenkins-bot: zuul: Fix double underline in pipeline names [integration/docroot] - 10https://gerrit.wikimedia.org/r/504977 (owner: 10Krinkle)
[20:30:21] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "change deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/504412 (https://phabricator.wikimedia.org/T220540) (owner: 10SBassett)
[20:30:28] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "change deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/504581 (owner: 10Lucas Werkmeister (WMDE))
[20:31:08] <wikibugs>	 (03CR) 10SBassett: "Thanks!" [integration/config] - 10https://gerrit.wikimedia.org/r/504412 (https://phabricator.wikimedia.org/T220540) (owner: 10SBassett)
[20:46:14] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10Krinkle)
[20:58:09] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10mmodell)
[21:15:42] <wikibugs>	 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn)
[21:16:00] <wikibugs>	 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn)
[22:14:41] * paladox backports https://gerrit-review.googlesource.com/c/gerrit/+/221412 so we can set site notices in gerrit!
[22:16:02] <paladox>	 Yay, 3.0 has been branched! - https://gerrit-review.googlesource.com/c/gerrit/+/221281
[22:45:41] <James_F>	 paladox: Should we keep trying for 2.16 or just plan to jump straight to 3.x?
[22:45:49] <paladox>	 2.16
[22:45:54] <paladox>	 we have to go 2.16 -> 3.0
[22:46:31] <paladox>	 2.16 includes the final migration for notedb (yay!) which allows (apart from only one table being left) that will be migrated in 3.0)
[22:46:44] <James_F>	 Ah, OK, so we'll need to do that anyway.
[22:46:51] <paladox>	 Yeh
[22:47:46] <paladox>	 *which allows us to finally drop the db!
[22:47:52] <paladox>	 making gerrit easier to fall over and backup
[22:48:24] <Reedy>	 java falls over very easily
[22:48:51] <paladox>	 not if it carn't connect to the db :P
[22:49:15] <James_F>	 paladox: I think you mean fail over, not fall over. ;-)
[22:49:27] <paladox>	 yup :)
[22:50:25] * paladox is going to be the most excited for gerrit 3.1
[22:50:35] <paladox>	 Polymer 2.0!
[22:51:38] <paladox>	 Polymer 3.0 is going to be a fun upgrade for the PolyGerrit team...
[23:00:56] <Krinkle>	 also, 2.16 is out last chance to see that the new ui has no blocking lackings (e.g. dashboards) whilst still being able to use the old UI temporarily.
[23:01:47] <Krinkle>	 James_F: Are you primarily on the new UI already? I figured you're probably a hold out like me given use of dashboards.
[23:01:50] <Krinkle>	 (I got that from you)
[23:04:43] <James_F>	 Krinkle: I am. I swap into old-UI a few times a day to do in-browser editing and switch back immediately.
[23:04:57] <James_F>	 Krinkle: Instead of dashboards, I have pinned tabs for finding patches I should care about.
[23:05:10] <Krinkle>	 Right, switcheroo, and bookmarked queries.
[23:05:12] <Krinkle>	 That works :)
[23:05:15] <James_F>	 E.g.
[23:05:15] <James_F>	 https://gerrit.wikimedia.org/r/q/is:open+-owner:self+-reviewedby:self+((project:mediawiki%252Fcore+OR+project:mediawiki%252Fextensions%252FVisualEditor+OR+project:mediawiki%252Fextensions%252FTemplateData+OR+project:mediawiki%252Fextensions%252FCite+OR+project:mediawiki%252Fextensions%252FCitoid+OR+project:mediawiki%252Fextensions%252FWikiEditor+OR+project:mediawiki%252Fextensions%252FCodeEditor)+OR+(owner:esanders+OR+owner:catrope+OR+owner:re
[23:05:15] <James_F>	 edy+OR+owner:matmarex+OR+owner:volkere))+-label:Code-Review%253C%253D-1+label:Verified%252B2
[23:05:32] <Krinkle>	 Yeah, but it means they aren't as easily shared with co-workers and updated  / in sync / offer a shared vision.
[23:05:48] <Krinkle>	 but yeah the only way in the new UI right now
[23:05:51] <James_F>	 Open stuff I've not not written or reviewed already that's V+2'ed and not C-1'ed in a bunch of repos or by a bunch of people.
[23:06:06] <Krinkle>	 e.g. https://gerrit.wikimedia.org/r/#/projects/performance,dashboards/custom:custom
[23:06:39] <James_F>	 Yeah. :-(
[23:06:54] <James_F>	 Lots of things fixed upstream, but only when we get to 2.16.
[23:07:40] <paladox>	 PolyGerrit is constantly changing in 2.16 too :)
[23:08:05] <paladox>	 in almost all releases of 2.16 there's been at least a Polygerrit change :)
[23:08:15] <paladox>	 (new features / bug fixes)
[23:08:52] <Reedy>	 Constant change isn't necessarily a good thing
[23:10:29] <paladox>	 Nothing drastically big, but stuff like new languages being syntax highlighted, a way to cherry pick commits even if it has merge conflicts (straight in the UI).
[23:10:57] <James_F>	 MW is constantly changing too, TBF.
[23:11:07] <James_F>	 And also, not necessarily in good ways. ;-)
[23:11:11] <paladox>	 I also did a commit to merge the diff preference into it's own shared component (sharing it between settings/diff screen) that is a biggish change since i could have missed bug :)
[23:11:13] <paladox>	 James_F lol
[23:12:00] <paladox>	 Krinkle im pretty sure that the functionaility for gwtui dashboard is 100% implemented in PolyGerrit 2.16.
[23:12:53] <Krinkle>	 paladox: Yeah, I'm aware it's a resolved task upstream. but like most things, we don't usually find out for real until we try it. And even if dashboards are great, we may identify other blocking issues.
[23:13:06] <paladox>	 oh
[23:25:08] <wikibugs>	 10Scap: Scap should only sync built CDB files to production appserver hosts, not the build files as well - https://phabricator.wikimedia.org/T221428 (10Jdforrester-WMF)
[23:40:01] <wikibugs>	 10Deployments, 10MediaWiki-extensions-LocalisationUpdate, 10I18n: Several VisualEditor-related messages haven't been updated in a while - https://phabricator.wikimedia.org/T166424 (10Jdforrester-WMF)
[23:40:37] <wikibugs>	 10Deployments, 10MediaWiki-extensions-LocalisationUpdate, 10I18n: Several VisualEditor-related messages haven't been updated in a while - https://phabricator.wikimedia.org/T166424 (10Jdforrester-WMF) Checking now, all three of those messages seem to have the exact same content on translatewiki.net, in the re...