[07:18:34] Yippee, build fixed! [07:18:34] Project mwcore-phpunit-coverage-master build #201: 09FIXED in 4 hr 18 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/201/ [09:15:53] (03CR) 10Daimona Eaytoy: "> I agree. I can't think of a good reason to pass a pointer to the" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [09:31:51] 10MediaWiki-Codesniffer, 10Code-Health: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) [09:33:40] (03CR) 10Daimona Eaytoy: [C: 04-1] "Proposed wording:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [09:45:02] 10MediaWiki-Codesniffer, 10Code-Health: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) Note that we should first change the hook handlers and remove the references there. [10:14:40] 10MediaWiki-Codesniffer, 10Code-Health, 10Patch-For-Review: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) ===EditPage=== No hook needs the reference. **Progress:** [] ApprovedRevs - https://gerrit.wikimedia.org/r/539654 [x] Article... [10:58:41] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) @epriestley: Thanks for the heads up! Indeed I tweaked the way that subtypes work slightly, to make it more extensible. I'd love it if we could upstream some of that but I don't know how much extensibility yo... [11:00:38] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) The local hack was to implement custom rendering of the subtype tag on workboards - "deadline" tasks render a due date on workboards and change the color of the tag as the deadline approaches. In order to imp... [11:15:35] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201909): CI mediawiki/core run times have increased since July 26thm 2019 - https://phabricator.wikimedia.org/T232626 (10Aklapper) [11:15:41] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201909): CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10Aklapper) [11:19:10] 10Phabricator, 10User-DannyS712: Add DannyS712 to #triagers - https://phabricator.wikimedia.org/T234081 (10Aklapper) 05Open→03Resolved a:03Aklapper Done [11:21:11] 10Project-Admins: Create user-SwedishMuseum project - https://phabricator.wikimedia.org/T234078 (10Aklapper) @SwedishMuseum: Please elaborate what this task is about. See https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks! [11:56:55] 10MediaWiki-Codesniffer, 10Code-Health, 10Patch-For-Review: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) [12:00:12] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Proposed wording:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [12:14:48] (03PS1) 10Daimona Eaytoy: Enforce docblock on private methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539663 (https://phabricator.wikimedia.org/T233838) [12:15:03] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Daimona) a:03Daimona [12:19:43] (03CR) 10jerkins-bot: [V: 04-1] Enforce docblock on private methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539663 (https://phabricator.wikimedia.org/T233838) (owner: 10Daimona Eaytoy) [12:20:54] 10MediaWiki-Codesniffer, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Daimona) AFAICS, the rules enforcing spaces before/after operands are in Squiz.WhiteSpace.OperatorSpacing, which means that they should be ch... [12:29:27] (03PS2) 10Daimona Eaytoy: Enforce docblock on private methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539663 (https://phabricator.wikimedia.org/T233838) [12:31:46] (03PS3) 10Daimona Eaytoy: Enforce docblock on private methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539663 (https://phabricator.wikimedia.org/T233838) [12:32:54] (03PS4) 10Daimona Eaytoy: Enforce docblock on private methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539663 (https://phabricator.wikimedia.org/T233838) [17:37:20] 10Beta-Cluster-Infrastructure, 10observability, 10Graphite: Graphite function sortByTotal() undefined in graphite-labs - https://phabricator.wikimedia.org/T234134 (10Krinkle) [17:37:21] 10Beta-Cluster-Infrastructure, 10observability, 10Graphite, 10Performance-Team (Radar): Graphite function sortByTotal() undefined in graphite-labs - https://phabricator.wikimedia.org/T234134 (10Krinkle) [18:16:24] (03CR) 10MarcoAurelio: "> No longer wanted? Should we Decline T230646 then?" [integration/config] - 10https://gerrit.wikimedia.org/r/530686 (https://phabricator.wikimedia.org/T230646) (owner: 10MarcoAurelio) [18:35:42] !log gerrit: Ran gerrit gc labs/tools/stewardbots --show-progress --aggressive [18:35:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:36:11] * paladox was in London today! [18:36:12] hauskatze: that should have ran this morning for all repos [18:36:32] Should it? It was cloning slow for me [18:38:25] Yeh [18:38:26] Hauskatze: https://github.com/wikimedia/puppet/blob/production/modules/gerrit/templates/gerrit.config.erb#L111 [18:38:44] paladox: Looks like we have more mising repos? https://gerrit.wikimedia.org/r/monitoring?part=graph&graph=logd178693542df3a56cf5565f2ce5d2e3c81319e54 ? [18:39:11] <3 cron [18:40:58] https://github.com/wikimedia/puppet/blob/production/modules/gerrit/templates/gerrit.config.erb#L208 <-- name of that group changed [18:42:12] Oh [18:43:34] I'll make a patch unless you want to. I'm leaving for dinner [18:44:32] The last one is known, just need to update it [18:44:33] hauskatze: yes please! [18:44:34] In Pizza Hut (London) [18:44:35] *Im in [19:04:52] (03CR) 10Krinkle: Force value of $wgSecretKey. (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/537118 (https://phabricator.wikimedia.org/T233092) (owner: 10Daniel Kinzler) [20:09:31] (03CR) 10Umherirrender: "I have run this against core, skins and extensions." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539564 (owner: 10Umherirrender) [20:42:33] 10Release-Engineering-Team, 10Wikibugs, 10Patch-For-Review: Exclude secondary Gerrit/jenkins-bot messages from Wikibugs on IRC - https://phabricator.wikimedia.org/T201261 (10Krinkle) [20:42:58] 10Release-Engineering-Team, 10Wikibugs, 10Patch-For-Review: Exclude secondary jenkins-bot/PipelineBot messages from Gerrit in Wikibugs on IRC - https://phabricator.wikimedia.org/T201261 (10Krinkle) [20:48:13] * paladox recommends London! [23:20:05] PROBLEM - Puppet staleness on integration-agent-docker-1006 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [23:22:38] PROBLEM - Puppet staleness on integration-agent-puppet-docker-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [23:24:02] PROBLEM - Puppet staleness on saucelabs-02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0]