[00:10:35] 10Scap, 10MediaWiki-Release-Tools: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10Legoktm) We could capture the output in Python and filter it on error? [00:18:11] 10Scap, 10MediaWiki-Release-Tools: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10thcipriani) might just need to remove the `2>&1` part, could use some experimentation. [00:18:39] 10Release-Engineering-Team, 10Scap, 10MediaWiki-Release-Tools: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10thcipriani) [00:19:44] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GitLab, 10User-brennen: Figure out submodule updating in GitLab - https://phabricator.wikimedia.org/T268283 (10thcipriani) [00:27:28] (03PS1) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [00:28:18] 10Release-Engineering-Team, 10Scap, 10MediaWiki-Release-Tools, 10Patch-For-Review: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10Reedy) The above ends up with ` PHP Parse error: syntax error, unexpected end of file in test.php on line 4 x... [00:44:31] (03CR) 10Reedy: scap_lint.py: Output errors from `php -l` (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [00:45:17] (03PS2) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [00:54:29] (03CR) 10Reedy: scap_lint.py: Output errors from `php -l` (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:01:04] (03PS3) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:02:05] (03PS4) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:04:04] 10Release-Engineering-Team, 10Scap, 10MediaWiki-Release-Tools, 10Patch-For-Review: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10Reedy) PS4 ` reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/tools/release/make-release$ cat test.php (03CR) 10Legoktm: [C: 04-1] scap_lint.py: Output errors from `php -l` (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:15:21] (03CR) 10Reedy: scap_lint.py: Output errors from `php -l` (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:17:18] lol that's the problem with copying over [01:17:20] (03PS5) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:17:24] s/scap/release/ [01:18:45] (03CR) 10Reedy: scap_lint.py: Output errors from `php -l` (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:21:44] Reedy: if you tested it I'll +2? [01:21:57] I'm just moving it a bit more [01:24:41] (03PS6) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:25:32] (03CR) 10jerkins-bot: [V: 04-1] scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:25:52] fail [01:26:22] (03PS7) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:27:27] (03CR) 10jerkins-bot: [V: 04-1] scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:28:09] (03PS8) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:31:12] 10Release-Engineering-Team, 10Scap, 10MediaWiki-Release-Tools, 10Patch-For-Review: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10Reedy) ` reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/tools/release/make-release$ cat test.php legoktm: ^ testing in that comment [01:32:01] * Reedy will port it to scap too [01:41:09] exceeeeept, scap tests isn't on a new enough version of python [01:43:32] (03CR) 10Reedy: "This change is ready for review." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/657832 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:44:08] (03PS3) 10Reedy: [WIP] Better handling of scap_lint errors [tools/scap] - 10https://gerrit.wikimedia.org/r/657832 (https://phabricator.wikimedia.org/T272760) [01:46:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Better handling of scap_lint errors [tools/scap] - 10https://gerrit.wikimedia.org/r/657832 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:51:27] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-General-or-Unknown, 10Performance-Team (Radar): Document and automate updating of static/project-logos in mediawiki-config - https://phabricator.wikimedia.org/T98640 (10Legoktm) I just had to go... [01:58:06] 10Release-Engineering-Team, 10Scap, 10MediaWiki-Release-Tools, 10Patch-For-Review: Output of scap lint.py isn't helpful if it fails the php -l check - https://phabricator.wikimedia.org/T272760 (10Reedy) What version of python is scap/scap tests running on? The patch I've done for tools/release is fine... B... [02:25:47] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-General-or-Unknown, 10Performance-Team (Radar): Document and automate updating of static/project-logos in mediawiki-config - https://phabricator.wikimedia.org/T98640 (10Krinkle) @Legoktm LGTM. On... [02:38:11] Reedy: I think you need to use https://docs.python.org/2/library/subprocess.html#subprocess.check_output [02:38:38] (the subprocess module really sucked until Python 3.5) [02:41:39] (03PS4) 10Reedy: [WIP] Better handling of scap_lint errors [tools/scap] - 10https://gerrit.wikimedia.org/r/657832 (https://phabricator.wikimedia.org/T272760) [02:41:52] Not helpd by various changes in minor releases [08:39:36] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-General-or-Unknown, and 2 others: Document and automate updating of static/project-logos in mediawiki-config - https://phabricator.wikimedia.org/T98640 (10Legoktm) My refactor ended up finding one... [10:38:14] (03CR) 10Gehel: pom: move release to Wikimedia (031 comment) [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657811 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [10:43:48] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-General-or-Unknown, and 2 others: Document and automate updating of static/project-logos in mediawiki-config - https://phabricator.wikimedia.org/T98640 (10Aklapper) Thank you so much for looking in... [14:57:50] (03CR) 10Umherirrender: Add SpaceBeforeBracketSniff for spaces between variable and array offset (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [16:11:31] (03CR) 10Hashar: pom: move release to Wikimedia (031 comment) [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657811 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [16:25:14] (03PS3) 10Hashar: pom: move release to Wikimedia [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657811 (https://phabricator.wikimedia.org/T271683) [16:25:16] (03PS1) 10Hashar: WIP drop mvn3 hack, update site plugin, drop emma coverage [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657996 [21:22:03] 10MediaWiki-Codesniffer, 10User-Majavah: Create PHPCS/ESLint rule to disallow `if else` blocks with an unnamed block likely intended as `else` - https://phabricator.wikimedia.org/T186939 (10Majavah) 05Open→03Resolved [22:02:50] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right. - https://phabricator.wikimedia.org/T272788 (10IN) [22:05:10] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10IN) [22:05:27] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10IN) [22:06:16] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10IN) [22:25:54] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10Peachey88) "some devices" is very undescriptive, can you for example provide which devices? the browsers it uses? [22:29:00] 10Phabricator: Phab.: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10RhinosF1) I've seen this on chrome for iOS [22:29:10] 10Phabricator: Phab: After adding an action on some devices, it cannot be removed i.e. there is no cross on the right - https://phabricator.wikimedia.org/T272788 (10RhinosF1) [22:31:43] (03PS1) 10Umherirrender: Zuul: [mediawiki/extensions/LegalLogin] Add quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/658010 [23:47:31] 10Phabricator: Phab: Unhandled Exception ("AphrontMalformedRequestException") - https://phabricator.wikimedia.org/T272790 (10Reedy)