[13:35:53] volans: jbond42: so re: https://gerrit.wikimedia.org/r/523675 and https://gerrit.wikimedia.org/r/523248 -- as is, these changes will result in the notes_url computed by nrpe::monitor_service all getting single-quotes put around them, even for a single notes link with no dashboard link, as seen by icinga. volans will this cause anything to change? [13:36:45] just the first symlink for the icon [13:37:05] as all of them will user icon-1.jpg (or whatever is the name) instead of icon.jpg [13:37:15] cdanis: that is fine. the first paramater with '' and a parater with out hyphens both get the same gif its just one will be a symlink and one will be a file [13:37:19] yes that [13:37:33] s/hyphens/quotes/ [13:39:35] ok great, thanks [13:41:02] btw jbond42 I verified that there are no non-HTTPS notes_urls for existing nrpe::monitor_service instantiations anywhere in puppetdb [13:41:16] oh cool cheers [13:41:47] very similar to https://phabricator.wikimedia.org/P8744 just a different jq instantiation [13:41:55] s/instantiation/incantation/ [13:42:18] abracadabra [13:42:26] appropriate for jq, tbh [13:42:29] * jbond42 bookmarked [13:42:33] nice thanks [13:43:03] btw that's not the most efficient way to get that data from puppetdb IIRC ;) [13:43:08] but I'd not nitpick it [13:43:12] ahaha [13:43:15] please, educate me [13:44:32] you can query the v4/resources/ endpoint with a a query to get only those with the param matching your criteria [13:44:39] https://puppet.com/docs/puppetdb/4.4/api/query/v4/resources.html [13:44:52] ooh [13:45:19] I have tried writing such queries on the puppetdb web interface but have never gotten the syntax right there, lol [13:45:19] it should allow to do it in a single query possibly (I didn't think about it too much) [13:45:32] that's normal [13:45:40] why do you think cumin has it's own query language? [13:45:42] lol [13:45:47] just for that, because the first use case was puppetdb [13:46:00] and I said... no I cannot require people to be able to query it [13:46:21] will not gonna work and I will get pinged every 5 minutes to write puppetdb queries :D [13:46:42] I still got pinged for a while to write cumin queries... but hey, nothing is perfect :D [13:48:01] I think of it as an implicit volans ping whenever I paste a cumin execution somewhere that just used a bunch of hostname globs [13:48:49] lol, feel free to ping anytime ;) [20:10:31] of course juniper says upgrade to 17.4R2-S2 or 17.4R3, but doesn't have anything more recent than 17.4R2...