[05:59:33] <_joe_>	 cdanis: I think i will
[06:04:11] <_joe_>	 but I've just seen that the CI image has been updated while I was away
[06:04:17] <_joe_>	 thanks to the docker registry issue
[06:04:23] <_joe_>	 so it's all good (more or less)
[08:54:30] <marostegui>	 can someone do a sanity check on this patch? https://gerrit.wikimedia.org/r/#/c/525777/
[09:03:47] <marostegui>	 Basically double checking the IPs :)
[09:28:11] <marostegui>	 thanks apergos <3
[09:28:22] <apergos>	 sorry for the delay, used to looking for those first thing in the morning  :-D
[09:28:50] <marostegui>	 no worries! :)
[09:28:56] <marostegui>	 thank you!
[15:09:51] <chaomodus>	 https://www.youtube.com/watch?v=w3krYEeqnyk
[16:09:47] <_joe_>	 I suggest reading https://vincent.bernat.ch/en/blog/2019-sustainable-python-script and keeping it as a bookmark; it's nothing shocking or particularly new, but it's a good standard
[16:09:58] <_joe_>	 for writing simple cli scripts in python
[16:11:20] <cdanis>	 thanks _joe_
[16:11:46] <_joe_>	 only thing I don't recommend is writing the tests in the same file as the code
[16:12:02] <cdanis>	 I actually would really like to do that in the case of stuff like icinga check commands
[16:12:26] <cdanis>	 --doctest-modules is something I had no idea about
[16:12:30] <_joe_>	 I'd prefer to have the puppet resource mandate the presence of a test file :)
[16:13:21] <_joe_>	 cdanis: me neither, and it seems nice for simple scripts
[16:14:40] <cdanis>	 it is one of those "obviously a really good idea in retrospect" things
[16:23:51] <cdanis>	 do we have --doctest-modules enabled on our CI, by the way?
[16:39:39] <_joe_>	 depends on tox.ini I guess?
[16:39:51] <chaomodus>	 haha
[16:39:55] <chaomodus>	 i was about to write like
[16:40:00] <chaomodus>	 almost exactly this blog post
[16:40:28] <chaomodus>	 not quite this elaborate