[09:18:51] <_joe_>	 arturo: when you remove a -1 from CI and then you don't fix the origin of it, someone else will have to do so next time they have to run tox. Cfr https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/488032/ and now that's biting me in https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/526110/
[09:19:05] <_joe_>	 so please don't, of if you do, try to fix the issue afterwards :)
[09:31:44] <arturo>	 _joe_: There is a comment from me stating the reason of my overriding jenkins. I don't see how your patch and mine are related?
[09:32:12] <_joe_>	 look at the jenkins failure console please
[09:32:50] <arturo>	 why is jenkins evaluating that code in your patch?
[09:33:02] <_joe_>	 my code modifies tox.ini
[09:33:05] <_joe_>	 hence it runs fully
[09:34:43] <_joe_>	 arturo: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/526116/ solves the issue
[09:36:08] <arturo>	 for the record, we know we have some pending cleanups to do, for example: T220051
[09:36:09] <stashbot>	 T220051: Puppet cleanup around OpenStack - https://phabricator.wikimedia.org/T220051
[09:36:18] <arturo>	 we just don't have time
[09:36:29] <_joe_>	 arturo: that's ok, and FWIW I do get why you wanted to exclude those files
[09:36:38] <_joe_>	 I'm telling you that patch of mine is the way to do it
[09:36:43] <_joe_>	 instead of overriding CI
[09:36:48] <_joe_>	 keep it in mind next time :)
[09:36:55] <arturo>	 ok 👍
[14:10:45] <cdanis>	 ...
[14:10:58] <cdanis>	 volans: does the version of flake8 that is run by puppet CI ... does it not understand keyword-only arguments?
[14:11:25] <volans>	 cdanis: it runs the py2 version unfortunately, let me grab the task
[14:11:37] <cdanis>	 :|
[14:11:44] <volans>	 T184435
[14:11:48] <cdanis>	 😖
[14:11:51] <volans>	 ah no bot here
[14:12:24] <cdanis>	 nuke py2 from orbit imo
[14:12:38] * cdanis brb ☕
[14:12:59] <volans>	 yeah one of the option was to switch to py3 and fix the py2 ones...
[14:16:19] <_joe_>	 cdanis: I just solved it for you
[14:17:04] <_joe_>	 https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/526109/
[14:17:08] <_joe_>	 well once I've fixed it
[14:17:36] <_joe_>	 then you can run your own tox.ini in your module autonomously
[14:17:57] <cdanis>	 neat
[14:18:20] <_joe_>	 you're lucky I was in your situation just this morning :D
[14:20:27] <cdanis>	 haven't looked let but the failed puppet run on pc1008 seems different from usual spam
[14:21:58] <cdanis>	 _joe_: do you think you'll have time to get that merged today?
[14:22:08] <cdanis>	 ofc py2 flake8 does not even understand print()
[14:22:32] <_joe_>	 I think so yes
[14:28:24] <marostegui>	 cdanis: Regarding pc1008, I just ran puppet and it worked, so it could have been a temporary thingy
[14:29:19] <marostegui>	 Looks related to andrewbogott's change, but a second puppet run fixes it? Notice: /Stage[main]/Base::Puppet/File[/etc/puppetlabs/facter/facter.conf]/ensure: defined content as '{md5}0ac4d780de8ce593cb3c91dea20f4807'
[14:29:37] <cdanis>	 ahh ok probably usual race condition garbage then
[14:29:44] <andrewbogott>	 marostegui: did it cause a failure?
[14:29:51] <cdanis>	 andrewbogott: a transient one
[14:30:01] <andrewbogott>	 huh
[15:13:14] <_joe_>	 cdanis: you will have to wait until the sre meeting I guess
[15:33:35] <andrewbogott>	 jbond42: do you think we'll be adding buster-backports to buster apt sometime soon, or is that likely a long way out?  (I'm updating the cloud base image for buster and wondering if I should just add that now so I don't have to rebuild when it shows up in prod)
[15:33:46] <andrewbogott>	 (that might be more of a moritz question)
[16:48:28] <paravoid>	 andrewbogott: he's off today
[16:49:00] <_joe_>	 cdanis: a new version of https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/526109 is ready
[16:49:19] <_joe_>	 do you want me to be bold, merge it and maybe you can revert if something goes wrong later on?
[16:51:23] <cdanis>	 _joe_: please