[04:29:26] In 30 minutes I will be restarting s4 master [05:16:18] phabricator down? [05:17:19] looks like it is back [05:17:21] WFM [07:58:57] godog: if you have a few minutes: https://gerrit.wikimedia.org/r/c/operations/puppet/+/595215 [07:59:12] that's a change to logstash inputs to make it more coherent [08:04:52] gehel: for sure! I'll take a look in a bit [08:05:01] thanks! [09:08:40] fyi ripe80 has just started https://ripe80.ripe.net/live/main/ [15:31:00] I am trying to find a way to add a user to trusted contributors so he can trigger CI runs, but I cannot find the documentation on mw.org [15:32:10] found it, I think: https://gerrit.wikimedia.org/r/#/admin/groups/1505,members [15:33:25] jynus: https://github.com/wikimedia/integration-config/blob/482309a2fd715000cc3426944576e3796d914bd5/zuul/layout.yaml#L60 is used for triggering on gerrit automatically and using ‘recheck’ [15:35:41] oh, I added him to that group, was that incorrect? [15:35:49] the one I mention above [15:37:49] jynus: I don’t actually know what Trusted Contributors adds on Gerrit. Someone like paladox or Reedy might know [15:37:57] I will ask to releng [15:38:09] It adds extra perms to for example upload to other peoples patches. [15:38:15] And allows you to upload more in batches [15:38:39] paladox: how does jynus add for triggering ci runs? [15:38:41] jynus that goes into integration/config (for ci) [15:39:01] paladox: https://github.com/wikimedia/integration-config/blob/482309a2fd715000cc3426944576e3796d914bd5/zuul/layout.yaml#L60 but on gerrit ? [15:39:27] Well that uses your email you have set in gerrit. [15:39:41] You add the users email there which will allow them to be able to run ci. [15:40:09] jynus: ^ [15:40:17] (must be the primary email though). [15:40:58] what does the gerrit group "Trusted contributors" does, then? [15:41:49] jynus: extra gerrit perms like paladox [15:41:58] 16:38:09 It adds extra perms to for example upload to other peoples patches. [15:42:05] I think trusted contributors lets amend other peoples patches etc [15:42:06] 16:38:16 And allows you to upload more in batches [15:42:07] ok did remove it there [15:42:13] will add it to the config [15:42:42] thanks all [15:42:44] I'm not even sure if I'm in trusted-contributors in gerrit [15:43:48] I’m in the phab one, I may be in gerrit. Not sure. [15:44:23] yeah i'm in the phab one [15:44:27] but not in gerrit one [15:44:30] https://gerrit.wikimedia.org/r/#/settings/group-memberships [15:48:44] this looks like something that should probably be unified :-D [15:50:40] I will wait for Hashar to +1 it: https://gerrit.wikimedia.org/r/#/c/integration/config/+/595968/ [16:14:47] o/ [17:08:11] in cases where we're maintaining our own patch to a debian package, how do we usually do that? quilt patch inside the source deb? do we put our own prefix (e.g. `wmf-0001-foobar.patch`)? [17:25:33] yes, and a wmf prefix is probably helpful [17:26:13] basically branch upsteam package (from their branch that has a debian/, which is probably a branch off of true upstream) and then add new patches in debian/patches/ and update changelog for a +wmf1 release or whatever [17:27:04] it gets really tricky when you want to build off of upstream packaging, but you want to both add custom local patches and use a newer version of the actual upstream project source, too [17:27:39] bu tI find in that case it's easier to merge in the upstream-most new stuff to your master in git terms, vs trying to make a quilter debian/patches/ out of the upstream-most changes, personally. [17:31:17] there's https://wikitech.wikimedia.org/wiki/Debian_Packaging too, but it's pretty lightweight and doesn't consider git clones and branching and patching and all that much. [17:31:22] maybe could use some updates :) [18:59:52] _joe_: what do you generally do to test a new php-fpm package? :D [19:01:54] <_joe_> cdanis: we install on beta, and on the debug servers. If nothing horrible happens in a few days, we move to the canaries [19:02:07] <_joe_> and we compare what happens with production traffic [20:23:00] o/ I just spotted https://phabricator.wikimedia.org/tag/sustainability/ [20:23:31] am I okay to use that and specifically the "incident prevention" column for wmde / wikibase related followups that would help / improve / prevent incident situations? [20:23:54] i guess that is the intention of the column, but just want to make sure that I am not about to "flood" it with things that shouldnt live there [20:25:19] it's newish and I believe that's the intention yeah [20:25:32] great! I'm gonna add a bunch of stuff then [20:25:34] woo! [20:26:42] addshore: Krinkle (not in this channel) is the person I've seen touching it most, you could ask him to confimr [20:26:44] *confirm [20:26:50] ack! ty