[08:50:14] can anyone tell me why gerrit hates me this morning? https://phabricator.wikimedia.org/P11689 [08:50:23] (trying to update an existing CR) [08:50:38] could it be because of the gerrit upgrade? [08:51:24] it is probably it yes [08:51:27] marostegui: it could, but i don't know what to do about it :) [08:51:49] kormat: what version of git-review you have? [08:51:59] `1.26.0-1` [08:52:12] pulled in by `wmf-sre-laptop` [08:52:31] kormat: not sure maybe trying to download that patch to a newer checked out repo and see if that works? [08:52:56] afaik gerrit 3 requires 1.27 or newer [08:53:06] ah. so it does. sigh [08:53:50] moritzm: ^ should we maybe package a newer version of git-review? [08:54:32] ahh. this is because i'm on ubuntu 18.04(ish). debian buster has 1.27 [08:55:21] my ubuntu 20.04 have 1.27 [08:55:53] XioNoX: how has 20.04 been for you? [08:56:01] all good [08:56:34] cool. i'll wait until the eqiuv linux mint release has been out a bit longer, and then upgrade [08:59:13] moritzm: unping. ;) [09:00:12] you can simply install the git-review 1.27 package from Debian testing, the dependencies are also fulfilled in older deb-based distros (just git, python3-requests and python3) [09:01:06] ah, good point. i ended up installing it from pip for the moment [09:01:32] but I'll make the git-review Depends >= 1.27, better make it explicit if it's now specifically required [09:02:01] +1 [09:02:22] in that case i'll uninstall the pip version and do what you suggest, otherwise upgrading wmf-sre-laptop will break for me :) [09:29:26] fyi getting http500 on github https://www.githubstatus.com/ [09:33:19] jbond42: can you tell me why jenkins is failing my puppet CR? https://gerrit.wikimedia.org/r/c/operations/puppet/+/608271 / https://integration.wikimedia.org/ci/job/operations-puppet-tests-buster-docker/6026/console [09:33:27] it says i have a style violation... [09:34:20] * jbond42 looking [09:35:30] kormat: you are now allowed to use a lookup call in a defined type [09:35:49] only in classes and then only in the profile:: classes [09:36:17] oh, fuck [09:36:36] so i have to go and manually pass the parameter from everywhere that uses this define? :/ [09:42:33] kormat: yes and no. as in yes you can do it that way however it is better to set a variable in a higher class and include it in the define . [09:43:32] kormat: https://phabricator.wikimedia.org/P11691#66604 [09:44:22] you may also be able to use a collection like the first post in that paste (https://phabricator.wikimedia.org/P11691) but i dont think that is ues elses where and i think the second pattern is more common [09:45:47] ok.. i _think_ i follow. [09:46:17] feel free to add me to a change or ping me with itterations for comment [09:47:08] cheers :) [09:49:30] np [09:59:31] about to switch idp.wikimedia.org to memcached. one complete you will need to re-login [10:34:20] \o/ [10:34:34] memcached 1.6.6, the future :D [10:35:02] :) [11:34:41] * jbond42 errand [13:18:57] sukhe: I have seen you are on clinic duty this week, I am talking to someone who might need something later, I might send them your way once I found if it is really needed [13:22:14] marostegui: yes I am, and yes sure :) [13:22:34] thank you! so far I am still gathering the info [14:07:08] jbond42 moritzm re: https://gerrit.wikimedia.org/r/c/operations/puppet/+/608305 is the x-frame-options issue still present ? [14:07:57] godog: i haven't explicitly seen it in a while, but cas-icinga is a Lot more unreliable for me than plain icinga. i don't know if that's related or not. [14:10:54] kormat: ah, unreliable as in fails to load or timeout or sth like that ? [14:12:15] godog: multiple times per day it will fail to refresh with some very vague error like "firefox can't connect to the site" [14:12:15] godog: not sure im testing today, would also be intrested in more details around "unreliable" [14:12:43] i've been unable to determine what is actually failing [14:12:51] dns/network/javascript/something completely else [14:13:10] jbond42: ok, thanks! left a comment on the review re: the vhost, the rest seems fine [14:13:30] i'll switch back to using it, and let you know [14:13:41] godog: yes just reponded re vhosts, tl;dr pcc is diffing the wrong files let me know if the extended explanation dosn;e make sense [14:14:03] kormat: please as im planning on making the cas version the default [14:14:56] * jbond42 adds kormat to https://gerrit.wikimedia.org/r/c/operations/puppet/+/608305/ [14:15:46] jbond42: I think the diff is correct, in the cas-icinga.wikimedia.org vhost I don't see a redirect for /problems for example, I'm guessing the templates got out of sync [14:18:42] godog: the diff being show in pcc is the diff of the new/old /etc/apache2/sites-available/50-icinga-wikimedia-org.conf. in the current config this file is generated with https://github.com/wikimedia/puppet/blob/production/modules/icinga/templates/apache.erb withthe new change it is generated using [14:18:47] https://github.com/wikimedia/puppet/blob/production/modules/profile/templates/idp/client/httpd-icinga.erb [14:19:44] and by /problems do you mean /alerts ? [14:20:11] jbond42: yes I think we're saying the same thing, httpd-icinga.erb is missing the redirectmatch for /problems [14:20:23] oh no you do mean problems, i dont think that one exists in the cas vhost [14:20:33] will add thanks [14:22:21] I'm not sure about the addhandler / scriptalias / alias directives though (line 3-13 in apache.erb) [14:24:04] godog: yes i think they are probably better moved into httpd::conf. ill create a seperate patch for them, thanks[3~ [14:24:47] jbond42: ack, thanks! [14:38:40] godog: that error is certainly still present, but should be overshadowed depending on the session type, if you log into the IDP with a remember me session, you'll hardly notice it, but if you have a a short-lived session, log into Icinga, then wait for w hrs and then click another link in Iicnga it should be reproducible [14:41:05] moritzm: i had wondered if the ProxyAs or Cookie scope issues had fixed it? [14:41:17] * jbond42 needs to start test again as had rember me ticked [14:44:51] I was wondering the same, but it seems unlikely, when I looked into a few weeks ago it was triggered by a redirect to the IDP login page (for re-login) from the frame mess in the Icinga UI [14:45:26] I'll poke at it tomorrow as well, out for an interview shortly [14:45:33] ack thanks [14:45:40] moritzm: ack, thank you, I'll give cas-icinga + "remember me" a try [14:49:42] akosiaris: do you have puppet-merge running. shows you have it locked and looks like its been going for 15 mins (forget or issue?) [15:02:17] akosiaris: ok gonna kill you session and take a look [16:27:44] jbond42: which one? [16:27:48] I thought we did all of them [16:28:08] i just noticed this ticket is still openhttps://phabricator.wikimedia.org/T239238 [16:28:28] marostegui: ^^ [16:28:57] jbond42: ah yeah, but we restarted the process [16:29:07] ack cool thanks [16:29:23] jbond42: https://phabricator.wikimedia.org/T251981 [16:30:17] jbond42: changed the parent task to avoid confusions [16:30:53] thanks :) [17:01:41] jbond42: just noticed this: https://usercontent.irccloud-cdn.com/file/Sza2VbKc/image.png [17:01:51] that was.. not the right window. [17:04:25] :) [17:08:32] https://usercontent.irccloud-cdn.com/file/i48GdFIJ/Screenshot%20from%202020-06-29%2019-03-12.png [17:08:38] jbond42: ^ [17:09:03] ah, and the more common one just happened: [17:09:07] https://usercontent.irccloud-cdn.com/file/TtTAsa1b/Screenshot%20from%202020-06-29%2019-08-50.png [17:09:42] jbond42: i should probably open a task and link these there, right? [17:18:39] kormat: yes please, this looks slightly different to the issues in https://phabricator.wikimedia.org/T251513 [17:19:08] would be usefull to know whats in the console and network tabs, although if its fixed with a refresh the network one is probably not much use [19:34:31] * sukhe wonders why reviewer-bot is adding people by itself [19:35:26] sukhe: it is looking at https://www.mediawiki.org/wiki/Git/Reviewers [19:35:36] where people can add themselves [19:35:48] matching regexes and repos to people [19:36:06] you could also add yourself for, say, "any change to wikidough module" [19:36:22] ahh right, I remember this now. I see that it matches ^modules(admin), which is why I see the people there [19:36:46] yeah!