[05:05:54] <wikibugs>	 6Team-Practices, 6Community-Advocacy, 6Community-Liaisons, 6Developer-Relations: Goal: Binding code of conduct for all Wikimedia technical spaces with consequences for breaches - https://phabricator.wikimedia.org/T90908#2189151 (10Ricordisamoa) >>! In T90908#2179158, @Mattflaschen wrote: > When the last se...
[05:25:12] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189177 (10Ricordisamoa) As @jayvdb, I also have some old changesets whose ETA → ∞, but I would only abandon them if they are unlikely to be ever needed i...
[06:54:48] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189297 (10Jdlrobson) >>! In T113706#1676726, @Tgr wrote: >>>! In T113706#1676473, @Reedy wrote: >> Conversely, what does keeping them around (non abandon...
[07:33:40] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189326 (10Ricordisamoa) Every patch must be dealt with carefully by a human. Just look at https://github.com/twbs-closer or https://github.com/twbs-rorsc...
[07:37:57] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189328 (10Qgil) The basic principles, imho:  # If a patch is ready for code review, it should be reviewed. ## When a patch has zero reviews, the burden i...
[11:30:45] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189649 (10Tgr) >>! In T113706#2189328, @Qgil wrote: > When the patch has -1 or equivalent, the burden is on the authors.  The problem with that is that G...
[11:46:47] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189680 (10Tgr) >>! In T113706#2189297, @Jdlrobson wrote: > If your patchset got abandoned would that not motivate you/remind you even more if it was impo...
[12:48:10] <wikibugs>	 6Team-Practices, 6Developer-Relations: Define Cut-off date for abandoning old changesets in our code review tool - https://phabricator.wikimedia.org/T113706#2189829 (10jayvdb) Regarding drafts, https://gerrit.wikimedia.org/r/#/q/is:draft,n,z has many merged changes,  for one listed that isnt merged e.g. https:...
[14:24:02] <wikibugs>	 6Team-Practices, 6Community-Advocacy, 6Community-Liaisons, 6Developer-Relations: Goal: Binding code of conduct for all Wikimedia technical spaces with consequences for breaches - https://phabricator.wikimedia.org/T90908#2190074 (10Krenair) >>! In T90908#2179158, @Mattflaschen wrote: > Given that, and the c...