[07:32:03] Is there anyone in here who can approve accounts on Phabricator? [07:37:35] Dustii, accounts don't need approving. What error are you getting? [07:39:33] Wait for Approval Your account has been created, but needs to be approved by an administrator. You'll receive an email once your account is approved. [07:39:51] RhinosF1 ^ [07:43:42] Dustii, I've never seen that before. Could you screenshot it? [07:44:56] RhinosF1 https://snag.gy/InXbLz.jpg [07:46:46] I've tried logging out and logging back in, I still get that same message. [07:48:23] Strange, if you hang around I'm sure someone can advise [07:49:33] It's not documented anywhere. What username did you use so when someone comes they can get on with it? [07:49:42] Dusti [07:50:50] Good luck [07:51:21] ty [07:54:45] The only thing I can think of is they've locked it due to the recent issues but I'm not see anything mentioned at https://lists.wikimedia.org/pipermail/wikitech-l/ [07:55:18] CFisch_remote: thank you very much, btw [07:56:04] mutante: you're welcome [07:56:17] glad I could help a bit ^^' [08:04:42] Dustii, See https://lists.wikimedia.org/pipermail/wikitech-l/2019-April/091878.html [08:05:10] Thanks! [08:05:27] No problem [08:07:15] * Dustii thinks we should blame it on addshore #justbecause [08:09:29] Is there anything specific you need doing dustii? [08:10:51] I'm trying to sign the confidentiality agreement for ACC [08:10:52] lol [08:11:27] Yeah, I can't help with that!! [08:55:48] Is there a Phab admin in here by chance? [08:56:05] Dustii, see https://lists.wikimedia.org/pipermail/wikitech-l/2019-April/091879.html it's an anti spam measure. [08:56:08] * Dustii just saw the reply [08:56:17] that's why I was seeing if there was a phab admin :p [08:56:29] That email went out to all developers and many members [08:57:01] The main one will be Aklapper who is normally andre_ on here [09:01:13] Dustii, none are active at the moment. [09:01:57] A lot are US/CA based so it's probably best to ask later today. [09:09:08] Dustii, try now please. [09:09:32] Not approved flag has gone off your userpage [09:10:30] Yeah, Aklapper has seen it [09:12:30] yay! [09:12:33] Thanks Rhinos [09:12:59] No problem! All I did was send an email!! [10:33:22] How is the 'availability' status on phab calculated? [10:43:44] RhinosF1: I assume it’s based on your vacation events https://phabricator.wikimedia.org/calendar/event/edit/form/44/ [10:47:47] thanks lucas_wmde [13:09:31] The page https://en.wiktionary.org/wiki/ads fails to load in Chrome for myself and some other users, ad-blocker is not claiming to be blocking it, loads in Edge, anyone have ideas? [13:10:14] cant confirm. can load fine in Chrome [13:10:37] neither chrome nor firefox dsplay it [13:11:25] wut? [13:12:13] I have ublock orgin for firefox and something-r-other for chrome [13:12:23] no issues in any browser: firefox, chrome, chromium, brave [13:12:25] whaever I have for chrome has no added sites in it, just whatever comes out of the box [13:12:41] view source shows that all source is retrieved [13:12:48] i bet it's ublock origin then? [13:13:02] it looks like some overly zealous CSS rule is setting display: none !important on the whole page [13:13:09] because of the “ads” [13:14:00] I can’t figure out where it’s coming from, though [13:14:18] inspector says it’s loaded from a data: URL [13:14:32] the matching selector is .page-ads btw [13:15:57] ublock origin says it's blocking 0 elements in ff, but there might be some broad rule like that embedded in there [13:16:50] here’s the full rule that Firefox is showing me: https://phabricator.wikimedia.org/P8346 [13:17:07] display none on the whole body [13:17:13] oh you have something better [13:17:25] okay yeah if I disable uBlock Origin the rule goes away [13:17:30] it’s that extension [13:17:34] (probably) [13:18:24] TheDaveRoss: ^ :) [13:18:47] well that sucks [13:18:58] I think it’s part of EasyList [13:19:03] not going to disable... life on the internet is unlivable without it [13:19:04] but I’m not sure if I’m understanding this filter list UI correctly [13:19:33] just checked for me and https://en.wiktionary.org/wiki/ads is not apperaing when adblock IS on [13:27:26] AdGuard adblocker is blanking the page on chrome for me, page visible when adblock is disabled [13:27:58] I’m trying to clone the EasyList repo to find out when this was introduced [13:28:04] but holy shit it’s a large repo… [13:29:37] Lucas_WMDE, I've raised a ticket with adblock regarding them blocking it all (#62765) PM me an email if you want access. Same to anyone else. [13:30:25] https://help.getadblock.com/support/tickets/62765 [13:31:11] Lucas_WMDE: RhinosF1 i can confirm same with firefox [13:31:35] RhinosF1: looks like this was added in https://github.com/easylist/easylist/commit/b34682f617ec02b3365aedd237452dfd9cc9da2d, feel free to leave that information in the ticket [13:31:42] I don’t think I need to be subscribed to it tbh [13:31:59] (also I reckon all the other .page-something rules there will have similar results [13:32:31] hm, no, https://en.wiktionary.org/wiki/ad doesn’t seem to be blocked… [13:35:39] Zppix, Lucas_WMDE, Updated the ticket [13:37:02] RhinosF1: cool [13:52:24] I've posted at Wiktionary's information desk stating the issue is reported https://en.wiktionary.org/wiki/Wiktionary:Information_desk#ads_blocked_by_AdBlock [14:10:44] sorry I asked and then ran to a meeting, thanks for tracking it down and reporting it everyone [14:12:49] TheDaveRoss, no problem. [14:13:35] Lucas_WMDE, Zppix, TheDaveRoss, It's definately easylist blocking it from what a discussion with someone else. [14:13:56] which, sadly, makes it an issue with most adblockers instead of just one [14:14:05] ah [14:14:36] yes, can be reproduced on multiple ones. [14:15:09] A bug report with easylist will be filed shortly [14:18:38] TheDaveRoss, Zppix, Lucas_WMDE - https://github.com/easylist/easylist/issues/3188 is now filed [14:23:19] FYI RhinosF1, on Wiktionary the "Grease Pit" is the technical forum, no big deal to have it at Information Desk but for next time [14:23:54] Thanks, TheDaveRoss, I've noticed that now. Thanks for reporting. [14:24:49] We have trouble keeping track of where to discuss things ourselves, no surprise that others would have trouble guessing as well :) [14:25:37] RhinosF1: thanks [14:26:00] It seemed the most logical place to get a message out to everything [14:26:09] RhinosF1: "everything" [14:26:14] everyone [14:26:22] i liked everything better lol [14:26:25] * RhinosF1 facepalms [14:43:05] TheDaveRoss, Zppix, Fix is being deployed now [14:43:17] RhinosF1: ok [14:44:41] my easylist has an explicit "wiktionary.org#@#.page-ad" rule, beyond the blanket "page-ad" one, strange [14:46:48] wow [14:47:14] an whitelist on easylist was put on with https://github.com/easylist/easylist/commit/f7df876ff78d0790cb07cf2a2f3d337509430709 [14:47:15] that's oddly specific [14:48:44] 12 minutes ago? wut [14:49:28] Yes, wiktionary was added to the whitelist 12 mins ago [14:50:27] seems to make no sense to have wiktionary.org in any way [14:50:34] especially if you dont also have wikipedia [14:56:00] mutane, create an issue asking for all wmf sites to be whitelisted [14:56:12] ^mutante, fix ping [15:03:34] fair enough, but i am not even affected [15:04:07] Mutante, Might be best for WMF to push for it [15:04:14] I'll try an email [15:09:06] I've emailed WMF to see if they can deal with from Thier side. [15:12:49] RhinosF1: thanks for making the ticket, saw backlog [15:13:52] It got handled pretty quick, we're less than 2 hours since the report [15:14:36] Looks like first report came in at 06:19 UTC so not bad for us [20:38:15] Would it be possible to find a list of any pages on content wikis that ended in ads or advert? [20:39:52] Tbh, just a number of pages would be fine. [20:40:01] Excluding redirects [20:41:00] To clarify, I want the number of pages of content wikis that's title ends with ads or advert and is not a redirect [20:41:41] These are content wikis - https://en.wikipedia.org/wiki/Wikimedia_Foundation#Content_projects [20:49:19] Its possible to do that as a db query on say toolforge [20:49:32] would take a little while to run though probably, as suffixes aren't indexed [20:50:36] But the query is SELECT count(*) from page where (page_title like '%ads' OR page_title like '%advert') AND page_is_redirect = 0; [20:50:53] you'd have to do that for every wiki (probably easiest to do with a script, even if just a for loop in shell) [20:53:31] Bawolff_, How would you set up a script to do it? Is it worth doing if I'm trying to estimate how many pages were affected by https://github.com/easylist/easylist/issues/3188? [21:01:57] RhinosF1: Something like [21:01:59] for i in `cat all.dblist`; do sql -N "$i" 'SELECT DATABASE(),count(*) from page where (page_title like "%ads" OR page_title like "%advert") AND page_is_redirect = 0;'; done [21:02:26] works better with normal mysql command where you can specify -B for batch mode [21:02:55] Bawolff_, Where would I run that from? [21:03:28] from a toolforge shell account [21:03:32] if you have one [21:03:39] I actually do [21:05:05] Or actually i can just the command [21:05:06] https://tools.wmflabs.org/bawolff/wikiads.txt [21:05:41] I forgot to mention you need wget 'https://noc.wikimedia.org/conf/dblists/all.dblist' [21:05:49] Im also not sure if this will timeout on enwiki [21:06:38] Thanks, Bawolff_ [21:07:23] Well it seems like its on B's already [21:07:32] but enwiki is the challenging one [21:07:57] This is all namespaces btw, not just main [21:08:26] As far as I know, all namespaces should have been affected by the issue [21:10:45] yeah i just wasn't sure if you were caring about non-content namespaces [21:10:54] huh, I probably should of put this in the grid engine [21:12:30] I imagine they're less likely to be viewed but still should have been affected - Bug report says 'it likely affects lots of other wiki pages that happen to use a CSS class based on the page name.' [21:12:48] ok, I'm going to restart this so its a grid job so nobody is mad at me [21:13:19] okay, no problem [21:15:54] bawolff_, Where would be best to place an incident summary describing a external technical issue affecting wmf wikis. Excluding WikiTech as I can't register for that. [21:16:24] I mean, usually we do incident reports for our own issues (servers going down) [21:16:32] I'm not sure if this fits with that [21:16:45] That said, if you want an account on Wikitech, I can create one for you [21:17:15] Yeah, I'm happy for you to, I'm RhinosF1 everywhere. [21:17:41] I'll start the incident report, just not sure where to. [21:18:06] I'm not sure it's a good idea to try to create RhinosF1's account on wikitech bawolff_ [21:18:23] I'm not sure what effect it might have on his existing LDAP account [21:18:44] Usually an autocreation like that would be done by the user themselves by logging in with their LDAP password [21:18:48] I don't think you should write an incident report in the same place as the wikitech one, unless someone says its ok, as those are really of a different type [21:18:58] Does he already have an ldap user? [21:19:01] To do it as an admin you'd have to go to create their account using a new password, not sure how that would get handled [21:19:17] Yes, I'm already on LDAP [21:19:20] Yes, registered via toolsadmin but not linked on wikitech AIUI [21:19:37] I think then he should just be able to login with his ldap credentials [21:19:41] No [21:19:44] Creation is disabled [21:19:56] right [21:20:11] but would this be considered an "autocreation" [21:20:19] sure but it's still blocked [21:20:20] bawolff_, I don't think there's currently any incident report per https://lists.wikimedia.org/pipermail/wikitech-l/2019-April/091897.html [21:22:11] If you know the implications of doing an admin creation in this circumstance then by all means, but if it were up to me I'd avoid doing so until I knew [21:22:43] right, because nobody has autocreateaccount rights [21:23:08] Krenair: No, i think you're right and i don't feel confident enough to do it [21:23:11] Sorry RhinosF1 [21:23:36] Krenair, Honestly, I just want to know where's best to summarise what happened and get an idea of how big the impact was. [21:23:46] Well, ideally wikitech. [21:24:03] But that's understandably problematic. [21:24:10] Well, Ideally, but that's out of it [21:24:22] I guess some page on meta is the next best bet [21:24:53] My job doesn't seem to be running on toolforge... [21:25:02] I've noticed that [21:25:08] probably [21:26:33] Would https://meta.wikimedia.org/wiki/Tech/20190404-Adblock-issue make sense?? [21:28:37] ^^ Krenair, bawolff_ [21:28:54] Sure I guess. If people don't like it it can be moved later [21:28:57] well, I don't see any harm in it [21:29:35] ^ [21:29:46] Well https://tools.wmflabs.org/bawolff/wikiads.txt seems to be going again [21:29:47] I'm being bold and doing it then, bawolff_ ping me when we have a number on how many pages were affected [21:30:04] Its going to be a little while, especially for enwiki which is huge [21:30:17] I'm not even sure if there are timeouts to prevent me from doing full table scan on enwiki [21:30:32] good luck to us [21:31:36] Well now its doing commons, which is also a huge wiki [21:47:12] RhinosF1, Has anyone been able to reproduce errors at other wikis? E.g. I can see this page just fine, with uBlock Origin enabled: https://en.wikiversity.org/wiki/Advertising - If not, then I don't know if the numbers being researched above will be at all reliable, or indicative of anything. [21:49:17] quiddity, Issue only affects pages whose URLS end in ads or advert not just including those words. It was reproduced on German Wiktionary but it's possible you're PR has been merged as well now. [21:53:31] RhinosF1, my point is that I don't think this issue is important enough to take up the attention of developers for all this research, nor to write about at length. It was a bug, it affected a couple of pages, it was fixed. There are bigger problems to work on! [21:55:49] I'm not 100% sure myself exactly how wide the impact was. Yes, there are bigger things to do but bawolff_ has kindly offered to run it and i've got nothing better to do tbh. [21:56:33] (It's great that it was spotted, reported, and resolved. But we've got to be efficient about these things. There are many thousands of bugs, and only a limited number of hours in each day for the people who work on them.) [21:57:42] I agree. bawolff_ is in no way obligied to do anything and I thank him for his help. [21:59:40] FWIW, i don't really think this is a big enough issue to really need a write up, but if you want to write one I don't have any objections [22:00:11] as far as the script - don't thank me yet, it hasn't worked yet on big wikis ;) [22:00:25] And i already had similar scripts saved for other things [22:00:53] Eh, A write up isn't that bad [22:23:05] https://meta.wikimedia.org/wiki/Tech/20190404-Adblock-issue - done - Off to bed now - Send me an email if you have any questions - Don't rush any stats or anything if you're busy or feel obliged to do anything [22:28:01] RhinosF1: I mean, either this stats run will work, or it won't. I probably won't do much else if it doesn't work [22:29:01] hey, it got past commonswiki [22:29:32] commons is larger then enwiki, so it will probably work everywhere [23:01:03] RhinosF1: script finished https://tools.wmflabs.org/bawolff/wikiads.txt total was 26910