[11:00:14] New review: Daniel Werner; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9854 [11:00:35] Change merged: Daniel Werner; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/9854 [11:02:55] New review: Daniel Werner; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9855 [11:03:33] Change merged: Daniel Werner; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/9855 [11:04:19] New review: Daniel Werner; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9856 [11:04:21] Change merged: Daniel Werner; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/9856 [13:36:10] Abraham_WMDE: can you please run the unit tests and hit everyone who wrote one that's broken with something? [13:36:22] Otherwise stuff is going to stay broken :<0 [14:06:27] JeroenDeDauw: what's broken right now? [14:12:19] New patchset: John Erling Blad; "Additional changes to get aliases to work properly in the API." [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/9365 [14:51:21] New patchset: Jeroen De Dauw; "Move tests from Wikibase to WikibaseLib (matching earlier move of the classes they test). Also did some renaming and fixed test registration." [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10436 [14:51:28] New patchset: Jeroen De Dauw; "Move tests from Wikibase to WikibaseLib (matching earlier move of the classes they test). Also did some renaming and fixed test registration." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10437 [15:11:33] New patchset: John Erling Blad; "Take 2; Updates for aliases. Depends on a update for Item to be functional." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/9364 [15:17:03] New patchset: Jeroen De Dauw; "remove empty tests stubs just cluttering phpunit output. also removed a completely broken test (asserting that wgLang is a string, obviously...) not doing much usefull stuff anyway." [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10440 [15:18:24] Jens_WMDE: daaaaah! merge the stuffs already. After you're done you'll be able to run this and only see nice green colors: [15:18:25] php phpunit.php --group Wikibase --exclude-group WikibaseAPI [15:19:36] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/9364 [15:20:26] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10440 [15:20:32] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10440 [15:22:12] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10437 [15:22:14] Change merged: Jens Ohlig; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10437 [15:22:31] happy now? [15:22:49] JeroenDeDauw: happy now? [15:23:39] Jens_WMDE: not yet: https://gerrit.wikimedia.org/r/#/c/10436/ :p [15:27:57] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10436 [15:27:59] Change merged: Jens Ohlig; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10440 [15:28:00] Change merged: Jens Ohlig; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10436 [15:32:11] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9364 [15:36:12] New patchset: Aude; "put new item notification after site notice" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10442 [15:45:09] New patchset: Daniel Kinzler; "moved rendering logic from Content class to ContentHandler class" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10445 [15:47:54] New patchset: Daniel Kinzler; "signature of getDeletionUpdates changed" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10447 [15:51:26] New patchset: Daniel Kinzler; "moved rendering logic from Content class to ContentHandler class" [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10448 [15:51:51] i just pushed some braking changes to the Wikidata branch [15:52:02] ooooh [15:52:05] i already fixed Wikibase and WikibaseLib, but the fixes need review [15:52:13] JeroenDeDauw: would you? [15:53:05] Daniel_WMDE: sure [15:53:12] thanks [15:53:28] Daniel_WMDE: btw, if you want to have the zen feeling, run php phpunit.php --group Wikibase --exclude-group WikibaseAPI [15:53:29] i tested everything, but then juggeled with commits and branches and modules and gerrit and stuff,... [15:53:36] i hope i got it right :) [15:53:39] Or if you want to kill yourself, php phpunit.php --group WikibaseAPI [15:53:52] yes. I excluded the API [15:53:56] it's completely broken [15:53:59] why is that? [15:54:10] i thought all tests should pass before stuff gets comitted?... [15:54:22] i guess everyone did what i did: ignore it, toi be able to keep working :/ [15:54:40] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10445 [15:54:42] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10445 [15:55:06] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10447 [15:55:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10447 [15:55:44] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10448 [15:55:46] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10448 [15:57:44] i'll be semi-afk for a while [15:57:54] püing me if i broke something [15:58:33] Daniel_WMDE: did you run teh tests? I see broken stuffz now! :p [15:58:36] Will fix tho [16:03:35] New patchset: Jeroen De Dauw; "fix incorrect argument from https://gerrit.wikimedia.org/r/#/c/10445/" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10450 [16:03:53] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10450 [16:03:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10450 [16:04:07] Daniel_WMDE: ok, it's fixed now [16:04:08] https://gerrit.wikimedia.org/r/#/c/10450/1/includes/ItemHandler.php,unified [16:11:03] * Lydia_WMDE waves [16:20:15] JeroenDeDauw: hm... maybe i didn't run the tests for the extension. sorry. [20:19:49] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10526 [20:22:28] New review: L10n-bot; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10526 [20:22:30] Change merged: L10n-bot; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10526